mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	 Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: fsl-ldb: Remove panel naming and use scoped device_node cleanup
Date: Thu, 5 Nov 2026 09:25:30 +0200	[thread overview]
Message-ID: <auwrIKJi-v9svTdW@vm> (raw)
In-Reply-To: <DMMMCJHUT8EL.1L6VS1X1K2BQE@bootlin.com>

Hi Luca,

On Wed, Nov 04, 2026 at 06:56:41PM +0100, Luca Ceresoli wrote:
> On Fri Oct 30, 2026 at 5:32 PM CET, Laurentiu Palcu wrote:
> > The remote endpoint node is not necessarily a panel, so drop the "panel"
> > naming and refer to the next bridge instead. Update the error message
> > printed when no output port is connected.
> >
> > While at it, convert the device_node handling in fsl_ldb_probe() to use
> > the __free(device_node) cleanup helper. Since remote1 and remote2 now
> > stay valid until the function returns, pass the selected one directly to
> > of_drm_find_and_get_bridge() and drop the extra panel_node reference.
> > Do the same for the dual-link port1/port2 lookups.
> >
> > No functional change intended, other than the updated error message.
> >
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> 
> I wanted to test this patch but it does not apply on current
> drm-misc-next.

Sorry about that, I made these changes on top of Dario's patch [1],
touching the same file. I thought that would probably be applied first.
FWIW, my patch applies cleanly on drm-misc-next if [1] is applied first.

Do you want me to resend the patch so that it applies directly on top of
drm-misc-next?

[1] https://lore.kernel.org/all/20261029144132.572020-1-dario.binacchi@amarulasolutions.com/

-- 
Thanks,
Laurentiu

  reply	other threads:[~2026-11-05  7:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 16:32 Laurentiu Palcu
2026-11-04 17:56 ` Luca Ceresoli
2026-11-05  7:25   ` Laurentiu Palcu [this message]
2026-11-05  8:01     ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auwrIKJi-v9svTdW@vm \
    --to=laurentiu.palcu@oss.nxp.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®