From: Dan Carpenter <error27@gmail.com>
To: Laurian Iacob <laurian.iacob@yahoo.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: staging/ipu7: use guard(mutex) and simplify retry loop in buttress
Date: Thu, 5 Nov 2026 10:14:08 +0300 [thread overview]
Message-ID: <auwswLdxTSjA5BTL@stanley.mountain> (raw)
In-Reply-To: <20261104222832.32471-1-laurian.iacob@yahoo.com>
On Thu, Nov 05, 2026 at 12:28:32AM +0200, Laurian Iacob wrote:
> Use scope-based guard(mutex) from linux/cleanup.h in
> ipu_buttress_ipc_send_msg() and ipu_buttress_authenticate() to simplify
> error handling and remove redundant goto unlock paths.
Unfortunately, you didn't remove them all.
>
> Additionally, replace the backward goto retry label in
> ipu_buttress_ipc_send_msg() with a standard for (;;) loop to improve
> control flow readability.
I don't like that you got rid of the try: label. How is that related
to locking.
regards,
dan carpenter
next prev parent reply other threads:[~2026-11-05 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261104222832.32471-1-laurian.iacob.ref@yahoo.com>
2026-11-04 22:28 ` Laurian Iacob
2026-11-05 7:14 ` Dan Carpenter [this message]
2026-11-05 7:52 ` Laurian Iacob
2026-11-05 8:15 ` [PATCH v2] media: staging/ipu7: use guard(mutex) in ipu7-buttress.c Laurian Iacob
2026-11-05 10:11 ` [PATCH] media: staging/ipu7: use guard(mutex) and simplify retry loop in buttress Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auwswLdxTSjA5BTL@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurian.iacob@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®