From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793882291; b=Eq0ndSWA6+6t737pWIrW1z5VgnDnWkxX7G7NXsv2JluPRXtZHHxwZGR/0caPOwkzvuGK a9t9Lsf8IIL57AnNp+IpIVfVtm95Kq3mRFrwGIIx5j+Vu3Terz7NxfdHQkiPsWFvaWFVv hQ1A2OXwtCcPnrQddoR7+DPsgn0jKyK+fHTGLAietv2vmVK9K1v9Kk4eZmU/g0t9Lk9ka 92HCKQM1hji0gZd4/TbWbmz8F29ohxlsCwOMAFfFFhVV7kphFgWjGUxLTM8T3fONYJsHw m5hnyPbt0DK63rT1dYUfsa7AtzyTc7/ZqEbOQKhcQQJRUiTyF9v25UsNDaV8F0SM1Bg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793882291; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=a10/FbOW/y79RbAy/XygKg3tgeEVwhAaxbtQwGYKBWY=; b=QMa5D8E8r34rIOOAfUTbgpOB8NsjBusuVJteXySnf1T02F5QpBvLHABg/tNZ8nPsB5Ws EPCoE4qyYL0Expxheys0n7ZGA7nCAdXAKAXf2IrqHRJ2HPK3Em4MXVRLcWOKzD+6CMjpB 7Bl7limmCz5iHMe/+4VG1ZqD37TqPiCTSfMQaR3JWOWYconXO5peUOGi1h6vv8cgIOcZG 9dW1uFTjNodWmKRN3ANZJgGp9aKBP2kge9rmXlWwn+LGdfMyA7QYCVAIgd3CBB9dpvWNS 9mX/pkMKu5opVzia73IOc/2FJ8C7NqCZEBJnPL3HpHpqNIBmDHSl2+JxqHCxK00U1uA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Pmq2QLNL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC08606A31B; Thu, 5 Nov 2026 12:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Pmq2QLNL Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C2E71F000C1; Thu, 5 Nov 2026 12:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793882290; bh=a10/FbOW/y79RbAy/XygKg3tgeEVwhAaxbtQwGYKBWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Pmq2QLNLeuRURVgjQY993DqQkbY+w/FjSomUkiVjZgUxdw1wmOqjZzMUnvb7bLQE6 NMuXI7aw3r/Ju7efwmdDRiS0FUIxqkWxnOhUVIVUs2sz78xqTElWbB20Pv3xqmhcIz DbX+e2I7zAQTd7/zUy03J0db2AMDrRFFe/B+uuNL2HFeLKWhEN0LkLaecH7kiEQyb0 NrGhCFhukbAI8IlJrCi7wtTh6x5gafZaVCX036BxFwtw50rD5pMZG7c7s/aNOEpP8c UWBlKyLdsS7ysn8tQIi2dolHfFuufhhgNMola+NwGT+eGv/KuuvvbSEOQg+TUd1yJt f/h7bc89umAhg== Date: Thu, 5 Nov 2026 13:38:08 +0100 From: Thierry Reding To: Frank.Li@oss.nxp.com Cc: Codrin Ciubotariu , Andi Shyti , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Dong Aisheng , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel , Mukesh Kumar Savaliya , Viken Dadhaniya , Wolfram Sang , Geert Uytterhoeven , Magnus Damm , Pierre-Yves MORDRET , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Laxman Dewangan , Dmitry Osipenko , Jonathan Hunter , "open list:MICROCHIP I2C DRIVER" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "open list:FREESCALE IMX LPI2C DRIVER" , "open list:QUALCOMM I2C QCOM GENI DRIVER" , "open list:RENESAS R-CAR I2C DRIVERS" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" , vkoul@kernel.org Subject: Re: [PATCH 1/1] i2c: use dmaengine_desc_set_callback() Message-ID: References: <20261102170004.3852546-1-Frank.Li@oss.nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4q2hqkiojuk23bqf" Content-Disposition: inline In-Reply-To: <20261102170004.3852546-1-Frank.Li@oss.nxp.com> --4q2hqkiojuk23bqf Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 1/1] i2c: use dmaengine_desc_set_callback() MIME-Version: 1.0 On Mon, Nov 02, 2026 at 12:00:02PM -0500, Frank.Li@oss.nxp.com wrote: > From: Frank Li >=20 > Replace open-coded assignments to callback and callback_param fields > of struct dma_async_tx_descriptor with calls to the > dmaengine_desc_set_callback() helper across various I2C bus drivers. >=20 > No functional change intended. Prepare make to struct "Prepare to make struct ..." perhaps? Also, I think it'd be good to reference the commit that added the new dmaengine_desc_set_callback() so people have more context for why you're changing this. It's not immediately clear why this is helpful: "more readable" is very subjective and the fact that you're not hiding the structure definition somewhat weakens the argument of consistency because people can still manually set the fields after this patch. Maybe the plan is to eventually hide the structure altogether... Still, seems like a worthwhile change to me and the patch looks correct, so: Reviewed-by: Thierry Reding --4q2hqkiojuk23bqf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmrseLAACgkQ3SOs138+ s6FZphAAmucdhUvBQmv3U/+6XP2+d6xkC9p6HsudKLrBBXNu0Y+JAC+l6uMYJUly psSWkmrEMSCs2ko5WioKs5lJYHFArBRxX9iaR/MyMJcUnsoWDyvGlV8raSECo80N yuWJLfEgV7mslOQhZql8vUB1EsciH8R6MXmF28yH7zor3JGO7FT53UFRW0MZQVyr 7JFffELL2xRwLz0urC1jgJqQ8hofGPReXE72BCNQMbs9SSycE0IvCHBDpC5dKO4W u3pqNzL8P6g4h1mO5JI55PG2lY81byjW3R4YpNL1LsaLD7I2mEc1RGVWEjTqGRA7 KpUAo3WDjGov6FD/mdctS4pIQCcKxOtmnpcTuJV5CUBw5DjsG+A9dgx02yWqYeIZ 3FDurUdKAsBC6+4oEeIoyp7f0eVjeZNk4OyQ0r+7pOq1IWGplMtt0QpOBzxDxeeX 776FiJaE7Lc5iQhzQwEV45MJ6Ja/DlW9zwqtWxXPEqndGDW+C1oF+1dOMcT4qUim EXDPmlwQms5nbeCt0MEl4SlbT7uHZCkmJrjxl8dYcL3TUeb7lfm3ro0wIyqpu+sk ltQYASJGNWWwe0rYjM6mOr0nQmPmVUms/BXsBSWeBej4z3IJ+RQCD0xcgpwLCHCL SEDM73L/0RDcbzrzWrZU32LDBkG+UeVNlrya7AdQEBpZFnbCbng= =9iU9 -----END PGP SIGNATURE----- --4q2hqkiojuk23bqf--