From: Dan Carpenter <error27@gmail.com>
To: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
Cc: outreachy@lists.linux.dev, parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: video: document lock fields
Date: Thu, 5 Nov 2026 15:48:42 +0300 [thread overview]
Message-ID: <aux7KmnRHloDL8dj@stanley.mountain> (raw)
In-Reply-To: <20261105101222.5478-1-husainsitamuwala21@gmail.com>
On Thu, Nov 05, 2026 at 10:12:22AM +0000, Hussain Sitamouwala wrote:
> Fix checkpatch.pl checks:
>
> CHECK: spinlock_t definition without comment
> CHECK: struct mutex definition without comment
>
> Add a comment to each lock in struct most_video_dev describing what it
> protects. No functional change.
>
> Signed-off-by: Hussain Sitamouwala <husainsitamuwala21@gmail.com>
> ---
> drivers/staging/most/video/video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 3a0445ff62f4..d60be8a741ed 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -33,14 +33,14 @@ struct most_video_dev {
> bool mute;
>
> struct list_head pending_mbos;
> - spinlock_t list_lock;
> + spinlock_t list_lock; /* protects pending_mbos */
What I want here is an audit of the locking. I imagine that the result
of the audit will be more than a two word summary.
regards,
dan carpenter
prev parent reply other threads:[~2026-11-05 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 10:12 Hussain Sitamouwala
2026-11-05 12:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aux7KmnRHloDL8dj@stanley.mountain \
--to=error27@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=husainsitamuwala21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®