From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793883730; b=Kr/LbC1GTA8bu4Myf+IAY6D5fxR+hPCyyiWfGk+ZwjwON1Xq7/GZEi391EDy/WhyIXUQ rKmTSN2d9tct/x4q2sAFFOdJrajsCRQwlyl/qUwfVIajcuIyHayFHdepIDIA6fezskkj9 sFsZVA0mzrnkdLuFQdizqpeSpg43MS5IIjXGDD9qt0Zjwhf/g4GnhVxYdk9iG4+GkGLRw 40RaO7NFg7ChbxyevPxdisNY4GUeQsAFCLYicG560WetLc3Cr4fPSAHXZrZK0QNAZBcWh v6lPBLwnZtLkaofUPVM5qiPjh9KAyhOYgGBwmaRTRS7QJwSr9V8VtSJ+ya8AitpjYJA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793883730; h=Received:DKIM-Signature:Received:Received:X-ME-Sender:X-ME-Received: X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=ODdbidwungoC4joZGqAWEdUpjvBaTXtHkaXe8rKCFAw=; b=ciIkh4c3+SgEBeNvNwreYoYxMtOipK3Dng9OswkPYViOxS4Fo+CB7jvUPbcy/ybFcyKD qg8kw5ckewKWMpqrfqFBpf/xaeqo1GiOI4cEncnIEhFCLpmb38q1bRIenO2LblV9Ag7Cd +KrVOo+b1utYb0XXGckWiqKSREPwDkrlpsjNcvGi5bKm9Ds7rze83ZFhos7b0OXDErSCn qG1DtSF0dp03hCdfFMTStXm6KFC4fcFu163bwg0mr3n/I98mfM/ALQSOtOFswkwDJl775 pDKsEzmhJ0fo2T+qlBqf5A8LHZ4CQqFn0RHa/RPZA332OfKEV1wyvTyn7PPIHVVrbcQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZQ0oCC+y; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C25E606A31B for ; Thu, 5 Nov 2026 13:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=ZQ0oCC+y Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A3FC1F00A17; Thu, 5 Nov 2026 13:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793883730; bh=ODdbidwungoC4joZGqAWEdUpjvBaTXtHkaXe8rKCFAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZQ0oCC+y9os0E1ZeMgu9e/N5WmpHjAOIrF4l3liGw27+gQmFuauUAu3QG/q9uDWTl 3TKp+AU0H1wWqayQPvKZM57PaRJibPQUloG2nqac2lBeRqb0UEPX1dYD8h01AEjzDz vNGUIdx63ttmmh3zf3eIMHbzwnndB5k9MDBk4e+uow5NCSLEIH1cFyXz74Gi45tgp/ Wa26Nd2c++AdKkgxRFXZAi6sa5GBBD2QE3KUoQkbJT7VI9iZhSrWybSuBgYbpQGlB8 g3JErI4ZReV8vX8nOC1ZbmltupQcjstxr5TXRSSVm0c83LP1wwssH4qoIu1I1Wfl3J sDALxcReIe8CA== Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfauth.ams.internal (Postfix) with ESMTP id 0F3EE198003A; Thu, 5 Nov 2026 08:02:04 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Thu, 05 Nov 2026 08:02:07 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGWioZ5UsUZvGXjaow1BsUGadLs8aZQdTF4UnV/07NAN/af8tN6pM/FfLXYfyZLfb xRpT19JopPsgAFGYsm8FzaqvOcRv05DtuUalhGCfVBg5TYHs9JXv+Q47gmOf937P2Gi3S+ U2sfvRv8HM/m1nYX6eGi2a4miDiVYyQMuuHiidk1Rop6z5ppK7guJf5jvUfTyMXleQeyL+ YFG9WYCksR8P+f/IoUx4Wo08VB8Mvto3/EHOpPBXbwb98JXOAs0bmRST4eO1cbxBPUkzyb YU+NZSxhcSt0KRFVrgpydwZFv0ufeT4P8d+qRyppjSLMzQpNREs19lQwYqTs8BowLu6Nt2 5Am7l6YekVqjY83nXhyttgWii20fB0sq0/gLxPQHon5CrRkTEqrIGD//hCWFKqOgzqGCvi aMcLQ7cAZew8NgHslTKKsAByAnDUby/6o7zf6t2iuxqMb/GVhW/urcyLO2AQ8SZ818X9mS KvrqoB35qasVInQXx9O0IC9DWqxqX0BoD/o9yiGn5oqOKYTbGXBdOAIO4z+H9UZl5AQPCz X5k1DEL86ay2iE++MFKAY52MrLVWAVVhibUP0tLtOKiw/bidGrXPVW2Da/VrEL1xMbaVji gk/Rfm6DtM/to8/mnKjVPcrauVt2Z5IcYYLnNu1hKr6ktYnVJlpVoH4xcT1Q X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Nov 2026 08:02:04 -0500 (EST) Date: Thu, 5 Nov 2026 13:02:02 +0000 From: Kiryl Shutsemau To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Qi Zheng , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/khugepaged: free unused page table when setting a huge PMD fails Message-ID: References: <20261105-khugepaged_set_pmd-v1-1-cb79ab117199@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105-khugepaged_set_pmd-v1-1-cb79ab117199@kernel.org> On Thu, Nov 05, 2026 at 01:16:05PM +0100, David Hildenbrand (Arm) wrote: > do_set_pmd() can allocate vmf.prealloc_pte on architectures that need a > deposited page table, such as PowerPC with the hash MMU. If the PMD is > no longer empty when it takes the PMD lock, it returns VM_FAULT_FALLBACK > without consuming that table. > > Since collapse_pte_mapped_thp() uses mmap_read_lock(), a concurrent > userfaultfd operation can install a PTE table before taking the folio > lock. If that races with set_huge_pmd(), the unused preallocated table > is lost when its local vm_fault goes out of scope. > > Free vmf.prealloc_pte on failure, as do_fault() already does. Successful > PMD installation consumes the table and clears the pointer. > > Having to do this cleanup outside of do_set_pmd() is rather nasty, but > other callers depend on it already having been allocated. This needs a > cleanup at some point. I hate this being outside of do_set_pmd(). What about making do_set_pmd() freeing ->prealloc_pte if it was allocated inside? Nothing changes for caller. bool allocated = false; ... if (arch_needs_pgtable_deposit() && !vmf->prealloc_pte) { vmf->prealloc_pte = pte_alloc_one(vma->vm_mm); if (!vmf->prealloc_pte) return VM_FAULT_OOM; allocated = true; } ... out: spin_unlock(vmf->ptl); if (ret && allocated) { pte_free(vma->vm_mm, vmf->prealloc_pte); vmf->prealloc_pte = NULL; } return ret; -- Kiryl Shutsemau / Kirill A. Shutemov