From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793869590; b=em4e3XoFF0Ep1J+78rPMu7fbmnOr4rfyym8oZX7KqcpYiOPidwcDhyos6I+mmQM1x93P C4pgXPQPa6rxYzy9DbcAUs+GrR6azKfCDeunl9bas/juxuyML1evT1h8nYqu1kqtDL9wa L53Ap3+E8onH1x2W9AMxl2PgTLgiRt2e3DphhElmuJp+Sf6kiznAQa3s0LMifwbePeh6t jC2A0eUe3jd7grn0cfgSvMjlYmoB2+afZBCAfIfY2qPA9vpeOTEq3HQbycx1hKABMKT1F 1EKcl0GdcP4Bgi0TzK76IkkZ31+n6EtzH0tjR7rrzgm0ohEOxINJNDHalxMARE3kG9A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793869590; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=sXaBx9Aij9/vZ7m2OstPYoIGvXFxlj8rEgSuIQIdBWQ=; b=AF7H2qIgOFjGcCv7pdWHd1/noRappkrQL2LYMRWPyKXa3EFavZTV70D0jgxXSbjJMffW 1zSKxDsXDwNqGeNqmMeG/4WwhTJxK+VANPmbf9Lzdxx+8tfwoqu380mV4bAQXhGPsVZTt 5qZ0ECU5o87dQs39bu7uT6IBBJbXRj80PfRTciTswVl21V38cEuvGx9h7Dju6gQW4lQI3 hPixtu++1UXlZOwtANMaUjj/TMI9iygQjBrGoMAZzr3kpt9KolIwui+9V2pjmuXjPVkr8 AVEnhV/wD5FT3gjHTGaxp6ZyDiSm1SYlp5eVLODcSOXPqX7qwUBMqkiD7sAGTCp2RJg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MCaXKPc9; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=LDFA7cp5; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD96606A32F for ; Thu, 5 Nov 2026 09:06:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5FD96606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MCaXKPc9; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=LDFA7cp5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793869589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sXaBx9Aij9/vZ7m2OstPYoIGvXFxlj8rEgSuIQIdBWQ=; b=MCaXKPc9aN0fAL8Vmah/490+jJGBSEw/qnPWHrn7yvGkqJkaepA6knzlUsynRNk24BEAoj XxsmAme8afGsvwlvkgN1KhptCbcaq6ZYwkHxAx7Q1I1ZuSMjUK3hzzmLdfFcKt5feIXole 0j7czpxW+58iyv6+raNmxNifNlYvYGo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-1KBP1R9lMduy7JtHPmbHGA-1; Thu, 05 Nov 2026 04:06:28 -0500 X-MC-Unique: 1KBP1R9lMduy7JtHPmbHGA-1 X-Mimecast-MFC-AGG-ID: 1KBP1R9lMduy7JtHPmbHGA_1793869587 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4903fc8537aso1031245f8f.0 for ; Thu, 05 Nov 2026 01:06:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1793869587; x=1794474387; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sXaBx9Aij9/vZ7m2OstPYoIGvXFxlj8rEgSuIQIdBWQ=; b=LDFA7cp5xhvjg7esDfWeYiNPdPFyqkYUvXry59Mm9WlFfl7VkUeXOFn7Vo5z3TfqT6 G/hfh/eKSBuLCqc79qnntLKBCFb+UbjRgzSTbat7W/t46ybQqwKa6eTBfEURVzAxK0TX B4IfEA3H1Oow5E0RIJPO/Ctz1TX+bcNPnEl2HHLt6KlwhgomJ+WAZX9x4+oEgXQGvFgb pqaH42JDWV4CsyTJdisLYO/uTnu6NRkR/YGYiF1J9geI4E/hw4BZIGoXazQkn/lGtdW4 IMYY616y4Iit0lfyEHn2Hk+82bQ/p0+epvcwgiLJMjXwl3SmRCxiZNyMW/GCZbRIAcP0 HCLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793869587; x=1794474387; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sXaBx9Aij9/vZ7m2OstPYoIGvXFxlj8rEgSuIQIdBWQ=; b=tYGxNc1p4/Om7kp51aF7EjSAI8X0ms/O2T+ov46mycZe4R8WzAzxWPC4NIcLnOUPYk Dk8l2qAHsOeTLHgESsgZBllPClIo9HRIxS651HJ6Oiquf/cDHhZDE5W7/ApaKCt6iLBG 1DBjFDqEX+VsXzkfBDSi26pLdSbP+gOc/u+LgW1JIWsTBvM9GPnn9YtNw0MJkdUjGHnM rlKM0o3NICiaGl0fB9necQJproOG5m4+BCkIAUyGKuWwQ2voS5VpfvPdA2HgOOG+2CBr ewYYzIbDaOrijqIDR5bVbSwdDGDKFGGER4BrsTPCWQHeZVa/7PWgmdwq8cPvY4D4qbAh hWBQ== X-Forwarded-Encrypted: i=1; AKwUvBymVyLl72zZkxPzv5Wb7YCbucQkK7I+jXv9cP9ryKMag6ujv4xONZaEs8Jm74aGqXEDYBOFsP9OsZS2X0k=@vger.kernel.org X-Gm-Message-State: APuU4Z/iAEZ1mv8xFPFupUYSLniCDa5myrWL20HsdhgRxcbm4DoAbBLY qD8W+LdTh3R8JqLM+DObe8wVyGynVyKMd5FpEIbrADHfkS3L6N69czCfZ8GHDOxFrj3sXpNg6ro xeBXVbk8biJIgh1xiQ3hwFV0zHyZcMQKXuwIrTmzDW0mcLxsdnqp9KzLIvlHCyVElQQ== X-Gm-Gg: AYBFou0rs3A/Ftql9J7BHWz4m5XVaC1eIbhZpCccXSJhlKnviyNfvR35WIB12Q9m+rh QakKScMzeIEbOVZ6V+Br357h7BP94Nu/HnomzxEBC7y4ysX0WPbpwqWWYogteZb8J+Oqn7ik2F8 +yuAOdAzVzmR+Y2KijrddZL7xHVWyHp6GmdxE1o8AWogihYdh6uTqnQ6pNNuBcUIwVLDZcZuzwr aH9fr9N33HQj0495l/8sZGqBaUn9oZIXtCWlovq+VRbEs23eH/1LybD0QZDCoul2HA50RZPvFHb l4bQz7wlt0iTSJyIX0kpMyp7LIrWB+eh0F/Yh2QDFVU10fzNVwfQ6xtBxQLaPCzB3dKAgQuCr5n jJTpMDadiaXXqHP2+JcTKAjVsy4XIZoG7aQX1PA43ti1p+PmFryg4 X-Received: by 2002:a05:600c:4ece:b0:4a2:40:8d2c with SMTP id 5b1f17b1804b1-4ac17b2c396mr392373215e9.26.1793869586712; Thu, 05 Nov 2026 01:06:26 -0800 (PST) X-Received: by 2002:a05:600c:4ece:b0:4a2:40:8d2c with SMTP id 5b1f17b1804b1-4ac17b2c396mr392372195e9.26.1793869585957; Thu, 05 Nov 2026 01:06:25 -0800 (PST) Received: from sgarzare-redhat ([80.116.143.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b571f46489sm49581765e9.3.2026.11.05.01.06.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2026 01:06:25 -0800 (PST) Date: Thu, 5 Nov 2026 10:06:23 +0100 From: Stefano Garzarella To: Jia Jia Cc: netdev@vger.kernel.org, stefanha@redhat.com, bobbyeshleman@gmail.com, mst@redhat.com, jasowangio@gmail.com, eperezma@redhat.com, xuanzhuo@linux.alibaba.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 2/5] vsock/virtio: factor RX skb metadata budget check Message-ID: References: <20261103041134.33310-1-physicalmtea@gmail.com> <20261103041134.33310-3-physicalmtea@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20261103041134.33310-3-physicalmtea@gmail.com> On Tue, Nov 03, 2026 at 12:11:31PM +0800, Jia Jia wrote: >Extract the skb metadata budget check from virtio_transport_inc_rx_pkt() >into virtio_transport_rx_buf_full(). > >The helper retains the existing condition and will be reused by a >following RX batching change. > >Signed-off-by: Jia Jia >--- > net/vmw_vsock/virtio_transport_common.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > >diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c >index 43325d7aebbb1..2a9cfed085515 100644 >--- a/net/vmw_vsock/virtio_transport_common.c >+++ b/net/vmw_vsock/virtio_transport_common.c >@@ -576,11 +576,17 @@ virtio_transport_collapse_rx_queue(struct virtio_vsock_sock *vvs, > skb_queue_splice(&new_queue, &vvs->rx_queue); > } > >-static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs, >- u32 len) >+static bool >+virtio_transport_rx_buf_full(struct virtio_vsock_sock *vvs) > { > u64 skb_overhead = (skb_queue_len(&vvs->rx_queue) + 1) * SKB_TRUESIZE(0); > >+ return skb_overhead > vvs->buf_alloc; >+} As I pointed out in patch 3, I'm not sure we need this. After we introduced the collapse, SOCK_STREAM should collapse rx_queue before hitting this, so not sure we really need this function. Thanks, Stefano >+ >+static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs, >+ u32 len) >+{ > /* Allow at most buf_alloc * 2 total budget (payload + overhead), > * similar to how SO_RCVBUF is doubled to reserve space for sk_buff > * metadata. Check payload against buf_alloc to be sure the other >@@ -588,7 +594,7 @@ static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs, > * queue growth. > */ > if ((u64)vvs->buf_used + len > vvs->buf_alloc || >- skb_overhead > vvs->buf_alloc) >+ virtio_transport_rx_buf_full(vvs)) > return false; > > vvs->rx_bytes += len; >-- >2.53.0 >