From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.15 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793869445; b=yX0dGwPPoMauWkrBB2N7gP5nzM3ufQRS6Lc8H+J7/kiv0Op2+iKuufsPmsASfZA32MOk lBkwx9eUGTm2dRxBQFSbdMf12F78SvswQiiIFzZUFln7uxBLNY8E9ckNvo3q2ovoy0CEV lZstx5SnXZHBtTO84qp/weWUEVUMU+g3eNYd+xn/1bcnXCHVxYFsB0xH8TcdWUwGPzjm2 6SXdbAe1paG8wyAFM6BjBTrKggXyXrB/lNmGM3ZSdZCIRqug+7GRSHKw2CWybhBaP52BR SBBUh0zMDXKsWklZWt8m11tHJx9nfBccaux6Obq8zpt3eJ0ZGvRfjwn44N/k4VExO4Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793869445; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=NTpZSYuqCJ8aVO/byr8U2ibpc76743xlphGgFkLrMEk=; b=EYPHaEoPTrYSPkRyypv0Z6K5hOzyWA7GA33RjrpmNQv10g/bLBnulf6J6cPiFFEZuS2U S3qJ1dakqKMKz7lPOp+9sy6AuB65LLGuKbKtNP6RbNeAGBfzvxlOn0I4dhx760sbM6J0I ocr097C3E3JSw95d/Sh3A1fYKAXj+OGRtV695fFDmEEgvWVtLoIDo/cMuRt41oheZ29Pc woVF/MmmPC78cUVJKhmc+kbQh1YGGt/lgdfwFDyZlb8ar6Y7W7bjcKlBWsKiFLG5XBKLC Ank4LHg9BcXSD5pMNIf7PRI0ssU0wrydHJqrORyVQ/xxQpe3yfyULfZtrQW0Z7lZpQQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cR8BGVKd; arc=none smtp.remote-ip=192.198.163.15 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 184A6606A31B; Thu, 5 Nov 2026 09:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 184A6606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=cR8BGVKd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793869445; x=1825405445; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=e5Tih3iECPzUwOzRgFBLbWPwtT2A2aI6VTXhUtB9sIw=; b=cR8BGVKdHLgNpAYi9bmUES7Im6zpiQO1bedq5eNcGT7l7smkWYvU3gii TWWEnDsOMkJsqswwrEiZnOn0MlzdL0NQHw1O9XYICS75ZPy2drO2UDlzw 4A+t0xWGKJTGNoVFY06kow5ZP2iqiZrLd07o0Z1uazv1HuC8T775TGGNw vD4TbwWAjVJCPRFsayMdBzX0ZEg7WsbiTcf2+8gIlJXpSjT33q4ro8KOY ZYkP8MEtI4IlBoN0R7Fm91DDHLcksXdYLB2ePWRzj3aV2iOWUjTEuPbZj Da6XIW/noLcEDOYFL9bEgJgiYgELDKpxHhXR4pFvST0MXY5vGLrN+HCZd w==; X-CSE-ConnectionGUID: XTh2eTpVRwO7ALaXDtQDwg== X-CSE-MsgGUID: lj9/sOBZSn+JzZMy1GzN0Q== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2642988" X-IronPort-AV: E=Sophos;i="6.27,196,1787036400"; d="scan'208";a="2642988" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 01:04:04 -0800 X-CSE-ConnectionGUID: Yp/KC++fSmu4/jDprqD36g== X-CSE-MsgGUID: M7NuvQevTYKghPgW2RQ7fQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,196,1787036400"; d="scan'208";a="7366179" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 01:03:51 -0800 Date: Thu, 5 Nov 2026 11:03:49 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski , Konstantin Ryabitsev , Jonathan Corbet Cc: Frank.Li@oss.nxp.com, Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Heiko Stuebner , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Mukesh Kumar Savaliya , Wolfram Sang , Thierry Reding Subject: Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback() Message-ID: References: <20261104152253.3279052-1-Frank.Li@oss.nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 11:01:55AM +0200, Andy Shevchenko wrote: > On Thu, Nov 05, 2026 at 12:02:21AM +0100, Krzysztof Kozlowski wrote: > > On 04/11/2026 21:44, Andy Shevchenko wrote: > > >> Andy, > > >> These three lines look correct. > > >> > > >> LGTM: > > >> > > >> Reviewed-by: Krzysztof Kozlowski > > > > > > As > > > > > > Reviewed-by: Krzysztof Kozlowski # atmel-quadspi > > > > > > Note, it's in your power to ask the author to split out what you maintain > > > to a separate change. So, it's your choice what to do, Ack the full patch, > > > give a partial Rb, ask for a split, ignore reviewing (often means silent > > > agreement when maintainer just applies that kind of a patch) > > > > The "# note" after the tag solves the problem partially, if people were > > actually using it. Solves people looking at the Git commit and being > > mislead by partial review applying to entire commit. Does not solve > > credits, because Rb for three lines is not the same as for 100. > > > > From v1 of this patch, four people (Alain, Lab, Troy, Kunihiko) did not > > use it even though reviewing only part. Only Wolfram, so 20% of partial > > reviews, used that syntax. Without that syntax, b4 will pick up Rb tag > > like it was for entire commit. > > > > So I do repeat - if one does not want to use that syntax, then just Ack, > > instead of creating false impression of reviewing everything. > > +Konstantin, then we need to teach `b4` not to break that or convert it to > something like > > [FirstName: reviewed only ...] > Reviewed-by: FirstName LastName <...> And Ack is not the same as Rb, when I *reviewed* patch, I have *reviewed* it, even if it was partial one. Also Jon Corbet might share his opinion from documentation point of view. -- With Best Regards, Andy Shevchenko