From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793869660; b=eLKNWI3PQn/Jewyb6BUdI0sqzbmNwUQuOmjKsrDFquntDYO7uWqcS0Rgq7d9Rozb+dne IwJZC2OBznZGB+e62SJfBkRvmj1k61nOXJKPD3oACwu2KRPDXQV9Kbbu+fMKadsicSbuz oThaVttBKQd6BiVD+NN3ScGw2582ssmlCsDuRw45UkZmQxj7BnN1bzCLtRXOsGf+eCKZx 2uLLQ4OWxfZEt1vjp2fol6DOWhSEqxH89N4p4TsY7Wdv+4v2p78YwpulFmho/AZJdY7Wp sfEhyVbQ1GdRBlqAoa2MTGPTGlXIORsEGjRl3n4xmTbx7rg6SOyIKkSqhIEhER4y2CQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793869660; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=n2xCmog64AGKMXZW1kunHj4ya5Tb7T8D0cVzpzhIyow=; b=eBDnBe65nIL/RRqlUytWbO39D4rfKURIzhKqq/waQyLOH1A0qHPLZPOdhodeANenxm5m lyWEkuQyiDohG99X1Q66LDbPpHCn8tvmE4vIn2a/AfDlgYxnSm27FmMh0cz0ZbZkUPoii +fE0s/sUHjTt1XUAzpk3gJUNlUONSisnwwk0+3BrGsuIeaXFd0uoV0lOuqhPq0wZyeSGO /jtkaUw8/lybGNqt4GcV1nbkLS01Ragw9ZNlZzj8SbATzc1W0OIyY3+wtWk0iKimEzpGi 2tv9tT5p8pAPY6kDEzJXAbOLSfHyRx2K1XjJAngn8aE/oDK27OEAnIdDCInfv8hEc7w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Dcd4l0yI; arc=none smtp.remote-ip=198.175.65.11 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C497D606A31B; Thu, 5 Nov 2026 09:07:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C497D606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Dcd4l0yI DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793869660; x=1825405660; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YJohrnn0X6YdnhzwUjJAKaTWxHJk2t2HvqKiuYmlRe0=; b=Dcd4l0yIwvkWk4UlAwrOKlv4yacne6B9U8oK4AenNg768gAyTg96uKmX 5MX8m9xiQmmm69RRIv9RzPQBBanQIZBO9geEhuRSADMYap2otnqjaqwCw MZ26yJgbKcoDH5Oo8V/qN4k3sQvlZZK92pyijhtVkecuHqBTNF1JI+zRF TiwjIQbet1SVzbYsXluHAgpBJPYv0R2mXxiw0VtWF6Fw7cVkaN+Cx3PON sHCriyAdM72ECQADjzWu/F6Tt869HCoi1lHNfAWKnNK+hCs6g3lgRdJ9Q UDFn2S03VWD6hneoJ850fDzpfwT6b4crQBJ5PwoAyeFoWQVsKe37Pz1LA Q==; X-CSE-ConnectionGUID: ho/RIa7qRtubM0r7f4mKRQ== X-CSE-MsgGUID: /Jslj6NlR8mPVdgVkF3Chg== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2533361" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2533361" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 01:07:40 -0800 X-CSE-ConnectionGUID: LhD/33EfRn6nz2oc2cFwKA== X-CSE-MsgGUID: Sg2CeagcTPu0Gp5Gx8AUbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,196,1787036400"; d="scan'208";a="7514404" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 01:07:37 -0800 Date: Thu, 5 Nov 2026 11:07:34 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Frank Li , John Ogness , "Mike Rapoport (Microsoft)" , Zhaoyang Yu <2426767509@qq.com>, Haoxiang Li , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , imx@lists.linux.dev Subject: Re: [PATCH v2 1/2] tty: serial: pch_uart: replace chan->device->dev with dmaengine_get_provider_device() Message-ID: References: <20261104145211.3209669-1-Frank.Li@oss.nxp.com> <3b390b39-c27b-4b62-aa49-5b1bb56c3cfb@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b390b39-c27b-4b62-aa49-5b1bb56c3cfb@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 12:04:25AM +0100, Krzysztof Kozlowski wrote: > On 04/11/2026 21:49, Andy Shevchenko wrote: > > On Wed, Nov 04, 2026 at 09:52:06AM -0500, Frank.Li@oss.nxp.com wrote: > >> > >> Use the dmaengine_get_provider_device() API instead of directly > >> accessing chan->device->dev to get the DMA provider device. > >> > >> No functional change. Prepare make to struct dma_device private to the DMA > >> engine. > > > > Krzysztof, this patch was a split from the bundle by a reviewer request (not me > > FWIW), and author obeyed. So, you can do the same in cases when you got something > > you want to review independently on other content which most likely is a noise > > (to you). > > Do you propose that I read all patches and complain that partial reviews > should be split? How does this proposal solve my complain that: > 1. Incomplete/partial reviews will be marked as full review of the commit. You mean the problem of tooling? Why is it problem of the tag? > 2. People get same credit even if they intentionally did not read 95% of > the patch as the people who read 100% of the patch. This doesn't stand the same case when patch is split. I will give a Rb for the full (but isolated) patch in comparison the same code being reviewed in the big bundle. From my perspective (as a reviewer) I have done almost the same work. So it's an equivalent. -- With Best Regards, Andy Shevchenko