From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.11 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793871272; b=jDO0mXDjoQib1sMgBPfHH9KoQkEH3ooedTxioSG9X3aNrrkk6+tr2HpXTFdB5LyUI+GX DBe6ALQ4CtAXfQRhSiJIvj9QP9iEfaZonWbZ8aNNSNCQS2fbj5utvv5kklLaFUfIOEDKr CDsX9f2lYqCDhjKRbnWUVjJEnO0HszYSgnOHEiErHhb3vjvcchbGV3GK01yYahiQ03qct niFPvAmFXPLxQmMFtY78aJfHIwKX3XcuUJMhPt79PWLKWgQJVERASUZ9fR2FhbnOMBdE/ SjYQhOHRIZcIs7GI+zPjDn/JIZ1k0A80PKYo25f6HLu5PhEA2QQRkc5A6cktntaceig== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793871272; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=FHZJ9UZXx1w1S9lh8ts36Xc7WZ/XCgLmeoJLBVEnO0Q=; b=Yk5dRevc1JvbY1u6ictg0TvvBH9X91dC7PSBv44naPgjYKdhSVBTomwg0YWfOU5npOVS P97naAe6AvzStke+hvgRoxwfJmsowF1tblQUY7OL8LXw+PsknEq5SInpwkbQdzARqYp/7 F+gB6v3DVRLzcFS+J0BNqAwm1j9bFAjFhCqKNqpnZw4wE4djTy2m03k5y4yLRa9DkAUpQ 3XT9FwAerCrd3FwbrO4bAPT6TTxyTlysSEX16zhIcVE7TiIKAw40SZ/piWKO/JCyTgtRw HMl4yxK47NwzXqZgXPv72OmyueEvF965+1jOI29WhxPHq8ACfAi+m/k1H8CHSzBzVVQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b="G/LAUnN7"; arc=none smtp.remote-ip=192.198.163.11 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09AE606A329; Thu, 5 Nov 2026 09:34:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org F09AE606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=G/LAUnN7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793871272; x=1825407272; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4LUR2vLgdtbMkV4yJV6wiaAwpAfjeOibn9D0PFxVDWA=; b=G/LAUnN7uJFb4Hw9zdpTNgm87wYSbL4U1h5+3oEgVEfVl87F4KgFyKsq cbcIlGJ41lQyowDIbdu1ddXwRZOJ59miMMGXZ9i42vc13wP6Yuw9Izjhh lgkkSQFrOGnSRW555FjJ0qaXBuzJPtwVAqIH/c6CceDC5FdyBK3yoIKRU 6IMLdKShGWpQYIZeh+Nl5Swx/WIewH9PnJFklFHRHjOqabEyX7QeIn8bV gfMIHGFgAEwm2K3gpqJVO2JPZOKYIaDTrWM1hbTKJQ9qeNqVQNaOVTn/R pIRExOWdBFa87Yxo6U1pQWI8BhI7znuZGU+w/7LqMuHvLDajmyeMhc6BN Q==; X-CSE-ConnectionGUID: f62k/7XOQJmedKqJWrv5Vg== X-CSE-MsgGUID: wn0gviFXQFeo+rCPwiwgKg== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2558357" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2558357" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 01:34:30 -0800 X-CSE-ConnectionGUID: nlTZtjm4QSWKV5TFLHXZjw== X-CSE-MsgGUID: 6+CUyE26TrGO0R2loVaiPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="6795038" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 01:34:19 -0800 Date: Thu, 5 Nov 2026 11:34:16 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Frank.Li@oss.nxp.com, Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Heiko Stuebner , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Mukesh Kumar Savaliya , Wolfram Sang , Thierry Reding Subject: Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback() Message-ID: References: <20261104152253.3279052-1-Frank.Li@oss.nxp.com> <7f96599b-681d-4963-bdda-1274371ac84f@kernel.org> <9e39502a-dd17-4fa2-98a3-9019523cb5e8@kernel.org> <63c24437-4261-4a51-be7e-31ac0759a095@kernel.org> <00390a20-7630-4066-9779-06c8f915a176@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00390a20-7630-4066-9779-06c8f915a176@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 10:07:30AM +0100, Krzysztof Kozlowski wrote: > On 05/11/2026 10:04, Andy Shevchenko wrote: > > On Wed, Nov 04, 2026 at 11:54:56PM +0100, Krzysztof Kozlowski wrote: > >> On 04/11/2026 21:41, Andy Shevchenko wrote: > >>>> > >>>> But sure, if we want to play such numbers game, I will be sending > >>>> reviews for single lines. > >>> > >>> I'm not playing anything. The problem is that the patch unites the files that > >>> have distinct maintainers and unrelated to each other code. That's why in the > >>> subsystems I maintain, I almost always require to split on per-driver basis. > >>> Yes, exceptions are possible, but has to be quite rare. > >> > >> That's independent problem. Patch could be split, but it was not. Since > >> it was not, receiving end should act accordingly, e.g. when performing > >> incomplete review of only part of the patch, do not call that entire > >> patch was reviewed by giving the Rb tag, but give Ack tag. > > > > No, (partial) Rb != Ack. > > It is, because there is no partial Rb tag. > > There is partial review, but not partial Rb tag, please see exactly > submitting patches. It repeats the same in three separate places: > > "Acked-by.... user may not have carried out a technical review of the > patch,yet they may be satisfied ..." > > "Reviewed-by:, instead, indicates that the patch has been reviewed and > found acceptable according to the Reviewer's Statement:" > > Above important: "THE PATCH" > > It is not "the patch or its parts" > > Further: > > "I state that: > (a) I have carried out a technical review of *this* patch to evaluate > its appropriateness and readiness for inclusion into the mainline kernel." > > And further: > > "A Reviewed-by tag is a statement of opinion that *the patch* is an" > > In three places it is THIS or THE patch. Complete (exhaustive) list of > options what can be reviewed to get the credit and give statement of > oversight. > > Statement of oversight DOES NOT include "part of the patch". So, it means I MUST from now on REQUIRE a split before reviewing. Right? -- With Best Regards, Andy Shevchenko