From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, apais@microsoft.com,
rlmenge@gmail.com, hargar@linux.microsoft.com,
Jarred White <jarredwhite@microsoft.com>,
Jeff Kirsher <jeff.kirsher@microsoft.com>
Subject: Re: [PATCH v1 1/1] i2c: designware: Add ACPI ID MSFT0006 for Microsoft Cobalt SoCs
Date: Thu, 5 Nov 2026 12:03:32 +0200 [thread overview]
Message-ID: <auxUdHvRhWWO5ezO@ashevche-desk.local> (raw)
In-Reply-To: <20261104234928.86458-1-sidchintamaneni@gmail.com>
On Wed, Nov 04, 2026 at 11:49:28PM +0000, Siddharth Chintamaneni wrote:
> Add the MSFT0006 ACPI ID for the DesignWare I2C controller integrated
> on Microsoft Cobalt SoCs, along with its 300 MHz input clock description
> in acpi_apd.c.
>
> Without an explicit MSFT0006 entry, ACPI device matching falls back to
> its _CID (APMC0D0F), which configures a 100 MHz input clock instead of
> the controller's actual 300 MHz clock.
> Cc: Jarred White <jarredwhite@microsoft.com>
> Cc: Jeff Kirsher <jeff.kirsher@microsoft.com>
Move Cc list after the '---' line below. It will reduce the noise in the commit
message and hence Git history.
> Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
> ---
Cc list goes here...
> drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> 2 files changed, 7 insertions(+)
Code wise LGTM, I assume MS allocated that HID for the specific device and
we will not see collisions in the future.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-05 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 23:49 Siddharth Chintamaneni
2026-11-05 10:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auxUdHvRhWWO5ezO@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=apais@microsoft.com \
--cc=hargar@linux.microsoft.com \
--cc=jarredwhite@microsoft.com \
--cc=jeff.kirsher@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rlmenge@gmail.com \
--cc=sidchintamaneni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®