From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793875087; b=ZJDq1HRefb8fV0S07iyL2n098fUnCBqagm0nMshFub3zMae5kvgXQ4htzQMauGKQ2wAt WoWhowP4GMv4Ur0/GkaRmxL49qLq7RFTAbXEZS76pMseUrXQ8a29lRodiLiqIKegFA6Hb wr7triD3vlZCMG/U4DBTytsnmztThK4u0al6Rsap1Om2ED48Yi6SDoHuT/0OXmbPkShox ZDSDwK6qrNqO4sDp/+KsWrDZpjZjgdtHswIOS7bqyiDwX9qlmfcMXcfTirNDQzObDW3FT Y99z7gu4JVV9TcNzh8E1xvZ/lIz8u7WmrxIixYIlWCPzLbdeXNKg2DMeSVfuuWTWrZw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793875087; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:In-Reply-To: Organization; bh=Kb0CzJzsHsZ+UWHQAp2uA/S+bpBIx9myNk0nvO3EvbQ=; b=SiziMTp/xXZFAqLWyYjoKVeKiLPBcOc1RgBmDqxqUJMmt+wFXQ4ENiFUc8xV2AA5p/hV 5ZbuqVeHlNM+Fz9p2f89OvJ3QyNXxsdPhyjLUKyEYZQNhkCb2mWrsFYblx+DNJBTkBtwv aGUVK3LeScZ1gQGgB9KuTmO+4cb2M6kuvua9zp5kxJQ+RgvoV/wP4m0YC+M/OIT0P8LEa /EEUSqS5fCImEtjObR+0eg/7sLOPDFxTNJbs2GC1tweqcnzjPgsYiSGQ229YWvrxhDsbc qeA/1zwJ5CyyzACFK4XsunPvvfTfqJcXjZYZOStgNibJ9OENk/KLygvVG2OoNnDOvxw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=A4rKjlRB; arc=none smtp.remote-ip=192.198.163.12 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77B4606A326; Thu, 5 Nov 2026 10:38:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D77B4606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=A4rKjlRB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793875087; x=1825411087; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=eqO4A+ClsqjEqfXPQ0TFlIOZ+1UsCC9oIYRbbnK4e7s=; b=A4rKjlRBVFVKIEQC4EavgCR17/xSyjTrOEB2Tb84HNkL6B9y4XJRT1QM iUwkaAxPJL3QUyzkBOA2luwvYVxfQEtYxAZEW+GgljOK2viemRDECySII WP7y3aEe+2a85svsfCglP2dbIrcCrEpO3+UJsHfe9yqiygMRa6YlwWPEW SH/E8Be2sTsitocPTdbj6RjtMQXjuD7nznitbEIfRXlPNJPABOF93RqS8 OPhcFvq5cMM3UjilmzE5ltY/OlPLJqNBytdS6Dli+9Pk356d8cgqYZwW5 whsC1IhkOREAn7phf37f1DlJwQbvCLs1O+8Yiwt+HbJIKiDSNPAN1i8lB g==; X-CSE-ConnectionGUID: B8xcpbARSGSwQZmhBQ2uSA== X-CSE-MsgGUID: WkGLZSL4SyOFx13P6djZZw== X-IronPort-AV: E=McAfee;i="6800,10657,11956"; a="2560338" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2560338" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 02:38:06 -0800 X-CSE-ConnectionGUID: xIegnpX+Sr+k5gjNuD4pbQ== X-CSE-MsgGUID: Wcy7neyfQa2lUKLW6Cyinw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="7281977" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 02:37:54 -0800 Date: Thu, 5 Nov 2026 12:37:51 +0200 From: Andy Shevchenko To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Frank.Li@oss.nxp.com, vkoul@kernel.org Subject: Re: [PATCH 1/1] spi: use dmaengine_desc_set_callback() Message-ID: References: <20261102174005.3933649-1-Frank.Li@oss.nxp.com> <2154003.0S5aU1g85B@diego> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2154003.0S5aU1g85B@diego> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 10:52:38AM +0100, Heiko Stübner wrote: > Am Montag, 2. November 2026, 18:39:58 Mitteleuropäische Normalzeit schrieb Frank.Li@oss.nxp.com: > > > > Replace open-coded assignments to callback and callback_param fields > > of struct dma_async_tx_descriptor with calls to the > > dmaengine_desc_set_callback() helper across SPI bus drivers. > > > > No functional change intended. Prepare make to struct > > dma_async_tx_descriptor private to the DMA engine. [...] > > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > > index 1a81fd94b4396..f8d6cea2f3dad 100644 > > --- a/drivers/spi/spi-rockchip.c > > +++ b/drivers/spi/spi-rockchip.c > > @@ -475,8 +475,7 @@ static int rockchip_spi_prepare_dma(struct rockchip_spi *rs, > > if (!rxdesc) > > return -EINVAL; > > > > - rxdesc->callback = rockchip_spi_dma_rxcb; > > - rxdesc->callback_param = ctlr; > > + dmaengine_desc_set_callback(rxdesc, rockchip_spi_dma_rxcb, NULL, ctlr); > > } > > > > txdesc = NULL; > > @@ -500,8 +499,7 @@ static int rockchip_spi_prepare_dma(struct rockchip_spi *rs, > > return -EINVAL; > > } > > > > - txdesc->callback = rockchip_spi_dma_txcb; > > - txdesc->callback_param = ctlr; > > + dmaengine_desc_set_callback(txdesc, rockchip_spi_dma_txcb, NULL, ctlr); > > } > > > > /* rx must be started before tx due to spi instinct */ > > Reviewed-by: Heiko Stuebner Please, use "# subpart(s)" syntax with this tag Reviewed-by: Heiko Stuebner # rockchip -- With Best Regards, Andy Shevchenko