mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
Cc: jic23@kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Dragos Bogdan" <dragos.bogdan@analog.com>,
	linux@analog.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7405: Add support for ADuM7801/7802/7811/7812
Date: Thu, 5 Nov 2026 14:16:17 +0200	[thread overview]
Message-ID: <auxzkfpzV2Zr9QSo@ashevche-desk.local> (raw)
In-Reply-To: <20261105093531.7562-3-pop.ioan-daniel@analog.com>

On Thu, Nov 05, 2026 at 11:35:31AM +0200, Pop Ioan Daniel wrote:
> Add a chip information structure and a device tree match table entry
> for each of the ADuM7801, ADuM7802, ADuM7811 and ADuM7812. These parts
> are handled the same way as the existing ADuM770x devices and differ
> only in their full-scale input range: ±320 mV for the ADuM7801 and
> ADuM7811, and ±64 mV for the ADuM7802 and ADuM7812.
> 
> The device tree binding lists the ADuM7701 and ADuM7702 as fallback
> compatibles, so the driver can handle these parts through the fallback
> alone. The dedicated entries are added so that the IIO device reports
> the real part name instead of the name of the fallback part.
> 
> Rework the Kconfig help text to list one supported part per line, so
> that new parts can be added without rewrapping the text, and make the
> prompt generic instead of naming only the AD7405.

> -	tristate "Analog Devices AD7405 ADC Driver"
> +	tristate "Analog Devices AD7405 and similar isolated sigma-delta modulators driver"

Update the top comment of the driver along with MODULE_DESCRIPTION() so that
all three have the same (or quite similar text, like without word 'driver').

...

Otherwise LGTM.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-11-05 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  9:35 [PATCH v2 0/2] iio: adc: ad7405: Add ADuM7801/7802/7811/7812 support Pop Ioan Daniel
2026-11-05  9:35 ` [PATCH v2 1/2] dt-bindings: " Pop Ioan Daniel
2026-11-05  9:35 ` [PATCH v2 2/2] iio: adc: ad7405: Add support for ADuM7801/7802/7811/7812 Pop Ioan Daniel
2026-11-05 12:16   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auxzkfpzV2Zr9QSo@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=dragos.bogdan@analog.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=pop.ioan-daniel@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®