From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.10 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793895666; b=T1vy5cgI+VzOqAwTr11ln0WRRv/+KuPpEcKlLpTpMtJh+/gwgI1mX9ukO7RPATf/ggf7 6zObdB73bNOV3+dmlC/GB7zjEm8EXZVPHFFjUH9ubsfyucrVn9/QdQ6yN1UmZ3zKqgW1z VKCenA1hovSRZikqbuv7MWiuyd10fOBLZDK6gkh2ykdShzhVtWyp9U3Xo0GR4pVKAdnix AJ4Gc7QVMAhlM7vF9qMJyiFwgqBLzGKuoag8T/duNXKeyh5qPSygayC4RIPI6bSeppbk6 KGeAhCLPgIt4JgzHEzflKo6V+/m+frrI2s0SqY+uCw/JyDJGzc8LXR78deZg/YZfpcQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793895666; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=mCDHjnfHmjXphkKNTy4mvKXOuSzSGdMBw/TihcgjR9k=; b=Ca1sbGh8sVu6ig808uD3gG/fH2LWKfVP4DVQCM2Ycg2JxnnmqEuMtIX7nSmSkH5Z/PKs UoPEhV4B3H2AtfuTQntf3tguVVqsk3nXCpghZvdPsY/bTaYTwSbfvkZJFeGSWeL6gOCW0 HpRtZ/HvDob85gT/uB9Gpt185JKu7DWR5NHyQLozmnk2K2HyCbHfqmdliVfmKC6AHoECT 2UdQaJrVg0njUiHrRaKz9axJ/N26Y98U15LpM5/vTz4GXoWOSgH4qmXpCjZS7JL0P/dus 05OVZdoUZCGPGgB7U9XMmCEfthWK6axiyNLyYlUnnDCKVRRmGp8b/YccZ4RmdrZcytw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=HxUIB3hA; arc=none smtp.remote-ip=192.198.163.10 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E285606A31B; Thu, 5 Nov 2026 16:21:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4E285606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=HxUIB3hA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793895666; x=1825431666; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QxDHsvCqUjq4O8YOdxOCJNBufX1aLlspElnAhn8Pz4E=; b=HxUIB3hAmSwyXDFj9SevwjKYONta8jNcqNStv14F7PuLt/3uo5gfHwYc zrllIvjD5cSgSdleFvMCdZNR70vDSivLmbPqp3d9agwAnYSCC3edPyUxu WGw6ZALUkLgG33ASDibm4y/mNjKnfARI5AHXNAJkzUUqGOHNL3FnPn0JC Jde0N93XFmjCKIbWeWkLRJYQ0jNo1UkC2f+4TiL0JC2JzQxqkTaVGnaTh 7pRuLiOUi0INtczRsyu7yKhOSWi5UMMAyZiqNNvOlKdzPwHZQawZyizeB eKE/LJorm8LCi4vKIwp3qHL21CstISI3+w/66p+Rw2sBrIjFj0fxJxN1I Q==; X-CSE-ConnectionGUID: 6YyDEBfHQVGE3ZRbA7eiiA== X-CSE-MsgGUID: IGp6DG+9SOGaTkJqD1zDEg== X-IronPort-AV: E=McAfee;i="6800,10657,11957"; a="2591429" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2591429" Received: from fmviesa013.fm.intel.com ([10.60.135.153]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 08:21:04 -0800 X-CSE-ConnectionGUID: YbUrFFQGSAaXsveonbABYA== X-CSE-MsgGUID: jGKUSnSPRaK/UD1LYVlM+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="8913746" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 08:20:52 -0800 Date: Thu, 5 Nov 2026 18:20:49 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Thierry Reding , Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peter Griffin , Alim Akhtar , Laxman Dewangan , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Kartik Rajput , Fan Wu , Nicolai Buchwitz , Karl Mehltretter , Stefan =?iso-8859-1?Q?D=F6singer?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..." , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/STM32 ARCHITECTURE" , vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Message-ID: References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> <2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 03:35:20PM +0100, Krzysztof Kozlowski wrote: > On 05/11/2026 15:17, Andy Shevchenko wrote: > >>> --- > >>> drivers/tty/serial/8250/8250_dma.c | 6 ++---- > >>> drivers/tty/serial/8250/8250_mtk.c | 3 +-- > >>> drivers/tty/serial/8250/8250_omap.c | 6 ++---- > >>> drivers/tty/serial/amba-pl011.c | 6 ++---- > >>> drivers/tty/serial/atmel_serial.c | 6 ++---- > >>> drivers/tty/serial/fsl_lpuart.c | 6 ++---- > >>> drivers/tty/serial/imx.c | 6 ++---- > >>> drivers/tty/serial/msm_serial.c | 6 ++---- > >>> drivers/tty/serial/mxs-auart.c | 6 ++---- > >>> drivers/tty/serial/pch_uart.c | 6 ++---- > >>> drivers/tty/serial/samsung_tty.c | 6 ++---- > >>> drivers/tty/serial/serial-tegra.c | 6 ++---- > >>> drivers/tty/serial/sh-sci.c | 9 +++------ > >>> drivers/tty/serial/sprd_serial.c | 3 +-- > >>> drivers/tty/serial/stm32-usart.c | 6 ++---- > >>> 15 files changed, 29 insertions(+), 58 deletions(-) > >> > >> Reviewed-by: Thierry Reding > > > > Krzysztof, now look at this case. I would argue that this is even less fit than > > # subpart(s) case, because it might imply anything. Again the problem is the > > bundle, and for such a case (when tons of independent changes are bundled in > > the same stuff, *every* Rb tag has to be explained on what has been reviewed! > > I think this case is obvious - Thierry reviewed this patch and gives Rb > tag, according to reviewer's statement of oversight. It's unclear from a bare tag, It misses that kind of information. Documentation is also unclear to me as it does *not* describe the case what should I do when independent things are mixed together. > I don't see a problem here or what is questionable. And I obviously see the issue. -- With Best Regards, Andy Shevchenko