From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=198.175.65.17 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793895521; b=wwyiCfV0uZpB2Vin4jgvh8gwpGPw5wWaqvRwccVtUg0Lz5QjiCe8HOYbuzPbyF9T0lUA XiTqISDxZ7OZKH1StT+s/yWHCEIM5gy1Pa2RXWDsQxs70PyoAXZHeDOWBPzX2hseOKIyC TgC07I+vOPOac9Iii6VQN3G27TJ87W2GfzNsgPaGdpv1vCV6rZkxbykziH2uXvRKYjjHs 694lG5/z4/OeHMXKYnQTreU1Y6+I+FCujj+y7bA9tR8g1lA0gCXbq1dIeyyOmoB6IL1q3 nyvCgE6PT1cV0B3GyRDu/REZQ2DOWvobuThohYDqvER3eW2dxFOcqobUweJKgdBpCzQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793895521; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=jjGITOFEbZVfMgIGnW+wZ1UcQbDHnChGWTS+tVJ4LPo=; b=bzZsp2uvxC8lmkqMbOoLpfKc9fl7EYupWAyqK/9UIqHDk7VZUdvsLX77YANE+bmGe0Td eR7ibS5ncA3iPRbt3CobYANv0VM74EwQA2Qcxx4huoNfvSc+PqmKWtngIRAGzfcksM16d nGkTIK10zSj/zmipsXxHWBm7h2OsVrIlvx1RNCPVEtIafwLi3+QadCwKM3t6Vc3j7yq+g mMH9B0uXghjat6Uh69XKje3Z/NYKRV7zgUUqwqI5Srue0JVmBgoUJ22GSbryBVYPXB1Eu zXMcev3bMLaLK78rEMVvNvwtK79c3P6ID1uXP4olSRlwpdBWfjureWR9utFfM5pQ93g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Fvq8NHo8; arc=none smtp.remote-ip=198.175.65.17 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F894606EE80; Thu, 5 Nov 2026 16:18:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2F894606EE80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Fvq8NHo8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793895521; x=1825431521; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+tKMfQT08C0WHdhvauaJZ31Qu1iXJYv2JxCKBEvtIII=; b=Fvq8NHo8O1KWRnK+tcR4pj28wRwvPKHY3g43LZGr1Tn/eFLf8kIfJ695 yN8MvlgKSV2c7Njx6WUPmWY9gSkqOeivfVaHByhlKy+hK1L1HV61qPeLh Wfue22cAW9oxNrV2a0UEMW2FVisFf6PLBsEVbCoT0TwxRHQNP+sz4b5rW CKrwjpqFUlvZyM/t2ipLebfaN+qvMviT67RQyzKwIid9Ru1mD+buyIVC3 ikt9QJKZToP9ohu1HtA4N0StlWFN/lb+VMJvynMKC6MY8dV6AlSUY+DBv tCkD1VJlECeGGCTk8m+LHRNvdjl4IwByDemrQklHExCRuCGrV88rOZpGT w==; X-CSE-ConnectionGUID: ls83FEblQSSfAZC/saqQRw== X-CSE-MsgGUID: JGgR8LdoTc6GMBkiMjbs6A== X-IronPort-AV: E=McAfee;i="6800,10657,11957"; a="2716024" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2716024" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 08:18:39 -0800 X-CSE-ConnectionGUID: VPPaJ+9hRqqWnjtDTyPN5g== X-CSE-MsgGUID: 2X+7AsqFSfaAFSLbFky6Xg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="7368194" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 08:18:24 -0800 Date: Thu, 5 Nov 2026 18:18:22 +0200 From: Andy Shevchenko To: Thierry Reding Cc: Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laxman Dewangan , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Kartik Rajput , Fan Wu , Nicolai Buchwitz , Karl Mehltretter , Stefan =?iso-8859-1?Q?D=F6singer?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..." , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/STM32 ARCHITECTURE" , vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Message-ID: References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 04:36:38PM +0100, Thierry Reding wrote: > On Thu, Nov 05, 2026 at 04:17:53PM +0200, Andy Shevchenko wrote: > > On Thu, Nov 05, 2026 at 01:28:46PM +0100, Thierry Reding wrote: > > > On Mon, Nov 02, 2026 at 12:54:48PM -0500, Frank.Li@oss.nxp.com wrote: > > > > > > > > Replace open-coded assignments to callback and callback_param fields > > > > of struct dma_async_tx_descriptor with calls to the > > > > dmaengine_desc_set_callback() helper across serial drivers. > > > > > > > > No functional change intended. Prepare to make struct > > > > dma_async_tx_descriptor private to the DMA engine. > > > > > > > > Signed-off-by: Frank Li > > > > --- > > > > drivers/tty/serial/8250/8250_dma.c | 6 ++---- > > > > drivers/tty/serial/8250/8250_mtk.c | 3 +-- > > > > drivers/tty/serial/8250/8250_omap.c | 6 ++---- > > > > drivers/tty/serial/amba-pl011.c | 6 ++---- > > > > drivers/tty/serial/atmel_serial.c | 6 ++---- > > > > drivers/tty/serial/fsl_lpuart.c | 6 ++---- > > > > drivers/tty/serial/imx.c | 6 ++---- > > > > drivers/tty/serial/msm_serial.c | 6 ++---- > > > > drivers/tty/serial/mxs-auart.c | 6 ++---- > > > > drivers/tty/serial/pch_uart.c | 6 ++---- > > > > drivers/tty/serial/samsung_tty.c | 6 ++---- > > > > drivers/tty/serial/serial-tegra.c | 6 ++---- > > > > drivers/tty/serial/sh-sci.c | 9 +++------ > > > > drivers/tty/serial/sprd_serial.c | 3 +-- > > > > drivers/tty/serial/stm32-usart.c | 6 ++---- > > > > 15 files changed, 29 insertions(+), 58 deletions(-) > > > > > > Reviewed-by: Thierry Reding > > > > Krzysztof, now look at this case. I would argue that this is even less fit than > > # subpart(s) case, because it might imply anything. Again the problem is the > > bundle, and for such a case (when tons of independent changes are bundled in > > the same stuff, *every* Rb tag has to be explained on what has been reviewed! > > It may be a bit subtle, but the placement of the tag indicates that it > applies to the entirety of the changes. I didn't crop the list of > changed files, nor did I omit the summary. This doesn't clarify the question. Wordless Rb tag on a bundles is an oddity. > That bit of meta-data obviously isn't picked up into the tag line, but > I think the default meaning of Reviewed-by is that it applies to the > entire thing. And I interpret it otherwise, because this is a set of independent changes bundled into a single patch! -- With Best Regards, Andy Shevchenko