From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.17 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793901725; b=knxLPsgNH0xuxMvGr9rEA+LAnULCwuebYEbb8Tq0iE2SpVtoXPGmCZqi3Qt5FnRCg7eb jlet7TjuMlBTzOOYsLZEvqQjy2KWERsZRA84Bde5Ii7PlhpnWWjtjJgOzMV05e+CXpNvP ohhLkKmJMcas0smpoUPcwZoXSsv8alSrF4aFMjojK/q8dR3QX/73KEpnU5UGMjL5qzzxx ZO2jC5dVOEf3kPBuVUGpTkZEDhEHHAtWnez40nwG7A6eetIxf+xTJSde8EW7Z9nSm+tfr /SX8xcsgOyCG8UgMjEehfnyUmQTEd9MLUn6UiKJbyX1WIN5T7LuVyP9cCLXz1zg8KrQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793901725; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=t6PWC1eE/ypb4qPLQJ8oNFKL36rk1z0wUhJwubCVn0A=; b=OqdYXJthoEF6uCK7wKuk3ZWSRj8xOq63kL1dTA+JkgzqKEtLLD7JLm0R1cJg7eYchIgv wc1sN/1zmFiWqTpCeUcQyMExg5tHbsNZLVCPtNyCKjkN8VfRWzMfu6fnqHiVD2KNtX5Bb 912U0L5r7v0y9RnyO0kJ31NhuCrIhs7adMrNTZIT8CxFBqd5BaWAb38kKCTFL58d/xWWG wadS4OnP8XpuSR+L/0iwsIPzFD6mHo6QBXGPZRs76MEzAsIubkQS7+qq5JapQLgjizWBN XdN1QBEhkD6WD3G/FlxNKh6C+2tTXPz7uVzxmlKdRPAqVsU9MmJFWOJCP0AVkEx3gdA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b="gkaO/+ln"; arc=none smtp.remote-ip=192.198.163.17 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9692D606D815; Thu, 5 Nov 2026 18:02:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9692D606D815 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=gkaO/+ln DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793901725; x=1825437725; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wZcZ+09X62UsmqZYTYOPGpjxgnZfzRH+TDK05Cpt6Zc=; b=gkaO/+ln4JxoZS8xpRh4w6dTTzkfxqdqN8gm51Xswnxwx6A1NXM6JVhm VOFUaxqXXq3U1iAeCWBVzXsQmetF5nyvjYyMLzQ2o4KQ3ZMvu3aH91rk/ EVNKCPVGpLYY3XoMyVFK4uwK+HuZRYQHZtsYlqPlODx9wsevO084ZIXz7 RSX6TCrSHj4D5nWyoe9XwjjtLWjLxUxtxzj2gz/V9fyakqbJnMmVmeZwa 1qyNlL+tTvX/+kqw8u795/r3V5ntN9db3ZIsIdCMBm4mn2YVbumGNszY4 TlZzCtG/rfrnDBaQf4YcYD042kYbMImbRNbE+dTE3xEfYWaYNErbrgq5f Q==; X-CSE-ConnectionGUID: aE780vfyT6WXYCYaCfHilA== X-CSE-MsgGUID: APu4f+rJS86ciqQG3c31lQ== X-IronPort-AV: E=McAfee;i="6800,10657,11957"; a="2708927" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2708927" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 10:00:00 -0800 X-CSE-ConnectionGUID: p6BdeozpRwGA0VkthoS13A== X-CSE-MsgGUID: L7eHp5OGTNyb9x3AbVTe5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="7491841" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 09:59:46 -0800 Date: Thu, 5 Nov 2026 19:59:44 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Thierry Reding , Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peter Griffin , Alim Akhtar , Laxman Dewangan , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Kartik Rajput , Fan Wu , Nicolai Buchwitz , Karl Mehltretter , Stefan =?iso-8859-1?Q?D=F6singer?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..." , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/STM32 ARCHITECTURE" , vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Message-ID: References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> <2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 05:26:18PM +0100, Krzysztof Kozlowski wrote: > On 05/11/2026 17:20, Andy Shevchenko wrote: > > On Thu, Nov 05, 2026 at 03:35:20PM +0100, Krzysztof Kozlowski wrote: > >> On 05/11/2026 15:17, Andy Shevchenko wrote: > >>>>> --- > >>>>> drivers/tty/serial/8250/8250_dma.c | 6 ++---- > >>>>> drivers/tty/serial/8250/8250_mtk.c | 3 +-- > >>>>> drivers/tty/serial/8250/8250_omap.c | 6 ++---- > >>>>> drivers/tty/serial/amba-pl011.c | 6 ++---- > >>>>> drivers/tty/serial/atmel_serial.c | 6 ++---- > >>>>> drivers/tty/serial/fsl_lpuart.c | 6 ++---- > >>>>> drivers/tty/serial/imx.c | 6 ++---- > >>>>> drivers/tty/serial/msm_serial.c | 6 ++---- > >>>>> drivers/tty/serial/mxs-auart.c | 6 ++---- > >>>>> drivers/tty/serial/pch_uart.c | 6 ++---- > >>>>> drivers/tty/serial/samsung_tty.c | 6 ++---- > >>>>> drivers/tty/serial/serial-tegra.c | 6 ++---- > >>>>> drivers/tty/serial/sh-sci.c | 9 +++------ > >>>>> drivers/tty/serial/sprd_serial.c | 3 +-- > >>>>> drivers/tty/serial/stm32-usart.c | 6 ++---- > >>>>> 15 files changed, 29 insertions(+), 58 deletions(-) > >>>> > >>>> Reviewed-by: Thierry Reding > >>> > >>> Krzysztof, now look at this case. I would argue that this is even less fit than > >>> # subpart(s) case, because it might imply anything. Again the problem is the > >>> bundle, and for such a case (when tons of independent changes are bundled in > >>> the same stuff, *every* Rb tag has to be explained on what has been reviewed! > >> > >> I think this case is obvious - Thierry reviewed this patch and gives Rb > >> tag, according to reviewer's statement of oversight. > > > > It's unclear from a bare tag, It misses that kind of information. Documentation > > is also unclear to me as it does *not* describe the case what should I do when > > Documentation is clear and I quote to you multiple times, to which you > did not respond. > > "Reviewed-by:, instead, indicates that *the patch* has been reviewed and > found acceptable according to the Reviewer's Statement:" > > Important: "THE PATCH" > > Further: > > "I state that: > (a) I have carried out a technical review of *this patch* to evaluate > its appropriateness and readiness for inclusion into the mainline kernel." > > And further: > > "A Reviewed-by tag is a statement of opinion that *the patch* is an" > > All of these are exhaustive (as in complete) statements leaving no > interpretation whether this is part of patch or entire patch. It is THE > patch, meaning entire patch. > > You do not drive your car, as only a wheel. You driver *the car*. > > You live in some apartment. *The apartment* is your home, not "piece of > your apartment is your home". And I'm trying to explain my point: "the car" in this case is actually "the cars"! I drive mine, you driver yours. "The PATCH" is wrong term when it's bundled. -- With Best Regards, Andy Shevchenko