From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=192.198.163.16 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793901871; b=mMVdFFzgcWQ6DXmasfeqFOXGoel28gPZr8tmQfDNiheJ4gOmzLR3dHs2kQ4umkKDkcRL ApCpqc5kDADdAuDwlqdW3X9+6NKajIwJ7zdzTeApS+3WPNVtG0CrOrG1BkLkarA3jYOdD ct7wXtJ2IFJ8azxM1PLoG+tfxC//Jwa6gHRR/MqZsyAwSpTQTnzoZr3Rv7J5n4/uVrJcY g0FkjJv5WlUCLQwW0+RwpKMBkgCaOAalWXlXCvTwmgaMZ7fZcnx36YDqr3OQzcyw/DVXL f0uBjQykxelI1yca9kq581cmcBy5192OY5mrLQL7XWJ4dj3snyAmSv2pwVDJSG9o/Og== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793901871; h=DMARC-Filter:DKIM-Signature:X-CSE-ConnectionGUID:X-CSE-MsgGUID: X-IronPort-AV:X-IronPort-AV:Received:X-CSE-ConnectionGUID: X-CSE-MsgGUID:X-ExtLoop1:X-IronPort-AV:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:Organization; bh=UY8nz4Aqcfrs8TMTR+vcYN7VMZs4wGxQCWcDHSOttJc=; b=NiK2ZvWcxM/ezu2n+PJNt+qI/VUwbiUFu/QxW7Vc3giWhWUEpTl5xG1qh3SUtrhm7gak vaSOCnOylL1UKYS74S83MU9Vv3syjHaZ41ujDQnb45mBbPGQYnj1SRxOGeOSGEhFt3a0S zkAkYZ6L+gQGw42WQP+ICkzZGR6EjaPO2XITUd3+44apbW3E41iHBG1t+1Hp3KaWs8Xtv BGR1P3JS/Sz5sZQU+OEKdqiMaJaejo4QqsZeMhPrp9B4Stzs55cCzdStmRMUPCM4zQHDA tAYYv4AVi0THfFcSlw4VxeaTr20GB+fscDlCtRFZKNtd8Y6ZqZnqkCqXnJ98dblMXhw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ce7ueDI5; arc=none smtp.remote-ip=192.198.163.16 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC3A6606A31B; Thu, 5 Nov 2026 18:04:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CC3A6606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ce7ueDI5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1793901871; x=1825437871; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mB+/MQQhJQVeGV4JbRgy/ORiYRC7GgvinmAy4COuNBM=; b=ce7ueDI5PwFJh+Fe/qewFUYMbFUieLKlnW3EaxdUhCU/xlOsMqXcEtRR s77HhuqAt4XW5po5eWqUj4r7/M7EFDthG1oUVy71H84eTfrxZA3cXjk/C FLTAsDdZEiaPpYH7wTJs0m7J+GNV+W3DvHnXDSJWjYHC/+k+8xuy+Erhr 9XuMeMpzc4cWI97k/FKb2Lo9l+9ciSz1PfTcMBVV01CMi2pGZoGqD5efj UNEA9/VWtiSdNFQp01h8R2LX9VlIspvd3Pje0WBwU97q6gaNhgAFMn8qQ WvOoLD9gqj0mZNPx9bx9YwB59zDOA5x0RqFM0DCC9lwbw/mSp8pfLv0ul w==; X-CSE-ConnectionGUID: stOyJFEbS861NFPvf1j/nw== X-CSE-MsgGUID: Pbcu+lJIRX+bH7MLS61H/g== X-IronPort-AV: E=McAfee;i="6800,10657,11957"; a="2724890" X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="2724890" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 10:02:51 -0800 X-CSE-ConnectionGUID: jhDE0fjjTqa54XFJuRu5ww== X-CSE-MsgGUID: m0EeljFZT++7vJEePZQ3VA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,197,1787036400"; d="scan'208";a="7090663" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.144]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2026 10:02:37 -0800 Date: Thu, 5 Nov 2026 20:02:34 +0200 From: Andy Shevchenko To: Krzysztof Kozlowski Cc: Thierry Reding , Frank.Li@oss.nxp.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peter Griffin , Alim Akhtar , Laxman Dewangan , Jonathan Hunter , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Cunhao Lu <1579567540@qq.com>, Raul E Rangel , Yenchia Chen , Zhiyong Tao , Carlo Caione , Moteen Shah , Kendall Willis , Kartik Rajput , Fan Wu , Nicolai Buchwitz , Karl Mehltretter , Stefan =?iso-8859-1?Q?D=F6singer?= , Shitalkumar Gandhi , Peng Fan , Sherry Sun , John Ogness , Pan Chuang , Petr Mladek , Robin Gong , Konrad Dybcio , Stephan Gerhold , Zhaoyang Yu <2426767509@qq.com>, "Nikola Z. Ivanov" , Haoxiang Li , "Mike Rapoport (Microsoft)" , Biju Das , Geert Uytterhoeven , Myeonghun Pak , Wenhua Lin , Cixi Geng , "open list:TTY LAYER AND SERIAL DRIVERS" , "open list:TTY LAYER AND SERIAL DRIVERS" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..." , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:TEGRA ARCHITECTURE SUPPORT" , "moderated list:ARM/STM32 ARCHITECTURE" , vkoul@kernel.org Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Message-ID: References: <20261102175527.3957740-1-Frank.Li@oss.nxp.com> <2209947d-0b9b-417f-9ffb-1c81790af9db@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2209947d-0b9b-417f-9ffb-1c81790af9db@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Nov 05, 2026 at 05:21:06PM +0100, Krzysztof Kozlowski wrote: > On 05/11/2026 17:18, Andy Shevchenko wrote: > > On Thu, Nov 05, 2026 at 04:36:38PM +0100, Thierry Reding wrote: > >> On Thu, Nov 05, 2026 at 04:17:53PM +0200, Andy Shevchenko wrote: > >>> On Thu, Nov 05, 2026 at 01:28:46PM +0100, Thierry Reding wrote: > >>>> On Mon, Nov 02, 2026 at 12:54:48PM -0500, Frank.Li@oss.nxp.com wrote: > >>>>> > >>>>> Replace open-coded assignments to callback and callback_param fields > >>>>> of struct dma_async_tx_descriptor with calls to the > >>>>> dmaengine_desc_set_callback() helper across serial drivers. > >>>>> > >>>>> No functional change intended. Prepare to make struct > >>>>> dma_async_tx_descriptor private to the DMA engine. > >>>>> > >>>>> Signed-off-by: Frank Li > >>>>> --- > >>>>> drivers/tty/serial/8250/8250_dma.c | 6 ++---- > >>>>> drivers/tty/serial/8250/8250_mtk.c | 3 +-- > >>>>> drivers/tty/serial/8250/8250_omap.c | 6 ++---- > >>>>> drivers/tty/serial/amba-pl011.c | 6 ++---- > >>>>> drivers/tty/serial/atmel_serial.c | 6 ++---- > >>>>> drivers/tty/serial/fsl_lpuart.c | 6 ++---- > >>>>> drivers/tty/serial/imx.c | 6 ++---- > >>>>> drivers/tty/serial/msm_serial.c | 6 ++---- > >>>>> drivers/tty/serial/mxs-auart.c | 6 ++---- > >>>>> drivers/tty/serial/pch_uart.c | 6 ++---- > >>>>> drivers/tty/serial/samsung_tty.c | 6 ++---- > >>>>> drivers/tty/serial/serial-tegra.c | 6 ++---- > >>>>> drivers/tty/serial/sh-sci.c | 9 +++------ > >>>>> drivers/tty/serial/sprd_serial.c | 3 +-- > >>>>> drivers/tty/serial/stm32-usart.c | 6 ++---- > >>>>> 15 files changed, 29 insertions(+), 58 deletions(-) > >>>> > >>>> Reviewed-by: Thierry Reding > >>> > >>> Krzysztof, now look at this case. I would argue that this is even less fit than > >>> # subpart(s) case, because it might imply anything. Again the problem is the > >>> bundle, and for such a case (when tons of independent changes are bundled in > >>> the same stuff, *every* Rb tag has to be explained on what has been reviewed! > >> > >> It may be a bit subtle, but the placement of the tag indicates that it > >> applies to the entirety of the changes. I didn't crop the list of > >> changed files, nor did I omit the summary. > > > > This doesn't clarify the question. Wordless Rb tag on a bundles is an oddity. > > No, it's perfectly normal and typical. I would not expect anything else, > because writing "LGTM" is pointless. We are experienced reviewers and we > do understand what Reviewer's statement of oversight means, thus giving > the tag is obvious, explicit and not odd. > > > > >> That bit of meta-data obviously isn't picked up into the tag line, but > >> I think the default meaning of Reviewed-by is that it applies to the > >> entire thing. > > > > And I interpret it otherwise, because this is a set of independent changes > > bundled into a single patch! > > It's not set of independent changes, but even if it was then it would > not matter. We review the code regardless how we actually judge the > atomicity of a patch. And I confront exactly that! When the patch may be split it has to. This is seems the outcome of this discussion to me. From now on I think I will NAK any bundle patch until piece that I in charge to is split from the bundle. -- With Best Regards, Andy Shevchenko