From: Xu Yilun <yilun.xu@linux.intel.com>
To: Alexey Kardashevskiy <aik@amd.com>
Cc: x86@kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, Kiryl Shutsemau <kas@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
dave.hansen@intel.com, kvm@vger.kernel.org, yilun.xu@intel.com,
xiaoyao.li@intel.com, sohil.mehta@intel.com,
adrian.hunter@intel.com, kishen.maloor@intel.com,
tony.lindgren@linux.intel.com, peter.fang@intel.com,
baolu.lu@linux.intel.com, zhenzhong.duan@intel.com,
chao.gao@intel.com, artem.bityutskiy@linux.intel.com,
nik.borisov@suse.com
Subject: Re: [PATCH v5 3/6] x86/virt/tdx: Add extra memory to TDX module for the extensions
Date: Wed, 18 Nov 2026 10:32:13 +0800 [thread overview]
Message-ID: <av0OLVB/PMjYz5cS@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <3c82411b-dfec-4b26-9e7f-777c8f1ecb6d@amd.com>
On Tue, Nov 17, 2026 at 02:06:47PM +1100, Alexey Kardashevskiy wrote:
> On 11/11/26 14:48, Xu Yilun wrote:
> > TDX module extensions need memory for their execution environment to
> > serve SEAMCALL leafs. The TDX architecture implements the extensions
> > in such a way that they use the memory outside of SEAM range, so the
> > kernel should add the memory upfront at initialization time.
> >
> > Introduce a new memory adding process backed by a new SEAMCALL leaf
> > TDH.EXT.MEM.ADD. The kernel queries TDX module how much memory needed,
> > allocates it, adds it to the module, and never gets it back. Note that
> > the process requires Dynamic PAMT backing. A subsequent patch adds the
> > support. This doesn't break bisectability cause the extensions can't be
> > enabled yet without a feature that uses them.
> >
> > The TDX module accepts the memory in the form of an HPA array. This
> > array is passed via a single 64-bit SEAMCALL leaf parameter, which
> > encodes two values: the PFN of the container page holding the array, and
> > the number of entries in the array. Create a helper to encode this
> > format and name it after the TDX module term: HPA_LIST_INFO.
> >
> > TDX module extensions consume tens of megabytes memory that will never
> > be returned to the host. Use contiguous page allocation to isolate these
> > large blocks entirely. This is a simple way to avoid permanent memory
> > fragmentation: requiring the full size to be contiguous is more
> > expensive than needed but should be good during the boot time. Print the
> > allocation amount on TDX module extensions initialization for
> > visibility.
> >
> > The TDX module provides a metadata field "required_pages" to indicate
> > the required memory size. This metadata is meaningful only after the
> > add-on feature configuration. Don't read and cache the metadata in
> > tdx_sysinfo. Instead read it right before allocating memory for the
> > extensions, when it is guaranteed to be valid.
> >
> > The original changelog was written by hand. AI was used to help correct
> > grammatical errors and polish individual sentences for better
> > readability.
> >
> > Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
> > Reviewed-by: Tony Lindgren <tony.lindgren@linux.intel.com>
> > Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
> > Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> > ---
> > An alternative solution is to use a loop that gives memory on a memory
> > error code - TDX_EXT_MEMORY_POOL_REQUIRED, add one page per iteration
> > until TDH.EXT.INIT succeeds. Something like:
> >
> > do {
> > ret = tdh_sys_init();
> > if (ret == TDX_EXT_MEMORY_POOL_REQUIRED)
> > tdh_ext_mem_add(); //single page
> > } while (ret == TDX_EXT_MEMORY_POOL_REQUIRED);
> >
> > This approach is slightly simpler as we don't have to query the module
> > for the total memory, no memory pre-allocation or segmentation math.
> > But allocating a single 4K page per iteration may cause permanent memory
> > fragmentation.
>
> Why not allocating new memory in 2MB chunks, reducing fragmentation? Thanks,
Allocating & adding 2MB by 2MB reduces fragmentation. But we would end up
trying to add more memory than needed, then have to deal with extra error
handling about "memory pool full in the middle of the page list", which
defeats the purpose of "simpler".
An earlier discussion about the exact concern:
https://lore.kernel.org/all/e05f49c28a78de961130655a76f415b01774016e.camel@intel.com/
Thanks.
next prev parent reply other threads:[~2026-11-18 2:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 3:48 [PATCH v5 0/6] Enable TDX module extensions Xu Yilun
2026-11-11 3:48 ` [PATCH v5 1/6] x86/virt/tdx: Move TDH.SYS.CONFIG operations into a wrapper Xu Yilun
2026-11-13 15:06 ` Nikolay Borisov
2026-11-11 3:48 ` [PATCH v5 2/6] x86/virt/tdx: Configure add-on features on TDX module init Xu Yilun
2026-11-11 3:48 ` [PATCH v5 3/6] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-11-17 3:06 ` Alexey Kardashevskiy
2026-11-18 2:32 ` Xu Yilun [this message]
2026-11-11 3:48 ` [PATCH v5 4/6] x86/virt/tdx: Support DPAMT when adding memory " Xu Yilun
2026-11-11 3:48 ` [PATCH v5 5/6] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-11-13 16:13 ` Nikolay Borisov
2026-11-11 3:48 ` [PATCH v5 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av0OLVB/PMjYz5cS@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=aik@amd.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kas@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=peter.fang@intel.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sohil.mehta@intel.com \
--cc=tony.lindgren@linux.intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®