mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Volodymyr Chapman <volodymyrchapman@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, andy@kernel.org,
	gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: atomisp: Don't enumerate frame sizes the preview pipe can't output
Date: Wed, 18 Nov 2026 11:51:11 +0200	[thread overview]
Message-ID: <av11D183z21CosFd@ashevche-desk.local> (raw)
In-Reply-To: <20261117175635.11790-1-volodymyrchapman@gmail.com>

On Tue, Nov 17, 2026 at 05:56:35PM +0000, Volodymyr Chapman wrote:
> On Tue, Nov 17, 2026 at 12:31:31PM +0200, Andy Shevchenko wrote:
> > So, what makes us stop implementing the crop support there?
> 
> atomisp only uses its crop path for sensors whose driver supports the
> NATIVE_SIZE, CROP_DEFAULT and CROP selection targets
> (atomisp_init_sensor()). The IMX175 driver does not yet: in his review of
> it, Dave Stevenson suggested that binning, and possibly cropping, should
> wait for the Common Raw Sensor Model. Once the sensor supports cropping,
> atomisp takes the atomisp_enum_framesizes_crop() path and this code
> is not used for it.

Personally to me the above sounds like "we don't accept more raw sensors until
CRSM will be implemented". Because I don't see the point in implementing this
hack just because something is pending. Perhaps we need to push people to tell
what the estimations are for that to appear?

> Even with crop support, preview mode would list nothing larger than
> 1920x1440: that is the largest entry in the frame_sizes table of
> atomisp_enum_framesizes_crop_inner(). This patch applies the same limit
> to the non-crop path.

This confuses me. Would this code be still in use after CRSM be implemented?

> > No need to repeat these two paragraphs, make sure they are in the cover letter.
> 
> Of course. I will keep them in the cover letter only in v2.
> 
> > TBH, this feels like a hack, but I'm not v4l2/media reviewer/maintainer,
> > so I don't know if this approach is legit.
> 
> The intent is to make VIDIOC_ENUM_FRAMESIZES match what
> atomisp_try_fmt() returns, which already clamps the size to 1920x1440 in
> preview mode. Without this patch the IMX175 lists 3264x2448 and
> 1624x1216, and TRY_FMT for 3264x2448 returns 1624x1216. With it, the
> IMX175 lists only 1624x1216 and the OV2722 lists 1916x1076, 1616x1076
> and 1436x1076. Every listed size is returned unchanged by TRY_FMT, and
> for the other sizes I tried (640x480 up to 3264x2448) TRY_FMT
> returned only listed sizes.
> 
> Hans, Sakari, would you prefer this, or a different approach for the
> non-crop path?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-18  9:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 17:57 [PATCH 0/2] media: atomisp: Fix PipeWire/Firefox streaming for sensors without crop or frame interval support Volodymyr Chapman
2026-11-16 17:57 ` [PATCH 1/2] media: atomisp: Don't enumerate frame sizes the preview pipe can't output Volodymyr Chapman
2026-11-17 10:31   ` Andy Shevchenko
2026-11-17 17:56     ` Volodymyr Chapman
2026-11-18  9:51       ` Andy Shevchenko [this message]
2026-11-16 17:57 ` [PATCH 2/2] media: atomisp: Report frame interval for sensors without enum_frame_interval Volodymyr Chapman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av11D183z21CosFd@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=volodymyrchapman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®