From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Haowen Tu <tuhaowen@uniontech.com>
Cc: broonie@kernel.org, david.rhodes@cirrus.com,
rf@opensource.cirrus.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs42xx8: Restore cache-only mode on resume failure
Date: Wed, 18 Nov 2026 09:57:35 +0000 [thread overview]
Message-ID: <av12j1WTLf0zFi5y@opensource.cirrus.com> (raw)
In-Reply-To: <31EF1D727C977B5E+20261118082325.3915977-1-tuhaowen@uniontech.com>
On Wed, Nov 18, 2026 at 04:23:24PM +0800, Haowen Tu wrote:
> The runtime resume callback leaves cache-only mode before synchronizing
> the register cache. If regcache_sync() fails, it disables the supplies and
> clock but leaves cache-only mode disabled. Subsequent register accesses
> can therefore reach the unpowered device instead of using the cache.
>
> Restore cache-only mode before disabling the supplies on a cache sync
> failure, as the runtime suspend callback does before powering down.
>
> Fixes: 0c516b4ff85c ("ASoC: cs42xx8: Add codec driver support for CS42448/CS42888")
> Signed-off-by: Haowen Tu <tuhaowen@uniontech.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2026-11-18 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:23 Haowen Tu
2026-11-18 9:57 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av12j1WTLf0zFi5y@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tuhaowen@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®