> On probe the RGMII link clock is initialised at SPEED_1000, which > translates to a 250 MHz source clock even when no PHY link is present, > drawing unnecessary power. > > Initialise at SPEED_10 instead; set_clk_tx_rate updates the rate once > a link is established. > > The DLL locking is not affected by the current clock rate. This has > been confirmed with actual hardware testing as well as the fact that > the existing code performs the DLL lock first before changing the clock > rate when the link speed changes. > > Reviewed-by: Maxime Chevallier > Signed-off-by: Mohd Ayaan Anwar Reviewed-by: Lorenzo Bianconi > --- > v4: add some details in the commit message to address concerns raised > by Sashiko. > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 99ea7e0cfb00..192788e00dfa 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -828,7 +828,7 @@ static int ethqos_hlos_setup(struct qcom_ethqos *ethqos, > if (ret) > return ret; > > - ethqos_set_clk_tx_rate(ethqos, NULL, plat_dat->phy_interface, SPEED_1000); > + ethqos_set_clk_tx_rate(ethqos, NULL, plat_dat->phy_interface, SPEED_10); > qcom_ethqos_set_sgmii_loopback(ethqos, true); > ethqos_set_func_clk_en(ethqos); > > > -- > 2.34.1 >