mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Shivani Patel <patelshivani2283@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
	Christian Gromm <christian.gromm@microchip.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v3 1/2] staging: most: video: Protect pending_mbos and mute with list_lock
Date: Wed, 18 Nov 2026 12:20:32 +0300	[thread overview]
Message-ID: <av1t4DbqGsmUmrZJ@stanley.mountain> (raw)
In-Reply-To: <20261117170558.33844-1-patelshivani2283@gmail.com>

On Tue, Nov 17, 2026 at 10:35:57PM +0530, Shivani Patel wrote:
> data_ready() and get_top_mbo() read mdev->pending_mbos without holding
> mdev->list_lock, racing with comp_rx_data() which modifies the list
> under mdev->list_lock. Also, comp_vdev_close() clears mdev->mute without
> holding mdev->list_lock.
> 
> Acquire mdev->list_lock in data_ready(), get_top_mbo(), and when
> clearing mdev->mute in comp_vdev_close(). Use list_first_entry_or_null()
> in get_top_mbo() so comp_vdev_read() can drop the redundant data_ready()
> check inside the read loop.
> 
> Signed-off-by: Shivani Patel <patelshivani2283@gmail.com>
> ---
> v3:
>  - New patch added after inspecting list_lock usage per Dan Carpenter's
>    review of v2.

Huh...  This is interesting.

> 
>  drivers/staging/most/video/video.c | 34 ++++++++++++++++++++++++------
>  1 file changed, 27 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
> index 3a0445ff6..92d5fbc9a 100644
> --- a/drivers/staging/most/video/video.c
> +++ b/drivers/staging/most/video/video.c
> @@ -60,14 +60,27 @@ static inline struct comp_fh *to_comp_fh(struct file *filp)
>  static LIST_HEAD(video_devices);
>  static DEFINE_SPINLOCK(list_lock);
>  
> -static inline bool data_ready(struct most_video_dev *mdev)
> +static bool data_ready(struct most_video_dev *mdev)
>  {
> -	return !list_empty(&mdev->pending_mbos);
> +	unsigned long flags;
> +	bool ready;
> +
> +	spin_lock_irqsave(&mdev->list_lock, flags);
> +	ready = !list_empty(&mdev->pending_mbos);
> +	spin_unlock_irqrestore(&mdev->list_lock, flags);
> +
> +	return ready;

It doesn't really matter if we take the lock where since we drop it
right away.  The list_empty() doesn't anything that requires locking
so far as I can see.

>  }
>  
> -static inline struct mbo *get_top_mbo(struct most_video_dev *mdev)
> +static struct mbo *get_top_mbo(struct most_video_dev *mdev)
>  {
> -	return list_first_entry(&mdev->pending_mbos, struct mbo, list);
> +	struct mbo *mbo;
> +
> +	spin_lock_irq(&mdev->list_lock);
> +	mbo = list_first_entry_or_null(&mdev->pending_mbos, struct mbo, list);
> +	spin_unlock_irq(&mdev->list_lock);
> +
> +	return mbo;
>  }
>  
>  static int comp_vdev_open(struct file *filp)
> @@ -143,7 +156,9 @@ static int comp_vdev_close(struct file *filp)
>  	}
>  
>  	most_stop_channel(mdev->iface, mdev->ch_idx, &comp);
> +	spin_lock_irq(&mdev->list_lock);
>  	mdev->mute = false;
> +	spin_unlock_irq(&mdev->list_lock);


I don't see the point of protecting ->mute.


>  
>  	v4l2_fh_del(&fh->fh, filp);
>  	v4l2_fh_exit(&fh->fh);
> @@ -175,10 +190,15 @@ static ssize_t comp_vdev_read(struct file *filp, char __user *buf,
>  	if (!data_ready(mdev))
>  		return -EAGAIN;
>  
> -	while (count > 0 && data_ready(mdev)) {
> +	while (count > 0) {
>  		struct mbo *const mbo = get_top_mbo(mdev);
> -		int const rem = mbo->processed_length - fh->offs;
> -		int const cnt = rem < count ? rem : count;
> +		int rem, cnt;
> +
> +		if (!mbo)
> +			break;
> +
> +		rem = mbo->processed_length - fh->offs;
> +		cnt = rem < count ? rem : count;

The worry here is that we could have more than one reader open, right?
I don't think this is a complete fix, because they could both take the
same mbo and could have cnt >= rem and the other has a use after free.

I'm not super familiar with this code.  I assume it's only supposed to
have one reader at a time.  Maybe it's serialized at a different layer?

regards,
dan carpenter



      parent reply	other threads:[~2026-11-18  9:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:05 Shivani Patel
2026-11-17 17:05 ` [PATCH v3 2/2] staging: most: video: Document locks in struct most_video_dev Shivani Patel
2026-11-18  9:20 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av1t4DbqGsmUmrZJ@stanley.mountain \
    --to=error27@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=christian.gromm@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=parthiban.veerasooran@microchip.com \
    --cc=patelshivani2283@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®