From: Joe Damato <joe@dama.to>
To: Antonio Quartulli <antonio@mandelbit.com>
Cc: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net v2 2/3] igb: link queues to NAPIs under RTNL after runtime resume
Date: Wed, 18 Nov 2026 07:05:29 -0800 [thread overview]
Message-ID: <av2+uVOytr5BDs5P@devvm20253.cco0.facebook.com> (raw)
In-Reply-To: <20261116153041.3002666-3-antonio@mandelbit.com>
On Mon, Nov 16, 2026 at 04:30:38PM +0100, Antonio Quartulli wrote:
> __igb_open() links queues to NAPIs with netif_queue_set_napi(), which
> requires RTNL, but RTNL isn't held when resuming from runtime suspend:
> this triggers "RTNL: assertion failed".
>
> Don't link them in __igb_open() when resuming: do it right away on
> system resume (RTNL held) and from a work item taking RTNL on runtime
> resume. The links can't be kept across a suspend, because
> __igb_shutdown() frees the q_vectors. These are only freed under RTNL
> with __IGB_DOWN set, so the work item checks __IGB_DOWN under RTNL.
>
> Tested with the 82576 emulated by QEMU.
>
> Fixes: b75a1dea500f ("igb: Link queues to NAPI instances")
> Cc: stable@vger.kernel.org # 6.16+
> Closes: https://bugzilla.ipfire.org/show_bug.cgi?id=13562
> Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
> ---
> v2: no code changes; mention the tested hardware.
>
> Note: igc may have the same issue: __igc_open() also links queues to NAPIs
> (igc_set_queue_napi()) on the RTNL-less runtime resume path. We didn't
> have igc hardware to test a fix with, so no igc patch is sent for now.
I have an igc I can test on if you want to send me the script you used to test
this. Feel free to message me off list if you like.
> drivers/net/ethernet/intel/igb/igb.h | 1 +
> drivers/net/ethernet/intel/igb/igb_main.c | 38 +++++++++++++++++++++--
> 2 files changed, 37 insertions(+), 2 deletions(-)
Reviewed-by: Joe Damato <joe@dama.to>
next prev parent reply other threads:[~2026-11-18 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:30 [PATCH net v2 0/3] igb: fix runtime PM resume issues Antonio Quartulli
2026-11-16 15:30 ` [PATCH net v2 1/3] igb: fix RTNL assertion when resuming from runtime suspend Antonio Quartulli
2026-11-18 13:21 ` Janis Edvarts Lacis
2026-11-18 14:52 ` Antonio Quartulli
2026-11-16 15:30 ` [PATCH net v2 2/3] igb: link queues to NAPIs under RTNL after runtime resume Antonio Quartulli
2026-11-18 15:05 ` Joe Damato [this message]
2026-11-16 15:30 ` [PATCH net v2 3/3] igb: only allow runtime PM if the device can wake up Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av2+uVOytr5BDs5P@devvm20253.cco0.facebook.com \
--to=joe@dama.to \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=antonio@mandelbit.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®