From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795007432; b=HFEPotFt1Y4y/Jk0YK252sEQ9LGSN4Mg9qGrQlIT/FKZJimjfo2APpub1lOL0jDtzKSP HLeNmovXt0vf/4VJJm0lcq8dlvzGltsFoJMPG2+ek9Z44KKFlAoLWgR+QRAzpyjC4gx48 k9R39IpD73eZ1CMFmU1MmDWpJIVFsJbRt1sxWC2GjYev+oFDOwy5k+AmVwLmXGGoYDl5R sgjjlTQNrb+IziOi25zoEAHMJfzyBMNgUxWU+YCEmSySO9kux/z+3NPmxKUfgvRvuPoRE UukuWx7dLAqoSi6007Wl+KDfvbsEX+6A5GpXKiMm4sdEEhW1bO6C9ZXoA19EqqTDHwg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795007432; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Scanned-By; bh=SW1SgyAqJZMhz2Qvs3jWCWx5VKPPmPyNUr3G/FpCRlc=; b=fUZrl/jocyD/COURaT+cir7cvTT8NHs6dOh79zorLhQeKLX5916Q5cz11RZpqkW2SgIr /PFXfNdjahEz124AIwsVDLlKcVbiI8w+vC8wHaXdamBbLCBf3iAKrFz6x03naFRa7xOiE uws7tWCwYXFwCH+ivXul2UshS/eTCHas75F2WsKic/qFiIYpmgtAlc71gBNlmyP/1CgcM eqINIV7CdLcdaeAaBxDBN5BA7by6/aC/zx9MIaNagjdGymdWdLlcYzivBI9Bkl07RoCNE 2H/XyxYKFLvGe35a2liAlqjl+weBC4wvOmgeKFMUWUhLudc9iiV1AA+7//8avANQYhg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=h4s7KK0R; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0B1D606A31C for ; Wed, 18 Nov 2026 13:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E0B1D606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=h4s7KK0R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795007430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SW1SgyAqJZMhz2Qvs3jWCWx5VKPPmPyNUr3G/FpCRlc=; b=h4s7KK0RCx+PuC97Hu3C1mZXDsj4pFnluYSW1iihMSu+ngzU54griv7hsy+TBx2cXQMn6E gzCBhwfJd5/0P9IUPssQ3sqpl9WrxE5vfMRa47MM+4+PFXgB+quT9a1kKDWlYQNTVY0tnY lhxzA6tood17aV3Thooi3hf3HItu75U= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-PSY9HXz-MPSmoDPTNZ-_8Q-1; Wed, 18 Nov 2026 08:10:25 -0500 X-MC-Unique: PSY9HXz-MPSmoDPTNZ-_8Q-1 X-Mimecast-MFC-AGG-ID: PSY9HXz-MPSmoDPTNZ-_8Q_1795007423 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1105919560B1; Wed, 18 Nov 2026 13:10:23 +0000 (UTC) Received: from onestero-thinkpadp1gen7.tpbc.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 4D8A23000223; Wed, 18 Nov 2026 13:10:18 +0000 (UTC) Received: by onestero-thinkpadp1gen7.tpbc.csb (nbSMTP-1.00) for uid 13628 oleg@redhat.com; Wed, 18 Nov 2026 14:10:22 +0100 (CET) Date: Wed, 18 Nov 2026 14:10:17 +0100 From: Oleg Nesterov To: Linus Torvalds Cc: Mani Tofigh via B4 Relay , Breno Leitao , Christian Brauner , Mateusz Guzik , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tz2294@columbia.edu, stable@vger.kernel.org, Mani Tofigh Subject: Re: [PATCH] pipe: keep per-write wakeups for EPOLLEXCLUSIVE consumers Message-ID: References: <20261111-pipe-epollexclusive-wakeup-v1-1-0af6283e9fda@columbia.edu> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 11/17, Linus Torvalds wrote: > > That header isn't _horrible_, but some of it was uglier than needed, > and adding WQ_FLAG_PRIORITY would have been a huge pain because the > code unnecessarily special-cases WQ_FLAG_EXCLUSIVE. Yes. See also below. > NOTE! Entirely untested. Comments? I tried to check it line-by-line, see nothing wrong. FWIW, Reviewed-by: Oleg Nesterov --------------------------------------------------------------------------- And this reminds me. Please look at __wait_event_interruptible_locked(), it is buggy. do_wait_intr() and do_wait_intr_irq() use __add_wait_queue_entry_tail() regardless of WQ_FLAG_EXCLUSIVE (reported by Mani in another thread). Plus another problem: exclusive waiter must not fail if it was selected by wakeup, see the comment in prepare_to_wait_event(). What if we add, say, WQ_FLAG_LOCKED and change prepare_to_wait_event() --- x/kernel/sched/wait.c +++ x/kernel/sched/wait.c @@ -274,7 +274,8 @@ long prepare_to_wait_event(struct wait_q unsigned long flags; long ret = 0; - spin_lock_irqsave(&wq_head->lock, flags); + if (!(wq_entry->flags & WQ_FLAG_LOCKED)) + spin_lock_irqsave(&wq_head->lock, flags); if (signal_pending_state(state, current)) { /* * Exclusive waiter must not fail if it was selected by wakeup, @@ -299,7 +300,8 @@ long prepare_to_wait_event(struct wait_q } set_current_state(state); } - spin_unlock_irqrestore(&wq_head->lock, flags); + if (!(wq_entry->flags & WQ_FLAG_LOCKED)) + spin_unlock_irqrestore(&wq_head->lock, flags); return ret; } ? Yes, finish_wait() needs to check WQ_FLAG_LOCKED too... perhaps just if (WQ_FLAG_LOCKED) list_del_init(...); at the start. Then we can trivially redefine all users of __wait_event_interruptible_locked() on top of ___wait_event/etc. Say, wait_event_interruptible_exclusive_locked(wq, condition) can use ___wait_event(wq, condition, TASK_INTERRUPTIBLE, WQ_FLAG_EXCLUSIVE | WQ_FLAG_LOCKED, spin_unlock(&wq->lock); schedule(); spin_lock(&wq->lock)) Will you agree with this hack? If yes, I'll try to make the patch on top of your cleanup. Oleg.