From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795010807; b=GG5SkSzhTGQEWsB1Y/sVvrZK50ADC/Dq/nDvVHxXFE7rGBf3emSNw3gLXI0W5kpsDv1a OepEh0QbMxbYonKXftxzshgCW0tS/UcmEc5UO/4PWv+fUypbATjoRsqGcNrf6g4rGaVth oj8TiSluYlB2yRWs2yHaXLO0/G7hMt5k5gnFT4/Vns0J6T3/dG4KqVfX8TRQSUIxO0mNt smJA4KN4iIqYAYt+sftLvamNlaqrE0hYVjNKLoi1JVk9UYOcc6qrXEm3MzcquhSvEU2uW n14UJjX1blHoc9qgay16yXpZEU/GvzDGn/UBaCGTCZ9EXrlmS1wuV1G3JEpX5dBOFzg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795010807; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=bitf1jye92HcEn1lvhpuExzuT+GWqzGdkrQHhRvG6Ml24yrktVdfkaK6QtwfejSHesm6 CxBMzIATQweLDXZovN8LJWGwVPnsdppfR/YNrksbDQEqtWh++3Xsx6qMeDAgvKuR+PALS Q8iFaDWj1xbqmDFiu7FEm3f4asIGD2ZBH9itc91+vfH+zsgKBps0Rwsi/mmRrQ0p8FuBD MXGQZQB0qwmkZvVDVMo+lN7OmhivTQwmjp6pL/FiUPx6S7MNXFjtaQy4/QP49a6PWv1ou qrcURVWl9KdpI+XnsSh+LP4WrJczIcHfHjYQ0n0di45A0m5VmvPNbw77nN6MO4Dor9w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=hvB4iIuS; arc=none smtp.remote-ip=209.85.128.52 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2AE606A335 for ; Wed, 18 Nov 2026 14:06:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9A2AE606A335 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.a=rsa-sha256 header.s=google header.b=hvB4iIuS Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4bb6886d30aso9014685e9.3 for ; Wed, 18 Nov 2026 06:06:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1795010804; x=1795615604; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=hvB4iIuS8DtMM18Ur596rOV7xllkzUpzo4bnzWY5k0fD7sJ/BrV+0/KQ18Tb6pH2GQ Nn2XziESA7mgE+1ydj355M2ewaMPCB3cmzRLaf+4expSmHER9hyZhW0nCxUr2loegpzU v2vTQH5dENOkhb4kscIg+aakWJcGbF9MAAkh4SZJI6rGEXhJQVQlImPEQVZy9D/uWfuh lDrFchgZk3gMfEELQRtJ9+u3oShBMhztuAghg2t6cw5GK+Z0k/4AVTMUC4iL1yw8I5bG i/Xdt4P+65LHR2xp+JkHPJ1b0MAuBhDHUI3DZNZG14O9PuuXWHSk3/UrorTKJtCBmPfK xItw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795010804; x=1795615604; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O8kUxWwNMGGKdJF+2JBGIvhWCx8VFS9Gq0fs2XPEP3c=; b=mKjOiZivy6NLwLHhMjc7I3WSSPnx7mmK2pKQspSJkS+F4sS1X1V9pBD+XwG5+AKijP 0UA7RGZbwyYiqmY3NldMRxviRLE4Krey55gLGBjtoup4/+KwSCMzxd9QnL/ParomvJNK IfHA+UxWxwNPdPNdoYXqm0ERqekbbDv9JbofihE8WqGj2GaspLjyPa3D0BfAPs39AnhX T4QGCZNOwsmKkmycyTHYqkuQMMEuJm+68YwdHq2lzyBPwux3obBB0MaOfFpKl+rV0/dd ThGFkNqHfHyFTUHwcFJ0h3FGisKM8h8McqwSclVb8V85/f2oDRk1l8CZARdJOOV0EUci l2lA== X-Forwarded-Encrypted: i=1; AL+hErGTrfzkpRPOsmWSMKi6Q1b2QYM+T+RagJTRmRh1MTI0gBPlxpv4qNHgpRXy4A2dq2ovpRaXCzV5sIGmJbo=@vger.kernel.org X-Gm-Message-State: APuU4Z+JCFbvjVYTl0FAZFap8oxOoxtver80q4fx8H/3aoxnfXEZIUee coJnkWVbThGNhNn7fGuv+V/gmi+Xs0/JJfye2c51jYyH6kWCh0b+LgmJlAMecbNaeLs= X-Gm-Gg: AYBFou033rQ/TInP8njIVq5XogJH0JFijc/OxMY/GqDrMTh57NCnjBZeVNEzZ9ev7oE ieKKTLaZ6eWQW2nhk+bB4uAV7p97+reFDRQ7y7brVcBY3hePV9q0OFZD1me7oPBB1BonyJdMm8o 6ugNTa16LQAp8UBv58r3CqQrtEL/dBBUoZc9178EXR5Gx89Zl/c9e37xwqWzpTH8agQh5G/yOVZ hEmBqCXktoq6W1li2Pj5UWcZyZYO0a9rlaSDKHX6qlaPj2dtwm1/hk9zQqknpkdbUSBSWRKTFcx BEeVJ8Qh6qTCwyVccf/M9mMmb4196bq+5iVXr5aDEGl9qNytXgLY492AvU0mSyekcV08ro910oA /DjLim+ZMJuJIy96DyG/7tsjqIrflxLx1jvyriFH+RFfaUVgWf1dpezHpA202giOZYEeoata63J bhhgzW6Aisv3560bLWm2XUJdtg6n9O5NKBs6BazQSkA0t86mgwP8nYfhp9lHqjB4Ljhdt5VH+pH MfAAdWHhdwRbuZGnAUjm8gy+udtNTN0kLVyAcPQWa0h6ipdXEGYcgG9XZWzDsZ7vueEeSsLegSo VjAxkBWdk7rxz1QSHzJEJB1e16EGg8lsGsY= X-Received: by 2002:a05:600c:3509:b0:4bb:68b9:f610 with SMTP id 5b1f17b1804b1-4bb7da03954mr52120315e9.9.1795010803953; Wed, 18 Nov 2026 06:06:43 -0800 (PST) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4bb7d256f64sm61534715e9.1.2026.11.18.06.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 06:06:43 -0800 (PST) Date: Wed, 18 Nov 2026 15:06:41 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jani Nikula Cc: David Airlie , Simona Vetter , Sasha Finkelstein , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org, asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imagination@lists.freedesktop.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays Message-ID: References: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5c6ped4sw6nigwko" Content-Disposition: inline In-Reply-To: <7692c160e418e7ad0528739fcc879b11fbac8ab0@intel.com> --5c6ped4sw6nigwko Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 9/9] drm: Unify coding style for *_device_id arrays MIME-Version: 1.0 Hello Jani, On Wed, Nov 18, 2026 at 03:27:40PM +0200, Jani Nikula wrote: > > [...] > > drivers/gpu/ipu-v3/ipu-common.c | 8 +- > > drivers/gpu/ipu-v3/ipu-pre.c | 4 +- > > drivers/gpu/ipu-v3/ipu-prg.c | 4 +- > > 254 files changed, 1155 insertions(+), 940 deletions(-) >=20 > How do you expect a patch of this size be merged? Using b4 am :-) Honestly, in the cover letter I wrote about an immutable branch and offered to rebase to 7.4-rc1. When trying to apply this series on top ov 7.4-rc1 there are only 6 conflicts (1x modify/delete and 5x content); these are all not so hard to resolve (and even dropping the respective hunks (i.e. resolving using `git checkout HEAD`) is fine for me.) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i91= 5_pci.c > > index 84a7dc6ab5db..faceb3de4fa3 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -870,7 +870,7 @@ static const struct pci_device_id pciidlist[] =3D { > > INTEL_ATS_M_IDS(INTEL_VGA_DEVICE, &ats_m_info), > > INTEL_ARL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > INTEL_MTL_IDS(INTEL_VGA_DEVICE, &mtl_info), > > - {} > > + { } >=20 > Personally, I would *always* use {} instead of { }, and would rather not > change. >=20 > Across the tree, {} is slightly more common than { }. IMO changing them > is pointless churn. It depends on how you count. My statistic looks as follows (on top of next-20261117): $ git grep -l device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/devi= ce_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | sort | uni= q -c 2 } 2 { 6 { } 2598 { } 1262 {} So over all *_device_id { } is more common by a factor of > 2. This series fixes one { } and reduces the number of {} by 37. For only pci_device_id it's: $ git grep -l pci_device_id | xargs -n 1 perl -g -n -e 'print "$1\n" if m/= pci_device_id\s*[a-zA-Z_0-9]*\[\]\s*=3D\s*{(?:\s*{[^}]*},\s*({\s*}))/' | so= rt | uniq -c 159 { } 32 {} Without the context of an array initializer there are many empty code blocks (function bodys or `do {} while (0)`), empty dt nodes, and {} in Rust code, which IMHO have to be considered off-topic for this statistic. Best regards Uwe --5c6ped4sw6nigwko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmr9sOcACgkQj4D7WH0S /k4vggf+PQfM4MkbLgaQRCdXRWWsc4/Fa0tTMBQAl4gjx2p5NE/N7TDUO571o3+N oWcelzY5O1uRcc2qHZVnu3vAxFqzk4YHfGjsbGHsxQAibxnIFW7ttYTzt0w5a9NH v65V6+sebCdwLrPVE5ilcqzFFSgmnv1wTNm2vCEUxdKGacifySaGRmg4+ax+fLb1 CL+RS7fM2EkQxG1k4iDEPv1Onrm9S4DtwTts0wxkK780rWYD9FoSLjHyX/x21Y8x SZKaXeNZlxtHJpQLq8ub8AL/t6k82nC020wYZOUbUmvPyqxhNoUuuS0/RVlz9xT6 kXiliIwWzcMtAKt4ik8nbTRO5JERhQ== =0alU -----END PGP SIGNATURE----- --5c6ped4sw6nigwko--