mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: Dev Jain <dev.jain@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 Vlastimil Babka <vbabka@kernel.org>,
	David Hildenbrand <david@kernel.org>,
	 Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	 Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	 Michal Hocko <mhocko@suse.com>,
	Brendan Jackman <brendan.jackman@linux.dev>,
	 Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
	Qi Zheng <qi.zheng@linux.dev>,
	 Shakeel Butt <shakeel.butt@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 kernel-team@meta.com, Kiryl Shutsemau <kas@kernel.org>
Subject: Re: [PATCH v2 1/3] mm/page_alloc: drop unused gfp_mask from zone_watermark_fast()
Date: Wed, 18 Nov 2026 10:36:06 -0800	[thread overview]
Message-ID: <av3vX31XxmBT6uh6@devbig011.atn3.facebook.com> (raw)
In-Reply-To: <7770de02-3f4a-4db8-9e02-5e95b148b809@arm.com>

On Wed, Nov 18, 2026 at 09:12:51PM +0530, Dev Jain wrote:
> + Kiryl if he has different opinions
> 
> On 18/11/26 8:29 pm, Dev Jain wrote:
> > 
> > 
> > On 17/11/26 4:53 am, Joshua Hahn wrote:
> >> zone_watermark_fast() has not used its gfp_mask argument since commit
> >> 2973d8229b78 ("mm: discard __GFP_ATOMIC") switched the watermark boost
> >> check from __GFP_ATOMIC to ALLOC_MIN_RESERVE.
> >>
> >> Remove the argument, no functional changes intended.
> >>
> >> Reviewed-by: SJ Park <sj@kernel.org>
> >> Reviewed-by: Chris Down <chris@chrisdown.name>
> >> Reviewed-by: Zi Yan <ziy@nvidia.com>
> >> Signed-off-by: Joshua Hahn <joshua.hahnjy@gmail.com>
> >> ---
> > 
> > Note that this series:
> > https://lore.kernel.org/all/20261116125103.2894162-1-kas@kernel.org/
> > 
> > needs to use the gfp mask. So perhaps drop this patch? Otherwise we will
> > just make noise on the list by adding it back :)

Hi Dev,

Thank you for your review on the series. Also, this was a really good
catch, thanks a lot! I'll just drop this as it was just meant to be a
cleanup if there was no new user, but it seems like there will be a
real usecase.

Have a great day!
Joshua

> >>  mm/page_alloc.c | 12 +++++-------
> >>  1 file changed, 5 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> >> index 9e1261521b6a3..4d829e5eac49d 100644
> >> --- a/mm/page_alloc.c
> >> +++ b/mm/page_alloc.c
> >> @@ -3675,7 +3675,7 @@ bool zone_watermark_ok(struct zone *z, unsigned int order, unsigned long mark,
> >>  
> >>  static inline bool zone_watermark_fast(struct zone *z, unsigned int order,
> >>  				unsigned long mark, int highest_zoneidx,
> >> -				unsigned int alloc_flags, gfp_t gfp_mask)
> >> +				unsigned int alloc_flags)
> >>  {
> >>  	long free_pages;
> >>  
> >> @@ -3877,7 +3877,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> >>  		    !waitqueue_active(&zone->zone_pgdat->kswapd_wait)) {
> >>  			mark = wmark_pages(zone, kswapd_watermark);
> >>  			if (!zone_watermark_fast(zone, order, mark,
> >> -					ac->highest_zoneidx, 0, gfp_mask)) {
> >> +					ac->highest_zoneidx, 0)) {
> >>  				skipped_kswapd_nodes = true;
> >>  				continue;
> >>  			}
> >> @@ -3897,8 +3897,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> >>  
> >>  		mark = high_wmark_pages(zone);
> >>  		if (zone_watermark_fast(zone, order, mark,
> >> -					ac->highest_zoneidx, alloc_flags,
> >> -					gfp_mask))
> >> +					ac->highest_zoneidx, alloc_flags))
> >>  			goto try_this_zone;
> >>  		else
> >>  			set_bit(ZONE_BELOW_HIGH, &zone->flags);
> >> @@ -3906,8 +3905,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags,
> >>  check_alloc_wmark:
> >>  		mark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK);
> >>  		if (!zone_watermark_fast(zone, order, mark,
> >> -				       ac->highest_zoneidx, alloc_flags,
> >> -				       gfp_mask)) {
> >> +				       ac->highest_zoneidx, alloc_flags)) {
> >>  			if (cond_accept_memory(zone, order, alloc_flags))
> >>  				goto try_this_zone;
> >>  
> >> @@ -5245,7 +5243,7 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid,
> >>  		mark = wmark_pages(zone, alloc_flags & ALLOC_WMARK_MASK) + nr_pages - nr_populated;
> >>  		if (zone_watermark_fast(zone, 0,  mark,
> >>  				zonelist_zone_idx(ac.preferred_zoneref),
> >> -				alloc_flags, gfp)) {
> >> +				alloc_flags)) {
> >>  			break;
> >>  		}
> >>  
> > 
> 

  reply	other threads:[~2026-11-18 18:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 23:23 [PATCH v2 0/3] mm/page_alloc: get_page_from_freelist cleanups Joshua Hahn
2026-11-16 23:23 ` [PATCH v2 1/3] mm/page_alloc: drop unused gfp_mask from zone_watermark_fast() Joshua Hahn
2026-11-17  9:28   ` Gregory Price (Meta)
2026-11-18 14:59   ` Dev Jain
2026-11-18 15:42     ` Dev Jain
2026-11-18 18:36       ` Joshua Hahn [this message]
2026-11-16 23:23 ` [PATCH v2 2/3] mm/page_alloc: move the kswapd node skip check into a helper Joshua Hahn
2026-11-17  9:29   ` Gregory Price (Meta)
2026-11-18 15:46   ` Dev Jain
2026-11-16 23:23 ` [PATCH v2 3/3] mm/vmscan: consolidate promo vs. high watermark checks Joshua Hahn
2026-11-17  9:29   ` Gregory Price (Meta)
2026-11-18 15:57   ` Dev Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av3vX31XxmBT6uh6@devbig011.atn3.facebook.com \
    --to=joshua.hahnjy@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=kas@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®