mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Erik Tagirov <erik@tagirov.ch>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: robin.clark@oss.qualcomm.com, lumag@kernel.org,
	abhinav.kumar@linux.dev, jesszhan0024@gmail.com, sean@poorly.run,
	marijn.suijten@somainline.org, airlied@gmail.com,
	simona@ffwll.ch, linux-arm-msm@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] drm/msm/dpu: set possible_crtcs on cursor planes
Date: Wed, 18 Nov 2026 22:24:30 +0100	[thread overview]
Message-ID: <av4Xjn3duCXQ581K@gateway.normienet.tagirov.ch> (raw)
In-Reply-To: <7jyydebmplngfnie7sfidwkeomi4xrgaytey6522q7qqsybg47@obppph6ea4ta>

On Wed, Nov 18, 2026 at 10:22:48PM +0200, Dmitry Baryshkov wrote:
> On Wed, Nov 18, 2026 at 09:47:42PM +0100, Erik Tagirov wrote:
> > I am using a lesser known wayland compositor that uses the possible_crtcs field of a plane to detect
> > which one to use for the cursor. On the Lenovo T14s two cursor planes are created, each with possible_crtcs set
> > to 0xff. Which from my understanding means that they can be used with any crtc.
> > 
> > However, the compositor picks the wrong cursor plane which results in a lag of ~17ms
> > on each DRM_IOCTL_MODE_SETPLANE call. Making the cursor movements sluggish.
> > 
> > After some investigation, I found out that this is due to the legacy_cursor_update flag not being set
> > in drm_atomic_helper_update_plane() which has an impact in msm_atomic_commit_tail() where the fallback branch
> > is taken.
> > 
> > The lag is solved with the patch below.
> > 
> > Best regards
> > - Erik Tagirov
> > 
> > The cursor plane must be used with the correct crtc to ensure an
> > asynchronous commit
> > ---
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> > index da3556eb6ecc..4e0e9c2d8062 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> > @@ -877,6 +877,9 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms *dpu_kms)
> >  			ret = PTR_ERR(crtc);
> >  			return ret;
> >  		}
> > +		/* Ensure that cursor planes are commited asynchronously */
> > +		if (cursor_planes[i])
> > +			cursor_planes[i]->possible_crtcs = drm_crtc_mask(crtc);
> 
> Here you are setting that the plane can only be used on a particular
> CRTC. This is not true for these planes (even being cursor, it still can
> be used on all the CRTCs).
> 
Thank you for the quick reply, I understand that the hardware supports
universal planes, so this is not a good solution.

I will see how I can solve this from userspace instead, need to look
more closely at the DRM API maybe there is another way to determine what
plane belongs to what CRTC.
The current implementation does not work, because the possible_crtcs is set to 0xff
and the compositor picks the cursor plane that comes first in the list which is used by crtc109 
instead of one used by crtc108. This why the legacy_cursor_update flag is not set in
drm_atomic_helper_update_plane()

BR
- Erik
> >  	}
> >  
> >  	/* All CRTCs are compatible with all encoders */
> > -- 
> > 2.49.0
> > 
> 
> -- 
> With best wishes
> Dmitry

      reply	other threads:[~2026-11-18 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 20:47 Erik Tagirov
2026-11-18 20:22 ` Dmitry Baryshkov
2026-11-18 21:24   ` Erik Tagirov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av4Xjn3duCXQ581K@gateway.normienet.tagirov.ch \
    --to=erik@tagirov.ch \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®