mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Satish Kharat <satishkh@cisco.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: Send reschedule IPIs instead of SMP function calls for non-waiting requests
Date: Wed, 18 Nov 2026 16:28:31 -0800	[thread overview]
Message-ID: <av5Crz-e2PaTNAjK@seanjc-mac.roam.internal> (raw)
In-Reply-To: <20261118211152.3430478-1-satishkh@cisco.com>

On Wed, Nov 18, 2026, Satish Kharat wrote:
> Hi Sean,
> 
> I tested this in place of my IRQ-bypass patch. The latter was reverted in
> the test source, and I loaded a kvm.ko built with your change against the
> running test kernel.
> 
> On an Intel UCS C220 M7, a four-vCPU guest used an ENIC VF through VFIO.
> With the other three vCPUs busy, reloading the guest VF driver traced
> vfio_msi_set_vector_signal() through vt_pi_start_bypass() to
> kvm_make_all_cpus_request() with local IRQs disabled. The trace then showed
> three reschedule IPIs from kvm_make_vcpu_request(), with no SMP function
> call in that callback and no warning. Posted-interrupt updates occurred.
> Three more VF reload cycles passed bidirectional traffic after VF traffic
> became ready.
> 
> On an Intel UCS C240 M6 with the same test kernel and patched kvm.ko,
> irqfd_test, irq_test, vmx_posted_intr_test and smptest passed. I restored
> the original KVM modules on both hosts after testing.
> 
> One source-review question: should the direct IPI path check
> cpu_online(cpu), as __kvm_vcpu_kick() does? The old batched helper filters
> offline CPUs, while x86 native_smp_send_reschedule() warns for one. A
> target vCPU could leave guest mode and its CPU could go offline between
> the request check and the IPI. I did not test CPU hotplug, and this would
> not imply a lost request.

Ugh, yeah, that WARN could be problematic.  Thanks much!

> Tested-by: Satish Kharat <satishkh@cisco.com>
> 

      reply	other threads:[~2026-11-19  0:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:54 Sean Christopherson
2026-11-18 21:11 ` Satish Kharat
2026-11-19  0:28   ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av5Crz-e2PaTNAjK@seanjc-mac.roam.internal \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=satishkh@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®