mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
	patches@kernelci.org, lkft-triage@lists.linaro.org,
	pavel@nabladev.com, jonathanh@nvidia.com, f.fainelli@gmail.com,
	sudipm.mukherjee@gmail.com, rwarsow@gmx.de, conor@kernel.org,
	hargar@microsoft.com, broonie@kernel.org, achill@achill.org,
	sr@sladewatkins.com, Aristo Chen <aristo.chen@canonical.com>,
	Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 6.12 0000/1756] 6.12.119-rc1 review
Date: Thu, 19 Nov 2026 11:48:16 +0900	[thread overview]
Message-ID: <av5jcETOfbV20DZS@codewreck.org> (raw)
In-Reply-To: <av5IKItmzhDUp-Zd@codewreck.org>

Dominique Martinet wrote on Thu, Nov 19, 2026 at 09:51:52AM +0900:
> Greg Kroah-Hartman wrote on Wed, Nov 18, 2026 at 03:35:27PM +0100:
> > Adam Ford <aford173@gmail.com>
> >     phy: freescale: fsl-samsung-hdmi: Fix 64-by-32 division cocci warnings
> >
> > Aristo Chen <aristo.chen@canonical.com>
> >     phy: freescale: fsl-samsung-hdmi: initialize default rate
> > 
> > Pei Xiao <xiaopei01@kylinos.cn>
> >     phy: freescale: fsl-samsung-hdmi: Use helper function devm_clk_get_enabled()
> > 
> > Adam Ford <aford173@gmail.com>
> >     phy: freescale: fsl-samsung-hdmi: Support dynamic integer
> > 
> > Adam Ford <aford173@gmail.com>
> >     phy: freescale: fsl-samsung-hdmi: Simplify REG21_PMS_S_MASK lookup
> > 
> > Adam Ford <aford173@gmail.com>
> >     phy: freescale: fsl-samsung-hdmi: Replace register defines with macro
> 
> I'm getting a boot failure around one of these on i.MX8MP:
> 
> 2026-11-19 09:01:29.454251 [    0.587255] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
> 2026-11-19 09:01:29.459125 [    0.596076] Mem abort info:
> 2026-11-19 09:01:29.460122 [    0.598879]   ESR = 0x0000000096000004
> 2026-11-19 09:01:29.465853 [    0.602641]   EC = 0x25: DABT (current EL), IL = 32 bits
> 2026-11-19 09:01:29.470643 [    0.607973]   SET = 0, FnV = 0
> 2026-11-19 09:01:29.471565 [    0.611036]   EA = 0, S1PTW = 0
> 2026-11-19 09:01:29.476941 [    0.614190]   FSC = 0x04: level 0 translation fault
> 2026-11-19 09:01:29.481849 [    0.619077] Data abort info:
> 2026-11-19 09:01:29.487329 [    0.621961]   ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000
> 2026-11-19 09:01:29.492669 [    0.627455]   CM = 0, WnR = 0, TnD = 0, TagAccess = 0
> 2026-11-19 09:01:29.498347 [    0.632518]   GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
> 2026-11-19 09:01:29.504076 [    0.637842] [0000000000000000] user address but active_mm is swapper
> 2026-11-19 09:01:29.509800 [    0.644207] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP
> 2026-11-19 09:01:29.510695 [    0.650479] Modules linked in:
> 2026-11-19 09:01:29.521321 [    0.653542] CPU: 2 UID: 0 PID: 12 Comm: kworker/u16:0 Not tainted 6.12.119-rc1-at0-g8f03b6a4b095 #43
> 2026-11-19 09:01:29.527214 [    0.662683] Hardware name: Atmark-Techno Armadillo-IoT Gateway G4 Board (DT)
> 2026-11-19 09:01:29.533048 [    0.669734] Workqueue: events_unbound deferred_probe_work_func
> 2026-11-19 09:01:29.542857 [    0.675584] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> 2026-11-19 09:01:29.544070 [    0.682548] pc : phy_clk_recalc_rate+0x4/0xc
> 2026-11-19 09:01:29.549398 [    0.686828] lr : __clk_register+0x4f0/0x8e0
> 2026-11-19 09:01:29.554271 [    0.691021] sp : ffff8000800bb9e0
> 2026-11-19 09:01:29.560182 [    0.694336] x29: ffff8000800bb9e0 x28: ffffa1893c634720 x27: ffff6d82c32ac080
> 2026-11-19 09:01:29.566395 [    0.701486] x26: 0000000000000000 x25: ffff6d82c32ac080 x24: 0000000000000001
> 2026-11-19 09:01:29.576245 [    0.708635] x23: ffff8000800bba88 x22: ffff6d82c32a16a0 x21: 0000000000000000
> 2026-11-19 09:01:29.582449 [    0.715784] x20: ffff6d82c20f8100 x19: ffff6d82c32a3800 x18: 0000000000000fdf
> 2026-11-19 09:01:29.588353 [    0.722932] x17: 0000000000000cf0 x16: 00000000000003fa x15: ffff6d82c214af10
> 2026-11-19 09:01:29.594281 [    0.730081] x14: 000000000000014d x13: ffff6d82c214af00 x12: 0000000000000000
> 2026-11-19 09:01:29.604441 [    0.737232] x11: 00000000000000c0 x10: 0000000000000000 x9 : 0000000000000000
> 2026-11-19 09:01:29.610325 [    0.744381] x8 : 0101010101010101 x7 : 0000000000000000 x6 : 8080808080808080
> 2026-11-19 09:01:29.616546 [    0.751528] x5 : ffff6d82c32ac080 x4 : 0000000000000000 x3 : ffff6d82c200a700
> 2026-11-19 09:01:29.622413 [    0.758677] x2 : ffffa1893b813740 x1 : 00000000016e3600 x0 : 0000000000000000
> 2026-11-19 09:01:29.627125 [    0.765829] Call trace:
> 2026-11-19 09:01:29.632409 [    0.768277]  phy_clk_recalc_rate+0x4/0xc
> 2026-11-19 09:01:29.633534 [    0.772208]  devm_clk_register+0x5c/0xbc
> 2026-11-19 09:01:29.638814 [    0.776137]  fsl_samsung_hdmi_phy_probe+0x1dc/0x310
> 2026-11-19 09:01:29.643768 [    0.781024]  platform_probe+0x68/0xdc
> 2026-11-19 09:01:29.644748 [    0.784693]  really_probe+0xbc/0x2bc
> 2026-11-19 09:01:29.650181 [    0.788278]  __driver_probe_device+0x80/0x14c
> 2026-11-19 09:01:29.655274 [    0.792643]  driver_probe_device+0x40/0x130
> 2026-11-19 09:01:29.660501 [    0.796831]  __device_attach_driver+0xb8/0x140
> 2026-11-19 09:01:29.665772 [    0.801282]  bus_for_each_drv+0x88/0xe8
> 2026-11-19 09:01:29.666809 [    0.805125]  __device_attach+0x9c/0x19c
> 2026-11-19 09:01:29.671945 [    0.808966]  device_initial_probe+0x54/0x74
> 2026-11-19 09:01:29.677003 [    0.813155]  __bus_probe_device+0x34/0xa0
> 2026-11-19 09:01:29.678308 [    0.817171]  bus_probe_device_deferred+0x2c/0x78
> 2026-11-19 09:01:29.683731 [    0.821795]  deferred_probe_work_func+0x7c/0xb4
> 2026-11-19 09:01:29.688826 [    0.826335]  process_one_work+0x164/0x2bc
> 2026-11-19 09:01:29.693854 [    0.830355]  worker_thread+0x180/0x2f4
> 2026-11-19 09:01:29.694736 [    0.834109]  kthread+0x110/0x114
> 2026-11-19 09:01:29.699938 [    0.837345]  ret_from_fork+0x10/0x20
> 2026-11-19 09:01:29.705576 [    0.840932] Code: d503201f d503201f d503201f f9400c00 (b9400000) 
> 2026-11-19 09:01:29.709069 [    0.847029] ---[ end trace 0000000000000000 ]---
> 
> I need to check further where the problem is exactly, will reply to this
> mail again in a couple of hours as I'm not sure I can recover the board
> remotely to check right now

Ok, I boot after reverting commit a8210490583e ("phy: freescale:
fsl-samsung-hdmi: initialize default rate")

That commit removed the fallback if (!phy->cur_cfg), which probably
works for master (didn't test), but doesn't work on 6.12 likely because
it doesn't have commit 41db46233467 ("phy: freescale: fsl-samsung-hdmi:
Refactor finding PHY settings") - as far as I can see that commit
ensures cur_cfg is always set early on.

Unfortunately it's not trivial to cherry-pick, picking these two in
order results in a relatively minor conflict in the Refactor patch we
want:
058ea4a06704 ("phy: freescale: fsl-samsung-hdmi: Use closest divider")
41db46233467 ("phy: freescale: fsl-samsung-hdmi: Refactor finding PHY settings")

And I've checked the oops no longer reproduce with these two, keeping
a8210490583e ("phy: freescale: fsl-samsung-hdmi: initialize default
rate") as is.

If it helps I can send the patches as I resolved, but it's probably
easier to drop for this time?


Thanks,
-- 
Dominique Martinet | Asmadeus

      reply	other threads:[~2026-11-19  2:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:35 Greg Kroah-Hartman
2026-11-18 16:58 ` Brett A C Sheffield
2026-11-18 17:10 ` Pavel Machek
2026-11-18 19:49 ` Florian Fainelli
2026-11-19  0:51 ` Peter Schneider
2026-11-19  0:51 ` Dominique Martinet
2026-11-19  2:48   ` Dominique Martinet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av5jcETOfbV20DZS@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=achill@achill.org \
    --cc=akpm@linux-foundation.org \
    --cc=aristo.chen@canonical.com \
    --cc=broonie@kernel.org \
    --cc=conor@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hargar@microsoft.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkft-triage@lists.linaro.org \
    --cc=patches@kernelci.org \
    --cc=patches@lists.linux.dev \
    --cc=pavel@nabladev.com \
    --cc=rwarsow@gmx.de \
    --cc=shuah@kernel.org \
    --cc=sr@sladewatkins.com \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®