From: Liviu Dudau <liviu.dudau@arm.com>
To: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Daniel Almeida <daniel.almeida@collabora.com>,
Alice Ryhl <aliceryhl@google.com>,
Lukas Zapolskas <lukas.zapolskas@arm.com>,
Paul Toadere <paul.toadere@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org,
Christian Gmeiner <cgmeiner@igalia.com>
Subject: Re: [PATCH v2 0/3] drm/panthor: Report fault information to userspace
Date: Thu, 19 Nov 2026 11:10:15 +0000 [thread overview]
Message-ID: <av7ZFwXVChENRVcd@e142607> (raw)
In-Reply-To: <20261104-panthor-fault-info-v2-v2-0-673b31f3840c@igalia.com>
On Wed, Nov 04, 2026 at 08:52:38AM +0100, Christian Gmeiner wrote:
> The Panthor CSF firmware and hardware report extra information when a
> fault happens. Two kinds of faults matter here:
> * faults raised at the address space level. These are fatal for every
> group bound to that VM.
> * fatal faults raised on one of the queues of a group. They stop
> further submissions on that group.
>
> This series exposes that information to userspace, so the
> VK_KHR_device_fault extension can be implemented on top of it.
>
> VM faults are reported through VM_GET_STATE. The VM keeps the raw
> AS_FAULTSTATUS and AS_FAULTADDRESS of its last fault. Queue fatal
> errors are reported through GROUP_GET_STATE. Each queue keeps its raw
> CS_FATAL and CS_FATAL_INFO, and the ioctl returns them in an array
> indexed by queue. The kernel does not decode the values, userspace
> does. Nothing is allocated in the fault paths.
>
> Changes in v2:
> - Report VM faults through VM_GET_STATE instead of copying them into
> every group bound to the VM.
> - Pass the raw register values to userspace instead of decoded fields.
> - Keep one fatal slot per queue. A queue stops at its first fatal
> error, so no allocation is needed.
> - Store the uAPI structs directly in the kernel objects.
> - Dropped the recoverable CS_FAULT reporting for now.
> - Bump the driver version to 1.10 in a separate patch.
> - Rebased on drm-misc-next. The queue fatal info is protected by
> events_lock now that fatal events are processed under it.
>
> Link to v1: https://lore.kernel.org/r/20251215115457.2137485-1-lukas.zapolskas@arm.com
>
> Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
> ---
> Christian Gmeiner (3):
> drm/panthor: Report the last VM fault through VM_GET_STATE
> drm/panthor: Report the CS fatal errors through GROUP_GET_STATE
> drm/panthor: Bump the driver version to 1.10
>
> drivers/gpu/drm/panthor/panthor_drv.c | 26 +++++++++++++++--
> drivers/gpu/drm/panthor/panthor_mmu.c | 33 +++++++++++++++++++--
> drivers/gpu/drm/panthor/panthor_mmu.h | 2 ++
> drivers/gpu/drm/panthor/panthor_sched.c | 32 +++++++++++++++++++-
> drivers/gpu/drm/panthor/panthor_sched.h | 5 +++-
> include/uapi/drm/panthor_drm.h | 52 +++++++++++++++++++++++++++++++++
> 6 files changed, 143 insertions(+), 7 deletions(-)
> ---
> base-commit: 6f7098738fff3ec7393f924343188cb8e6ebc5d2
> change-id: 20261014-panthor-fault-info-v2-330a9f771fd3
>
> Best regards,
> --
> Christian Gmeiner <cgmeiner@igalia.com>
>
Sorry for the delay!
For the whole series:
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
prev parent reply other threads:[~2026-11-19 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:52 Christian Gmeiner
2026-11-04 7:52 ` [PATCH v2 1/3] drm/panthor: Report the last VM fault through VM_GET_STATE Christian Gmeiner
2026-11-19 8:50 ` Boris Brezillon
2026-11-04 7:52 ` [PATCH v2 2/3] drm/panthor: Report the CS fatal errors through GROUP_GET_STATE Christian Gmeiner
2026-11-19 8:48 ` Boris Brezillon
2026-11-04 7:52 ` [PATCH v2 3/3] drm/panthor: Bump the driver version to 1.10 Christian Gmeiner
2026-11-19 8:51 ` Boris Brezillon
2026-11-19 11:10 ` Liviu Dudau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7ZFwXVChENRVcd@e142607 \
--to=liviu.dudau@arm.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=boris.brezillon@collabora.com \
--cc=cgmeiner@igalia.com \
--cc=christian.gmeiner@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.zapolskas@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=paul.toadere@arm.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®