mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "andriy.shevchenko@intel.com" <andriy.shevchenko@intel.com>
To: "Habil Eren Türker" <habilerenturker@hotmail.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"habilerturker@hotmail.com" <habilerturker@hotmail.com>,
	"helgaas@kernel.org" <helgaas@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/quirks: Cast PCI_D0 to u16 in apple_airport_reset()
Date: Thu, 19 Nov 2026 13:41:36 +0200	[thread overview]
Message-ID: <av7gcEykk-Sp2V8n@ashevche-desk.local> (raw)
In-Reply-To: <20261119112124.6442-1-habilerenturker@hotmail.com>

On Thu, Nov 19, 2026 at 11:21:25AM +0000, Habil Eren Türker wrote:
> Thank you both for the feedback. I agree that helper functions are a much
> better approach than spreading (__force u16) casts throughout the code.
> 
> These are the main types of warnings (roughly 30 in total) in
> drivers/pci, run with `make C=2 drivers/pci/`:
> 
> - warning: restricted pci_power_t degrades to integer (~25 instances)
> - warning: incorrect type in assignment (different base types)
>    (~4 instances)
> - warning: invalid assignment: |= (~3 instances)
> 
> The four helpers pci_power_t_get(), pci_power_t_set(), pci_power_eq()
> and pci_power_gt() would cover all three groups.

For the completeness the _lt() also needed, with that we will cover all
<, >, <=, and >=.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-11-19 11:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 16:16 Habil Eren Türker
2026-11-18 18:14 ` Bjorn Helgaas
2026-11-19  9:04   ` Andy Shevchenko
2026-11-19 11:21     ` Habil Eren Türker
2026-11-19 11:41       ` andriy.shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7gcEykk-Sp2V8n@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=habilerenturker@hotmail.com \
    --cc=habilerturker@hotmail.com \
    --cc=helgaas@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®