From: Jarkko Sakkinen <jarkko@kernel.org>
To: shyckless@gmail.com
Cc: jgg@ziepe.ca, linux-kernel@vger.kernel.org, jgross@suse.com,
sstabellini@kernel.org, linux-integrity@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] tpm: xen-tpmfront: fix use-after-free in backend_changed()
Date: Thu, 19 Nov 2026 17:20:15 +0200 [thread overview]
Message-ID: <av8Tr2jTQaOBOEid@kernel.org> (raw)
In-Reply-To: <20261119-xen-tpmfront-v1-1-bfabbbed462a@gmail.com>
On Thu, Nov 19, 2026 at 11:20:33AM +0000, Suyuan Wang via B4 Relay wrote:
> From: Suyuan Wang <stevewong@hust.edu.cn>
>
> When the backend moves to Closing or Closed, backend_changed()
> unregisters the device and then keeps using it:
>
> device_unregister(&dev->dev);
> xenbus_frontend_closed(dev);
>
> The xenbus watch callback that calls backend_changed() does not hold a
> reference to the device. The tpm_chip registered by xen-tpmfront has dev
> as its parent and holds a reference to it, but tpmfront_remove() drops
> that reference when it unregisters the chip. So device_unregister() can
> release the last reference and free the xenbus_device, and
> xenbus_frontend_closed(dev) then accesses freed memory.
>
> Take a temporary reference before unregistering and drop it after
> xenbus_frontend_closed(). This keeps dev alive for the last access and
> keeps the existing order, in which TPM operations are stopped before
> the frontend is marked Closed.
>
> Found with a static analysis tool and checked by hand.
>
> Fixes: e2683957fb26 ("drivers/tpm: add xen tpmfront interface")
> Cc: stable@vger.kernel.org
> Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
> ---
> Compile tested on x86_64 (W=1, no new warnings). Not run with a Xen vTPM
> backend.
> ---
> drivers/char/tpm/xen-tpmfront.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 3c0cce57c4ae..1be925cca535 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -397,8 +397,11 @@ static void backend_changed(struct xenbus_device *dev,
>
> case XenbusStateClosing:
> case XenbusStateClosed:
> + /* device_unregister() can drop the last reference to dev */
> + get_device(&dev->dev);
> device_unregister(&dev->dev);
> xenbus_frontend_closed(dev);
> + put_device(&dev->dev);
Not a NAK but makes me wonder why this has not hit the wall ever.
I.e. "feeling confused".
> break;
> default:
> break;
>
>
>
>
Br, Jarkko
next prev parent reply other threads:[~2026-11-19 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 11:20 Suyuan Wang via B4 Relay
2026-11-19 15:20 ` Jarkko Sakkinen [this message]
2026-11-19 15:35 ` Jürgen Groß
2026-11-19 16:30 ` Jarkko Sakkinen
2026-11-19 16:32 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8Tr2jTQaOBOEid@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shyckless@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®