mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: nord: Fix GPI DMA wiring of QUP SPI engines
Date: Thu, 19 Nov 2026 16:30:41 +0100	[thread overview]
Message-ID: <av8WIZjPgnS8qWNt@QCOM-aGQu4IUr3Y.na.qualcomm.com> (raw)
In-Reply-To: <5poepxkppbiyfxz2dxkjm7p7xiq4ndoltsnnbqlp5rdasbvrxr@p2ocx5b3kubj>

On Thu, Nov 19, 2026 at 03:04:11PM +0100, Bartosz Golaszewski wrote:
> On Wed, Nov 18, 2026 at 12:24:07PM +0100, Shawn Guo wrote:
> > Commit d8005dd04efc ("arm64: dts: qcom: nord: wire up GPI DMA for QUP
> > I2C/SPI engines") put the QCOM_GPI_SPI channels of SE 0-3, 7, 8, 11
> > and 12 into the uartN nodes instead of their spiN siblings, and left
> > spi4 and spi14..spi19 without any. The UART nodes now carry dmas
> > properties the GENI UART binding doesn't allow, and 15 of 18 SPI
> > engines can't use GPI DMA.
> > 
> > Move the channels from the UART nodes to the SPI nodes, and add the
> > missing ones for spi4 and spi14..spi19.
> > 
> > Fixes: d8005dd04efc ("arm64: dts: qcom: nord: wire up GPI DMA for QUP I2C/SPI engines")
> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> > ---
> 
> Eek! Thanks. I think the comment from sashiko needs to be addresed
> though.

I think sashiko got confused, no?

Shawn

      reply	other threads:[~2026-11-19 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 11:24 Shawn Guo
2026-11-19 14:04 ` Bartosz Golaszewski
2026-11-19 15:30   ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av8WIZjPgnS8qWNt@QCOM-aGQu4IUr3Y.na.qualcomm.com \
    --to=shengchao.guo@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®