From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795106701; b=K6Bba4EjtppB3tpU2YsRIkqQwe2LBYh82WFJKU8ayqwsrAaufAXv6TptF14LuGGH3ccH nQlFkciifv0GG1Lje8F9+tiAUp2JI4TT1YKlrHA04t/UEVJTRxTuQ/pwgr8Zh25T2jwe0 GxlwsaIEMIm4hxFft+t5huCy8xj5pJ9uHOiMiPwULSqfVnUVRwzo/33sOnoyAYkkJc5S1 0IhI+movzyy7VQZrmFjE4AkmNac9ULsmjztogJ8tZC1dxEs+paFBkWPKlKUrQmEQkVpZu 7P3Fl3nRvVvzdRzia7VlYB8mtSbOE+vtXeR/iAy9j/FmxyiRJMKzhQIBZVIZjuPtiTA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795106701; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=J2K05ih4wGBAK3pt5nK5wgIDHef2c+4NlLu8emj0KCg=; b=ol0k6y14kymZbYmftxP4M43ucaseeca2wbt3KHtjnQ0uxnt5DVG8T8Jtc+G+GaTQTTUC OIRjdkL0nuQNpPc8Qh+fsUm2156wte9Wk+6NkAwdlAMHktiMk/u1N5Haymu/3/AHC/AkG HtClKT5uF1uZ1xIjjoRQr07AyyxkAp/WEGIiCT2X5WZ3J4JDgmIdFLv4HlO8JZcXIjcPI 6VpZ7xWltpsidI9dqla+9KxzHk+4yMztbG8ASZ7ly8F+/WilvJc79qHBM3I45zfG2h/M9 Qn6tQMfkNfHWo6M7gewgziAInTd3BO1ysRR+xITJJ1Ff4v5x+56tkPRHHNyGvlNlp4w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZEzG5oHZ; arc=none smtp.remote-ip=209.85.215.171 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4579606A335 for ; Thu, 19 Nov 2026 16:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C4579606A335 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ZEzG5oHZ Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cdab8873d9dso1476646a12.1 for ; Thu, 19 Nov 2026 08:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1795106700; x=1795711500; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=J2K05ih4wGBAK3pt5nK5wgIDHef2c+4NlLu8emj0KCg=; b=ZEzG5oHZXxpB8oa9rwNRv50HM5CC3bkeHTb4Mqa8N0kfcPCFI7ndYnYkPsZQTx2UkU 8AYW1pftII73bkzkj8Mljub2ZKGXw7Dd5s5mOI+xuV7wKkJeqGvuGDOSlEU4FqAJy3KQ ss3b9CZopEfOuKeZKkILe32GZeHxS96Put/wKCT9M8mjyHUJ1Ym+PFHC3tPv9J9ruNuo TPJZdt9dZW3R+K8v70phsHoTTO9pY+zpKE3NZsByk1wF0/LQEtil7BJjoWObI7wIPpDV UjaAPnUR81MQnLYqklptBdBDRsuBmhzmSvrfeKAqr4JYEYzjVQiLrk/7O8+6/U4qYFeT 5iqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795106700; x=1795711500; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=J2K05ih4wGBAK3pt5nK5wgIDHef2c+4NlLu8emj0KCg=; b=S7H6BFVvhOCDoWjSoYb9qnI/crS6FlKUWXfcokXN+atNdxHGkK+Hf6qHN7tTnSdumH twDv/UUnpq6I8tqV/zycyjwFI3krZsA0qlOGkMpH+IMojyVxsAXRQ9PLO/gZKYJua/dz qiGomHyFRB7zEtPMA5rm35GLGfgZgVRa5FoFTw2agGMYQGPZjdPMjiiviTaotkkPfBkK kSPKAem4zH0W5HKbQFNaqh3V4McOJrNYYcTOFfYoUx1Xau8RKTQ3Pm/PNFHRYJduB6lL yVicmis6myZG5pbk8jfe+a2C2o/e1HmzXNCAah8Rs8eCu9rC6CfZSLjBmZf4WG+lwgRn hiDQ== X-Forwarded-Encrypted: i=1; AL+hErGbhueRXXMDTVoEHlj9h8nTuWkax8kW1DW9X+8JpypWsOZdLHYUzFYnicKeE5ln+fIxt64//OBa/82DHII=@vger.kernel.org X-Gm-Message-State: APuU4Z+zO83tdYoZJ28LlmBF/h8K2ZwfBXKYoyPbo3gjUgQKGht48aNh 9+mVq61yNCrSt+UCiLsdfFQO7Jco0nB44elU24U51QcP9ACDYneSYzhiwIEzqeX+iIc= X-Gm-Gg: AZFdTZfa3PSvRlBsiQrQ2Vt7Fasf3kABBcb4N5W8HJ/KDR5UIGTzR8GIAvhuNgtqLln v+bqX4Vwc2hHq6xDuwaS4w/oAyqJXq/Y0mZi+xlj9bgkLKVaNFL8DxUngGXfO9Q/Z7G1j9JbE5M pbxora/sJ2HeWOObGRr3g67yRtK49w5pmh+ID6RXDHbb4p8mbaYhN+1EOHuzm+I6DYRLQDAyEyB yc8MtmS1NoBHE6QkMAM+34w0h/Yj9HB7gtjx/6GdmbXGepwDqgpD/0qYugyw2SDf7U9knWjC1m6 nS5aYuSkprJCG4woGIilNeq9nHHJMcgLWOzzy4fMDi4uWhg8l4asre3d0STWTCbRfs8PF+4XAGu dvc6BbJUGZCEMWdCXHJWu0XvuVtuMmig9SZufEf84aN/GnQ46D72Vr3JB3NM/jh30j0T3zQwzcy E92VkXXyYujqSx1Qq7JUs5/aoJTSzURs2y+Ay+sCfmJqBjw20p/y9gsvuWZnv8MRO5CjHausftG 9vrcJVMfT3yfjovV1x9A8p6/Tqp0xQMGbs68qYfBOSn4diHtrLXqodK1COaXtlrHzoHlVKj7uMG igBRRe5wDlXLWs7CvM24T22PL2ULLnELEOE6SQZVb7Nwp+6YG8dexw== X-Received: by 2002:a17:90b:3c83:b0:3aa:f4af:1e16 with SMTP id 98e67ed59e1d1-3b3d06a2564mr6512769a91.7.1795106699866; Thu, 19 Nov 2026 08:44:59 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:9bd7:226d:1022:f6ef]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b405ecb486sm3203028a91.16.2026.11.19.08.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2026 08:44:59 -0800 (PST) Date: Thu, 19 Nov 2026 10:44:56 -0600 From: Mathieu Poirier To: Ben Levinsky Cc: jassisinghbrar@gmail.com, andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, michal.simek@amd.com, tanmay.shah@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] remoteproc: amd_mbv_bram: Restore reset GPIO direction after PL reconfig Message-ID: References: <20261105051902.1646651-1-ben.levinsky@amd.com> <20261105051902.1646651-3-ben.levinsky@amd.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105051902.1646651-3-ben.levinsky@amd.com> On Wed, Nov 04, 2026 at 09:18:58PM -0800, Ben Levinsky wrote: > Partial reconfiguration of the programmable logic restores the AXI GPIO > that drives the soft-core reset to its hardware default direction, but > gpiolib keeps its cached output direction. gpiod_set_value_cansleep() > then only updates the data register, so the processor never sees a > reset transition: remoteproc reports it as running while the newly > loaded firmware never starts. > Where does the "partial reconfiguration of the programmable logic" happens? What makes it partial? Shouldn't that be fixed instead? > Use gpiod_direction_output() for every reset transition so the output > direction is re-established, and assert reset briefly before releasing > it so each start produces a clean reset pulse after the firmware has > been loaded. > > Fixes: f87b4998994e ("remoteproc: Add AMD MicroBlaze/V BRAM-based remote processor driver") > Assisted-by: Claude:claude-opus-5.5 > Signed-off-by: Ben Levinsky > --- > drivers/remoteproc/amd_mbv_bram_rproc.c | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/drivers/remoteproc/amd_mbv_bram_rproc.c b/drivers/remoteproc/amd_mbv_bram_rproc.c > index 6cf33c7b7e64..da621f62f7df 100644 > --- a/drivers/remoteproc/amd_mbv_bram_rproc.c > +++ b/drivers/remoteproc/amd_mbv_bram_rproc.c > @@ -16,6 +16,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -94,8 +95,24 @@ static int amd_bram_rproc_start(struct rproc *rproc) > return ret; > } > > + /* > + * Partial reconfiguration restores the PL GPIO hardware defaults but > + * leaves gpiolib's cached direction unchanged. Re-establish the output > + * direction and generate a reset pulse after firmware has been loaded. > + * gpiod_set_value_cansleep() is insufficient here because it changes the > + * value without restoring an output direction lost during DFX. > + */ > + ret = gpiod_direction_output(priv->reset, 1); > + if (ret) { > + dev_err(priv->dev, "failed to assert reset: %d\n", ret); > + clk_disable_unprepare(priv->clk); > + return ret; > + } Why is this needed now rather than when this driver was introduced? > + /* Hold reset asserted long enough to provide a clean reset pulse. */ > + usleep_range(10, 20); > + I really don't like random wait times, please find another way like polling the GPIO line for an expected value. I also thougth the GPIO subsystem was already dealing with de-bouncing. And the question from above still stands, i.e what changed to required sleeping that wasn't there when this driver was first submitted? > /* Deassert reset and let the processor run. */ > - ret = gpiod_set_value_cansleep(priv->reset, 0); > + ret = gpiod_direction_output(priv->reset, 0); > if (ret) { > dev_err(priv->dev, "failed to deassert reset: %d\n", ret); > clk_disable_unprepare(priv->clk); > @@ -110,8 +127,8 @@ static int amd_bram_rproc_stop(struct rproc *rproc) > struct amd_bram_rproc *priv = rproc->priv; > int ret; > > - /* Assert reset before disabling the processor clock. */ > - ret = gpiod_set_value_cansleep(priv->reset, 1); > + /* Restore the output direction after DFX and assert reset. */ > + ret = gpiod_direction_output(priv->reset, 1); > if (ret) { > dev_err(priv->dev, "failed to assert reset: %d\n", ret); > return ret; > -- > 2.34.1 >