From: Andi Shyti <andi.shyti@kernel.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Haoxiang Li <haoxiang_li2024@163.com>,
airlied@gmail.com, jani.nikula@linux.intel.com,
rodrigo.vivi@intel.com, simona@ffwll.ch, tursulin@ursulin.net,
intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/vma: Fix a memory leak in i915_vma_pin_ww()
Date: Thu, 19 Nov 2026 23:04:34 +0100 [thread overview]
Message-ID: <av9xxr03wFlfWwhv@zenone.zhora.eu> (raw)
In-Reply-To: <179507544606.16202.12430112951192190652@jlahtine-mobl>
Hi Joonas,
On Thu, Nov 19, 2026 at 10:04:06AM +0200, Joonas Lahtinen wrote:
> Quoting Haoxiang Li (2026-11-18 17:32:05)
> > i915_vma_pin_ww() allocates bind work before retrieving the object's
> > moving fence. If the lookup fails, it jumps to err_rpm, bypassing the
> > fence commit at err_fence and leaking the work allocation.
> >
> > Jump to err_fence instead so the fence callbacks can release the work.
> >
> > Fixes: 8ec5c0006c50 ("Merge tag 'drm-intel-next-2022-05-20' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-gt-next")
> > Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
>
> You seem to be spamming the different kernel subsystems with patches and
> never respond to any feedback, so if you could just stop and do something
> else.
The patch is correct, though, and I'd take it.
If Haoxiang is not responding to other patches then bad for him
and I'd give the same suggestion as you did. But if we are not
taking this patch, then we would remain with a clear known
liability in our code.
Andi
next prev parent reply other threads:[~2026-11-19 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:32 Haoxiang Li
2026-11-19 8:04 ` Joonas Lahtinen
2026-11-19 9:58 ` Haoxiang Li
2026-11-19 22:04 ` Andi Shyti [this message]
2026-11-19 22:08 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av9xxr03wFlfWwhv@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haoxiang_li2024@163.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®