From: Bjorn Andersson <andersson@kernel.org>
To: george.moussalem@outlook.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 3/8] arm64: dts: qcom: ipq5424: Flatten usb controller nodes
Date: Sun, 8 Nov 2026 13:18:33 -0600 [thread overview]
Message-ID: <avDKwE7XQb7bVqwr@zenbook> (raw)
In-Reply-To: <20261001-ipq-flatten-usb-v4-3-486a4d5ede30@outlook.com>
On Thu, Oct 01, 2026 at 11:53:46AM +0400, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> Flatten usb controller nodes and update to using latest bindings and
> flattened driver approach.
Computer says:
+ arch/arm64/boot/dts/qcom/ipq5424-rdp466.dtb: usb2@1e00000 (qcom,ipq5424-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
+ arch/arm64/boot/dts/qcom/ipq5424-rdp466.dtb: usb3@8a00000 (qcom,ipq5424-dwc3): interrupt-names:4: 'dm_hs_phy_irq' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
Did you run "make dtbs_check" on this, or am I missing something?
The other changes in the series seems to pass.
Regards,
Bjorn
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 12 ++--
> arch/arm64/boot/dts/qcom/ipq5424.dtsi | 86 +++++++++++++----------------
> 2 files changed, 41 insertions(+), 57 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> index 793afc3ee82e..0c3370dba65b 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> @@ -74,14 +74,6 @@ vreg_misc_0p925: regulator-usb-0p925 {
> };
> };
>
> -&dwc_0 {
> - dr_mode = "host";
> -};
> -
> -&dwc_1 {
> - dr_mode = "host";
> -};
> -
> &pcie2 {
> pinctrl-0 = <&pcie2_default_state>;
> pinctrl-names = "default";
> @@ -284,10 +276,14 @@ &uart1 {
> };
>
> &usb2 {
> + dr_mode = "host";
> +
> status = "okay";
> };
>
> &usb3 {
> + dr_mode = "host";
> +
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> index 23f851e9241f..b1bfe31227e7 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
> @@ -640,12 +640,9 @@ qusb_phy_1: phy@71000 {
> status = "disabled";
> };
>
> - usb2: usb2@1ef8800 {
> - compatible = "qcom,ipq5424-dwc3", "qcom,dwc3";
> - reg = <0 0x01ef8800 0 0x400>;
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges;
> + usb2: usb2@1e00000 {
> + compatible = "qcom,ipq5424-dwc3", "qcom,snps-dwc3";
> + reg = <0 0x01e00000 0 0xfc100>;
>
> clocks = <&gcc GCC_USB1_MASTER_CLK>,
> <&gcc GCC_USB1_SLEEP_CLK>,
> @@ -664,33 +661,31 @@ usb2: usb2@1ef8800 {
> assigned-clock-rates = <200000000>,
> <24000000>;
>
> - interrupts-extended = <&intc GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>,
> + interrupts-extended = <&intc GIC_SPI 396 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 397 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 387 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 388 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "pwr_event",
> + interrupt-names = "dwc_usb3",
> + "pwr_event",
> "qusb2_phy",
> "dm_hs_phy_irq",
> "dp_hs_phy_irq";
>
> resets = <&gcc GCC_USB1_BCR>;
> +
> + phys = <&qusb_phy_1>;
> + phy-names = "usb2-phy";
> +
> qcom,select-utmi-as-pipe-clk;
> - status = "disabled";
>
> - dwc_1: usb@1e00000 {
> - compatible = "snps,dwc3";
> - reg = <0 0x01e00000 0 0xe000>;
> - clocks = <&gcc GCC_USB1_MOCK_UTMI_CLK>;
> - clock-names = "ref";
> - interrupts = <GIC_SPI 396 IRQ_TYPE_LEVEL_HIGH>;
> - phys = <&qusb_phy_1>;
> - phy-names = "usb2-phy";
> - tx-fifo-resize;
> - snps,is-utmi-l1-suspend;
> - snps,hird-threshold = /bits/ 8 <0x0>;
> - snps,dis_u2_susphy_quirk;
> - snps,dis_u3_susphy_quirk;
> - };
> + tx-fifo-resize;
> + snps,is-utmi-l1-suspend;
> + snps,hird-threshold = /bits/ 8 <0x0>;
> + snps,dis_u2_susphy_quirk;
> + snps,dis_u3_susphy_quirk;
> +
> + status = "disabled";
> };
>
> qusb_phy_0: phy@7b000 {
> @@ -746,13 +741,9 @@ restart_reason: restartreason-sram@7b0 {
> };
> };
>
> - usb3: usb3@8af8800 {
> - compatible = "qcom,ipq5424-dwc3", "qcom,dwc3";
> - reg = <0 0x08af8800 0 0x400>;
> -
> - #address-cells = <2>;
> - #size-cells = <2>;
> - ranges;
> + usb3: usb3@8a00000 {
> + compatible = "qcom,ipq5424-dwc3", "qcom,snps-dwc3";
> + reg = <0 0x08a00000 0 0xfc100>;
>
> clocks = <&gcc GCC_USB0_MASTER_CLK>,
> <&gcc GCC_USB0_SLEEP_CLK>,
> @@ -771,34 +762,31 @@ usb3: usb3@8af8800 {
> assigned-clock-rates = <200000000>,
> <24000000>;
>
> - interrupts-extended = <&intc GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>,
> + interrupts-extended = <&intc GIC_SPI 409 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "pwr_event",
> + interrupt-names = "dwc_usb3",
> + "pwr_event",
> "qusb2_phy",
> "dm_hs_phy_irq",
> "dp_hs_phy_irq";
>
> resets = <&gcc GCC_USB_BCR>;
> - status = "disabled";
>
> - dwc_0: usb@8a00000 {
> - compatible = "snps,dwc3";
> - reg = <0 0x08a00000 0 0xcd00>;
> - clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>;
> - clock-names = "ref";
> - interrupts = <GIC_SPI 409 IRQ_TYPE_LEVEL_HIGH>;
> - phys = <&qusb_phy_0>, <&ssphy_0>;
> - phy-names = "usb2-phy", "usb3-phy";
> - tx-fifo-resize;
> - snps,is-utmi-l1-suspend;
> - snps,hird-threshold = /bits/ 8 <0x0>;
> - snps,dis_u2_susphy_quirk;
> - snps,dis_u3_susphy_quirk;
> - snps,dis-u1-entry-quirk;
> - snps,dis-u2-entry-quirk;
> - };
> + phys = <&qusb_phy_0>, <&ssphy_0>;
> + phy-names = "usb2-phy", "usb3-phy";
> +
> + tx-fifo-resize;
> + snps,is-utmi-l1-suspend;
> + snps,hird-threshold = /bits/ 8 <0x0>;
> + snps,dis_u2_susphy_quirk;
> + snps,dis_u3_susphy_quirk;
> + snps,dis-u1-entry-quirk;
> + snps,dis-u2-entry-quirk;
> +
> + status = "disabled";
> };
>
> timer@f420000 {
>
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-11-08 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 7:53 [PATCH v4 0/8] Flatten USB Controller Nodes on IPQ SoCs George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 1/8] arm64: dts: qcom: ipq5018: Flatten usb controller node George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 2/8] arm64: dts: qcom: ipq5332: " George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 3/8] arm64: dts: qcom: ipq5424: Flatten usb controller nodes George Moussalem via B4 Relay
2026-11-08 19:18 ` Bjorn Andersson [this message]
2026-10-01 7:53 ` [PATCH v4 4/8] arm64: dts: qcom: ipq6018: move DR mode to board DTS George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 5/8] arm64: dts: qcom: ipq6018: Flatten usb controller nodes George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 6/8] arm64: dts: qcom: ipq8074: move DR mode to board DTS George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 7/8] arm64: dts: qcom: ipq8074: Flatten usb controller nodes George Moussalem via B4 Relay
2026-10-01 7:53 ` [PATCH v4 8/8] arm64: dts: qcom: ipq9574: Flatten usb controller node George Moussalem via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avDKwE7XQb7bVqwr@zenbook \
--to=andersson@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.moussalem@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®