mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gary Yang <gary.yang@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Fugang Duan <fugang.duan@cixtech.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH 4/4] arm64: dts: cix: add RTS5453 PD controllers to Orion O6
Date: Mon, 9 Nov 2026 10:07:58 +0800	[thread overview]
Message-ID: <avEq_ngShxlvFSbS@gary-System-Product-Name> (raw)
In-Reply-To: <65af581e-caac-430a-88b1-3b7425c5209e@kernel.org>

hi Krzysztof:

Thanks for your comments!

On 2026-11-07 11:53, Krzysztof Kozlowski wrote:

> EXTERNAL EMAIL
> 
> On 07/11/2026 02:10, Gary Yang wrote:
> > Describe the two Realtek RTS5453H port controllers on the Orion O6
> > I2C1 bus and add the I2C1 pin configuration.
> >
> > The controllers route orientation and DisplayPort mode changes
> > through the USB/DP combo PHY lane switches, but that PHY support is
> > not upstream yet, so the connector graph endpoints are left out for
> > now. The Type-C ports are still registered and reported, only the
> > lane switching is deferred until the PHY nodes are available.
> >
> > Both controllers report through the same level-triggered interrupt
> > line, which the driver handles with a shared interrupt. The I2C bus
> > runs at 100 kHz because the RTS5453H I2C interface does not support
> > higher rates.
> >
> > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > ---
> >  arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 51 +++++++++++++++++++++++
> >  1 file changed, 51 insertions(+)
> 
> DTS cannot be combined in this patchset and must be split. Don't mix
> patches from independent subsystems when you send something explicitly
> targeting only one subsystem.
> See also: Documentation/devicetree/bindings/submitting-patches.rst
> 

Do you mean the driver does not depend on DTS? Previously, it was acceptable
to put the DTS at the end of a patchset or place the DTS in a separate patchset. 
That’s why I put the DTS at the end of the patchset. Has the rule changed now?

Best Regards,
Gary
> 
> Best regards,
> Krzysztof

      reply	other threads:[~2026-11-09  2:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  1:10 [PATCH 0/4] usb: typec: add CIX Type-C PD controller driver Gary Yang
2026-11-07  1:10 ` [PATCH 1/4] dt-bindings: usb: add Realtek RTS5453H Type-C port controller Gary Yang
2026-11-07 10:54   ` Krzysztof Kozlowski
2026-11-07  1:10 ` [PATCH 2/4] usb: typec: add CIX Type-C PD controller driver Gary Yang
2026-11-07 10:56   ` Krzysztof Kozlowski
2026-11-07 13:11   ` kernel test robot
2026-11-07 18:05   ` kernel test robot
2026-11-07  1:10 ` [PATCH 3/4] arm64: dts: cix: fix I2C bus address and size cells on Sky1 Gary Yang
2026-11-07 10:53   ` Krzysztof Kozlowski
2026-11-07  1:10 ` [PATCH 4/4] arm64: dts: cix: add RTS5453 PD controllers to Orion O6 Gary Yang
2026-11-07 10:53   ` Krzysztof Kozlowski
2026-11-09  2:07     ` Gary Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avEq_ngShxlvFSbS@gary-System-Product-Name \
    --to=gary.yang@cixtech.com \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®