From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=194.117.254.33 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794208534; b=G72FV3p5Fb4nVDHY6bY9FA1TQoxgoC19i/UcK5pdq4ufeVMqAqYTokka4RJxy2vNwSl5 9o8VFb188RdO3W+XkfJ0GCsluruxykMbhwPi89J373xiv8FiDNlSS8uE9Z0b04ivxyaiM Bqf1zuf2Hgt1TSWnQBZ2srNBLIPVSW4W+Wkq3hX4r6QuTO95OEfVd/yg+9kMhcquWGogN bgXxpGzbKOC+jrs8d8olodT/srTWPW7MVhdO3II+o4OMBgf0PbBUgvIAiVIq3Pd4vtKEc Gvp+mDmiviojB23o+UYHrJsHgm/gy9wnJhmjcvyku13l8nlH/Q1nh2+1xsqlePNSxmw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794208534; h=DMARC-Filter:DKIM-Signature:Received:Received:X-UD-Smtp-Session:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=NDe69qNLIYTdhsLYqYQaekRTxEOj0NjeZaREVZUZT1k=; b=KGlHre1mcWyRH4QP5WokfBVPus6iUXQ6c/vZWXBZpz8UhvryH/6oSTzuvrxMERdnM7Be 7EZvfju7uPJc919jDpTfJRF87f/z+w9+kjFhXG+9NOxOeScGOSlf0QyuhtK738FC+vM3V /SOYGeKyF/FCcj5cENxh+AT0l1Q+nAkEzoquOC1TGfxvjfnZRlqz+VBUHrzkm/xNpic6r 3qB9dv4s90NYhl8CuW1lK1Ium8WZgEbkSIHBS+6bCpvpHl2N4P7RuVG9omZ1hq+PZ9UzK TYv9KYE/NJ7AnrM/OrqZWjz3qMV1yLqR2qR74zWK6CqXVAy2mAC9A0hj+7zvnZBYsvg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b="i2/ox5zl"; arc=none smtp.remote-ip=194.117.254.33 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351C8606A322 for ; Mon, 9 Nov 2026 07:15:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 351C8606A322 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=i2/ox5zl DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=NDe6 9qNLIYTdhsLYqYQaekRTxEOj0NjeZaREVZUZT1k=; b=i2/ox5zlx48Yc9tPUkPZ myNyvSR8O6TjJ0DwTg3U28GlwBgpxYJQT+kHtERfTPsamq8A8xpaDcWtNVjEB4d9 hEZFdzWg8JvsKhlQ3WLS4yCqkCcIk76cVNutKyM8R+OuOBYtL3ZHxpMSCrY2t50K jYTVnWANWRaTLUxUm7l+kekFNa9WZ3akqOPJEmlFyvZSV+NIddtHWfcS4Qx55x0b bqA6Ep/3pWiJvGbQIm08RvQb1+GCjzv2wP97vfcm4jccccuty//1AXN9ZZgyNLNo xjUBWivV7vLWE8TH+pzJ3FadM8rhFuzaVQmYLkKyM3Vi4HPRSgCBjtjmu9e2KD9N IQ== Received: (qmail 3136135 invoked from network); 9 Nov 2026 08:15:29 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 9 Nov 2026 08:15:29 +0100 X-UD-Smtp-Session: l3s3148p1@zC8QutJffLMujntg Date: Mon, 9 Nov 2026 08:15:29 +0100 From: Wolfram Sang To: Dmitry Guzman Cc: Linus Walleij , Andi Shyti , srinidhi kasagar , Ben Dooks , Andrea Gallo , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] i2c: nomadik: handle pm_runtime errors Message-ID: References: <20261103-i2c-nomadik-fixes-v1-0-655c6af2cb70@mobileye.com> <20261103-i2c-nomadik-fixes-v1-6-655c6af2cb70@mobileye.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 09, 2026 at 08:03:09AM +0100, Wolfram Sang wrote: > > > - pm_runtime_get_sync(&priv->adev->dev); > > + i = pm_runtime_get_sync(&priv->adev->dev); > > + if (i) > > + return i; > > Testbots revealed a smatch warning: > > drivers/i2c/busses/i2c-nomadik.c:737 nmk_i2c_xfer() warn: pm_runtime_get_sync() also returns 1 on success > > I will fix it here. Like this: diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 104da275ff91..8cf1d443a25c 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -734,13 +734,13 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap, struct nmk_i2c_dev *priv = i2c_get_adapdata(i2c_adap); status = pm_runtime_get_sync(&priv->adev->dev); - if (status) + if (status < 0) return status; /* setup the i2c controller */ setup_i2c_controller(priv); - for (i = 0; i < num_msgs; i++) { + for (i = 0, status = 0; i < num_msgs; i++) { priv->cli.slave_adr = msgs[i].addr; priv->cli.buffer = msgs[i].buf; priv->cli.count = msgs[i].len; Note that setting status = 0 is not really required as the I2C core will ensure num_msgs to be > 0. But if people really hack around it, they could circumvent that. And code checkers will recognize this path until we fix the loophole.