From: Peng Fan <peng.fan@oss.nxp.com>
To: Stefan Ghetu <stefan.ghetu@nxp.com>
Cc: abelvesa@kernel.org, peng.fan@nxp.com, sboyd@kernel.org,
bmasney+clk@redhat.com, jbrunet+clk@baylibre.com,
Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-clk@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Florin Pavelescu <florin.pavelescu@nxp.com>
Subject: Re: [PATCH v2] clk: imx: pll14xx: Fix potential integer overflow
Date: Mon, 9 Nov 2026 20:39:56 +0800 [thread overview]
Message-ID: <avG_HJDImzvZnoFS@nxa18884-linux-1.ap.freescale.net> (raw)
In-Reply-To: <20261109113138.10845-1-stefan.ghetu@nxp.com>
On Mon, Nov 09, 2026 at 01:31:38PM +0200, Stefan Ghetu wrote:
>From: Florin Pavelescu <florin.pavelescu@nxp.com>
>
>Cast to u64, so that multiplications and additions will be done
>in 64-bit arithmetic and the possibility of integer overflow is eliminated.
>
>Fixes: 53990cf9d5b48 ("clk: imx: pll14xx: consolidate rate calculation")
>Signed-off-by: Florin Pavelescu <florin.pavelescu@nxp.com>
>Signed-off-by: Stefan Ghetu <stefan.ghetu@nxp.com>
It will not overflow. See this:
https://lore.kernel.org/all/6181060a-ae36-4d0f-bfe0-c1e5c8a8ab3c@gmail.com/
If we do want to silence some warnings from tools, drop the Fixes tag,
and update to commit message accordingly.
Regards
Peng
prev parent reply other threads:[~2026-11-09 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 11:31 Stefan Ghetu
2026-11-09 11:51 ` Daniel Baluta
2026-11-09 12:39 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avG_HJDImzvZnoFS@nxa18884-linux-1.ap.freescale.net \
--to=peng.fan@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=abelvesa@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=festevam@gmail.com \
--cc=florin.pavelescu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=jbrunet+clk@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=stefan.ghetu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®