From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794243693; b=bo5N8n5pghPISVXkWWLZa/ka9T65WL/RPtlUjuquAlvOzMc/w/YZ7M5bgcofMRL5z9Ut 0srDCxGsD926nEEIofJvwuDMnxyqSld04U7QxdNAT0Wa0QdeRmJJssFfWHWZp/mGAOK2H k4/ggjJBn1Rk8dDPecI2DxIVFwtDo9mA6YTQ4Rqd0GZJdccibtkyS0dyaI7mvfKNtI2Qg D4cfuoWwD4/revKwhsibQpyWUn8UHGtuh2aJICu/vmkO5JgkPLgbxSwNvYy3Ko4VO79aV QBqqz6TorZPxA53GU2dH4w9fkzVJYqbYwY8pxKXJrc96xXZBmmIxyEMLIJgNMhTcjrg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794243693; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=IJJA/oulexA9Wi8BzNg299HmiKK85/J/7UwO2YuuFAE=; b=eSfCMfqMaI8ss/HQPgU0e21qC/QmM46qLqk2O1T470sBkdhumKod9yct53gg+J366mfA 3tBpEMkR1DR6CEhBYvrBK7XOdLMAfKdA9799MYeJpe5x1EPKXql6CX5nIFV+R+BUGIFLT U0gXIKhr9N0jxDVHkhGWl/OSsgF6bZoKC+TpStpKAUDrxk/GipDOkk4cSTspCisJNkQjf eR/xXJk5fUdildMHKwauOQodQBBDEIBDroKs7/Q4jCp5n52AKy6yOTljT1UfXBl2NqYie FD40p+VqF4qx/RhAK+WbUOKQtQ6Z35cqRy9tXaRxMFb4pzqQQGtuJ4pt+YSzDsNK2tQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OXe4ayyk; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BC2C606A31C; Mon, 9 Nov 2026 17:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OXe4ayyk Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAE241F008A1; Mon, 9 Nov 2026 17:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794243693; bh=IJJA/oulexA9Wi8BzNg299HmiKK85/J/7UwO2YuuFAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OXe4ayykX8PUhC/4mrNJvncbfHA3iL/5BrhRULUfvCb//HukvqL4y9L8+ZI2+vW9+ doj8jdAoDBms4Y/TX9s9GeRGv6bI1Ltpt/Lu8J5o8F0yXtKHYH960N4EPGuHQUuiS/ B22zxkwtnpfjOTfPuxCsPIbzylf0Elc7CEBHgMSoo+UQXgyzRCL+P50xk8E142A+WV j64x0q5W0uSDp/Hk2Xq4WbWA/NCM/42wyA2jcpJB/sy6XhQedT2XBt20lZtmVJqQ2t K4ASDB/NlEAdIJVJoGnNwe0XMIyt/1Qbr/6ykjLENJ/RenFPKeiz7rH3eSvw6S5CQS hlY+XwYPl3T9g== Date: Mon, 9 Nov 2026 17:01:17 +0000 From: "Lorenzo Stoakes (ARM)" To: "David Hildenbrand (Arm)" Cc: Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , "Matthew Wilcox (Oracle)" , Jan Kara , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo , Jann Horn , Lance Yang , Zi Yan , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Usama Arif , Kiryl Shutsemau , Xu Xin , Chengming Zhou , Madhavan Srinivasan , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , "Ritesh Harjani (IBM)" , Shrikanth Hegde , Pedro Falcato , Kairui Song , Qi Zheng , Shakeel Butt , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Leon Romanovsky , SJ Park , Rakie Kim , David Rientjes , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Masami Hiramatsu , Oleg Nesterov , John Johansen , Georgia Garcia , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej =?utf-8?B?TW9zbsOhxI1law==?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, damon@lists.linux.dev, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 07/13] mm/madvise: convert madvise_vma_behavior() to use vma_flags_t Message-ID: References: <20261105-late-2026-vma-flags-v1-0-0d3cd15ab75f@kernel.org> <20261105-late-2026-vma-flags-v1-7-0d3cd15ab75f@kernel.org> <65038fdc-f4a1-461d-b7b9-669885f15c3c@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65038fdc-f4a1-461d-b7b9-669885f15c3c@kernel.org> On Mon, Nov 09, 2026 at 03:10:12PM +0100, David Hildenbrand (Arm) wrote: > > --- a/mm/ksm.c > > +++ b/mm/ksm.c > > @@ -779,7 +779,8 @@ static struct vm_area_struct *find_mergeable_vma(struct mm_struct *mm, > > if (ksm_test_exit(mm)) > > return NULL; > > vma = vma_lookup(mm, addr); > > - if (!vma || !vma_test(vma, VMA_MERGEABLE_BIT) || !vma_has_anon_rmap(vma)) > > + if (!vma || !vma_test(vma, VMA_MERGEABLE_BIT) || > > + !vma_has_anon_rmap(vma)) > > This change should be dropped form this patch IIUC. > > It would have to go into the previous one (that I applied) but it's not actually > required. > > Unless I am missing something :) Yup I'm not bothered by whitespace-only changes :P Feel free to drop this bit! -- Cheers, Lorenzo