From: Oleg Nesterov <oleg@redhat.com>
To: Will Deacon <will@kernel.org>
Cc: Zhao Gongyi <zhaogongyi@bytedance.com>,
catalin.marinas@arm.com, mark.rutland@arm.com,
ruanjinjie@huawei.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: ptrace: don't warn on missing siginfo in a group-stop
Date: Mon, 9 Nov 2026 14:43:22 +0100 [thread overview]
Message-ID: <avHN-qWRu--arO8a@redhat.com> (raw)
In-Reply-To: <aus7mMS4tXAzPCSi@willie-the-truck>
Will,
sorry for late reply, I was on PTO.
On 11/04, Will Deacon wrote:
>
> > > @@ -588,7 +584,7 @@ static void update_syscall_orig_x0_after_ptrace(struct task_struct *target)
> > > * Don't update orig_x0 for a syscall-exit-stop, as x0 now contains the
> > > * return value of the system call.
> > > */
> > > - if ((info->si_code & ~0x80) == SIGTRAP &&
> > > + if (info && (info->si_code & ~0x80) == SIGTRAP &&
> > > target->ptrace_message == PTRACE_EVENTMSG_SYSCALL_EXIT) {
> > > return;
> >
> > LGTM, but I don't understand this arm-specific code.
>
> Welcome to the club :)
Thank you ;)
> The original rationale is described in e057b9477232 ("arm64: syscall:
> Ensure saved x0 is kept in-sync with tracer updates"), so hopefully that
> helps to set the scene.
[...snip...]
Thanks for your explanations. Yes, I tried to read that and other commits.
The only result is that I've managed to convinced myself that more or less
I understand why 88b839ce497c and 5a87e8c7f3702 make sense.
> So that's the mess we're in and I'm all ears if there's a cleaner way to
> sort it out without breaking anything that relies on the fragile semantics
> we already have.
No, I can't suggest anything better. I think your patches and the fix from
Zhao are fine.
----------------------------------------------------------------------------
Now the question...
So we had CVE-2026-68171 and then it was rejected:
https://lore.kernel.org/linux-cve-announce/2026081123-REJECTED-f1f0@gregkh/
Now we have another one, CVE-2026-90347
https://lore.kernel.org/linux-cve-announce/2026091703-CVE-2026-90347-6f2c@gregkh/
Why?
To me the problem looks minor (security wise). Yes, a malicious debugger can
fool seccomp. So what? What is the real problem from the scurity perspective?
Oleg.
next prev parent reply other threads:[~2026-11-09 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 11:07 Zhao Gongyi
2026-10-23 13:24 ` Oleg Nesterov
2026-10-24 14:50 ` Zhao Gongyi
2026-10-24 15:09 ` Oleg Nesterov
2026-11-04 14:05 ` Will Deacon
2026-11-09 13:43 ` Oleg Nesterov [this message]
2026-10-26 18:32 ` Catalin Marinas
2026-11-02 7:42 ` Jinjie Ruan
2026-11-02 7:54 ` Jinjie Ruan
2026-11-02 8:45 ` Zhao Gongyi
2026-11-02 11:31 ` Oleg Nesterov
2026-11-04 13:41 ` Will Deacon
2026-11-05 4:15 ` Zhao Gongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avHN-qWRu--arO8a@redhat.com \
--to=oleg@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ruanjinjie@huawei.com \
--cc=will@kernel.org \
--cc=zhaogongyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®