From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <crofts@kernel.org>
Cc: raoxu <raoxu@uniontech.com>,
jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, luiz.von.dentz@intel.com, brgl@kernel.org,
pmenzel@molgen.mpg.de, pengpeng@iscas.ac.cn,
u.kleine-koenig@baylibre.com, lars@metafoo.de,
mike.looijmans@topic.nl, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ltc2471: Fix LTC2473 differential offset
Date: Mon, 9 Nov 2026 19:31:07 +0200 [thread overview]
Message-ID: <avIDW76X2QKSIYH-@ashevche-desk.local> (raw)
In-Reply-To: <20261109131208.00006886@kernel.org>
On Mon, Nov 09, 2026 at 01:12:08PM +0100, Joshua Crofts wrote:
> On Mon, 9 Nov 2026 18:06:59 +0800
> raoxu <raoxu@uniontech.com> wrote:
>
> > The LTC2473 reports its differential conversion result as an unsigned
> > 16-bit value spanning -VREF to +VREF. The IIO scale is consequently
> > reported as 2 * VREF divided by 2^16.
> >
> > IIO offsets are expressed in raw codes, but the driver currently returns
> > -LTC2471_VREF, which is a millivolt value. This makes the processed
> > reading incorrect: with a 1.25 V reference, the midpoint raw code is
> > shifted by 1250 instead of 32768 codes.
> >
> > Return the raw-code offset so that the midpoint maps to 0 mV and the
> > endpoints map to -VREF and +VREF as intended. The single-ended LTC2471
> > does not expose the offset attribute and is unaffected.
> >
> > The supplied fix was reviewed and this commit message prepared with
> > OpenCode AI assistance.
> >
> > Fixes: 1d3eacbfa644 ("iio: Add LTC2471/LTC2473 driver")
> > Signed-off-by: Xu Rao <raoxu@uniontech.com>
> > Cc: stable@vger.kernel.org
> > ---
>
> Looks fine, but please wait at least 24 hours before sending a
> new version. If you spot an issue after sending the patch, please
> reply to it describing the problem.
Yep, it misses tag from Nuno now. So, v3 with changelog and all tags please!
Easy to get if you use `b4` for that.
> Reviewed-by: Joshua Crofts <crofts@kernel.org>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-09 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:06 raoxu
2026-11-09 12:12 ` Joshua Crofts
2026-11-09 17:31 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avIDW76X2QKSIYH-@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brgl@kernel.org \
--cc=crofts@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=mike.looijmans@topic.nl \
--cc=nuno.sa@analog.com \
--cc=pengpeng@iscas.ac.cn \
--cc=pmenzel@molgen.mpg.de \
--cc=raoxu@uniontech.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®