mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to RK3588 EVB1
Date: Mon, 9 Nov 2026 18:51:15 +0100	[thread overview]
Message-ID: <avIEPncVnojQBqpX@venus> (raw)
In-Reply-To: <5573124.44csPzL39Z@diego>

[-- Attachment #1: Type: text/plain, Size: 3242 bytes --]

Hi,

On Mon, Nov 09, 2026 at 02:26:44PM +0100, Heiko Stübner wrote:
> Am Montag, 9. November 2026, 02:31:35 Mitteleuropäische Normalzeit schrieb Chaoyi Chen:
> > Hi Sebastian,
> > On 11/9/2026 3:42 AM, Sebastian Reichel wrote:
> > > Hello Chaoyi,
> > > 
> > > On Sun, Nov 08, 2026 at 11:15:09AM +0800, Chaoyi Chen wrote:
> > >> Hi Sebastian,
> > >>
> > >> On 11/7/2026 5:57 AM, Sebastian Reichel wrote:
> > >>> The RK3588 EVB1 comes with a W552793DBA-V10 Touchscreen/Display
> > >>> combination. It contains a Wanchanglong W552793BAA panel and a
> > >>> Goodix GT1158 touchscreen. This adds the DT description of it.
> > >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > >>> ---
> > >>>  arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 90 ++++++++++++++++++++++++
> > >>>  1 file changed, 90 insertions(+)
> > >>>
> > >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > >>> index 6a95a8bb6fb8..327ca13b60f0 100644
> > >>> --- a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > >>> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > >>> @@ -204,6 +204,15 @@ vcc12v_dcin: regulator-vcc12v-dcin {
> > >>>  		regulator-max-microvolt = <12000000>;
> > >>>  	};
> > >>>  
> > >>
> > >> I seem unable to apply the patch to the latest linux-next tree.
> > >>
> > >> So I tried to resolve the conflict manually, but the actual
> > >> test screen did not display. I will look into this further.
> > > 
> > > Strange. The base of this series was Heiko's for-next tree from
> > > Friday. No RK3588 EVB1 patches landed since then:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=cabb6811c38a46337d5f4252b4dc390f9296856c
> > > 
> > > If your board uses the original Rockchip bootloader, which shows a
> > > Rockchip logo on the panel, you also need Cristian's latest YUV420
> > > patches that reset VOP2 at probe time avoiding some issues with the
> > > pre-initialized panel as a side effect. Those were recently applied
> > > by Heiko to the DRM tree, so testing on linux-next is indeed
> > > sensible.
> > > 
> > 
> > Hmm, the newest linux-next tag which I used is next-20261105, and Heiko's 
> > tree last updated date is1106. I'll give it a try on Heiko's tree.
> > 
> > And I'm using mainline U-Boot, which obtained from the latest nightly build:
> > https://gitlab.collabora.com/hardware-enablement/rockchip-3588/debian-image-recipes.
> > 
> > The backlight working correctly, and the DCS command has been sent, but nothing display.
> > Perhaps I should look elsewhere.
> 
> I would assume it could be the SPLL (again).
> 
> I.e. a recent u-boot change broke the SPL-based forced clock init and Jonas
> fixed that in [0]. Had the black display again recently too.
> 
> And it seems it hasn't been merged yet.

Sounds reasonable. FWIW I only tested with the pre-flashed Rockchip
U-Boot (as described above). I intentionally keep that on my RK3588
EVB1, so that I can test RK3588 with vendor TF-A/U-Boot and upstream
or downstream kernel. All my other boards run upstream TF-A/U-Boot.

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-11-09 17:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 21:57 [PATCH 0/5] arm64: dts: rockchip: Enable more features on " Sebastian Reichel
2026-11-06 21:57 ` [PATCH 1/5] arm64: dts: rockchip: Add missing PCIe wake pinmux " Sebastian Reichel
2026-11-06 21:57 ` [PATCH 2/5] arm64: dts: rockchip: Enable NPU " Sebastian Reichel
2026-11-08  2:03   ` Chaoyi Chen
2026-11-08 19:29     ` Sebastian Reichel
2026-11-06 21:57 ` [PATCH 3/5] arm64: dts: rockchip: Enable HDMI sound " Sebastian Reichel
2026-11-06 21:57 ` [PATCH 4/5] arm64: dts: rockchip: Add DSI panel to " Sebastian Reichel
2026-11-08  3:15   ` Chaoyi Chen
2026-11-08 19:42     ` Sebastian Reichel
2026-11-09  1:31       ` Chaoyi Chen
2026-11-09 13:26         ` Heiko Stübner
2026-11-09 17:51           ` Sebastian Reichel [this message]
2026-11-06 21:57 ` [PATCH 5/5] arm64: dts: rockchip: Add Bluetooth " Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avIEPncVnojQBqpX@venus \
    --to=sebastian.reichel@collabora.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®