From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] gpiolib: synchronize updates of descriptor labels
Date: Mon, 9 Nov 2026 20:04:31 +0200 [thread overview]
Message-ID: <avILL4gd737gmDR2@ashevche-desk.local> (raw)
In-Reply-To: <zgvjoccnnhhjmlejoazmz7mpfmndbhi2filwbtudq5i6s46boy@szoywmokacny>
On Fri, Nov 06, 2026 at 10:22:07AM +0100, Bartosz Golaszewski wrote:
> On Thu, Nov 05, 2026 at 04:53:10PM +0200, Andy Shevchenko wrote:
> > On Thu, Nov 05, 2026 at 02:23:45PM +0100, Bartosz Golaszewski wrote:
> > > desc_set_label() swaps desc->label with rcu_replace_pointer() but
> > > without any synchronization of concurrent updates. The swap is a plain
> > > read + write: two threads can observe the same old label and then call
> >
> > s/call//
>
> Why? It's "call $function_name" which happens to be call_srcu().
Because with that kind of name it sounds not good (tautological).
> > > call_scru() on the same SRCU head corrupting the state of the chain.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-09 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 13:23 Bartosz Golaszewski
2026-11-05 14:53 ` Andy Shevchenko
2026-11-06 9:22 ` Bartosz Golaszewski
2026-11-09 18:04 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avILL4gd737gmDR2@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®