mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <darwi@linutronix.de>
To: sashiko-reviews@lists.linux.dev
Cc: "Clark Williams" <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Frederic Weisbecker" <frederic@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Derek Barbosa" <debarbos@redhat.com>,
	"Zbigniew Jędrzejewski-Szmek" <zbyszek@amutable.com>,
	"Daan De Meyer" <daan.j.demeyer@gmail.com>,
	"Luca Boccassi" <luca.boccassi@gmail.com>,
	linux-rt-devel@lists.linux.dev, debian-kernel@lists.debian.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 06/10] kconfig-checker: Split schema to support component reuse
Date: Mon, 9 Nov 2026 19:22:06 +0100	[thread overview]
Message-ID: <avIPTjjZ1FZ9sZMg@lx-t490> (raw)
In-Reply-To: <sashiko-outbox-202761@kernel.org>

On Sat, 07 Nov 2026, sashiko-bot@kernel.org wrote:
> > +from jsonschema import Draft7Validator
>
> [Severity: Low]
> Does this import need a "# type: ignore" comment to match the earlier
> "import jsonschema" statement?
>

I don't think so, as mypy does not complain in this situation:

   $ mypy --version

   mypy 2.4.0 (compiled: no)

   $ mypy --strict --no-warn-return-any tools/kconfig-checker/check.py

   Success: no issues found in 1 source file

So I'll keep this as-is.

>
> [Severity: Low]
> Schema.as_dict() has no remaining callers in this patch or later in the
> series and could be removed.
>

Correct, will remove it.

>
> [Severity: Low]
> Should Documentation/tools/kconfig_checker.rst also be updated here now
> that tools/kconfig-checker/schema.yml has moved to
> tools/kconfig-checker/schemas/base.yml and
> tools/kconfig-checker/schemas/rules.yml?
>

Correct, the documentation should be updated in this very same patch
(instead of updating the docs two patches foreward.)

Thanks,
Ahmed

  reply	other threads:[~2026-11-09 18:22 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  9:19 [PATCH v1 00/10] tools: Introduce a kernel configuration checker Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 01/10] kconfig-checker: Add schema for rule files Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09 12:40     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 02/10] kconfig-checker: Introduce PREEMPT_RT configuration rules Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 18:09     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 03/10] kconfig-checker: Add the configuration checker code Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 19:29     ` Ahmed S. Darwish
2026-11-08 18:59   ` Julian Braha
2026-11-09 13:00     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 04/10] kconfig: Introduce checkconfig target Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-08 18:59   ` Julian Braha
2026-11-09  0:39     ` Nathan Chancellor
2026-11-09 13:18       ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 05/10] Documentation: Describe kconfig-checker usage and design Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 06/10] kconfig-checker: Split schema to support component reuse Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 18:22     ` Ahmed S. Darwish [this message]
2026-11-06  9:19 ` [PATCH v1 07/10] kconfig-checker: Introduce overlays schema Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 16:47     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 08/10] kconfig-checker: Add support for rule overlays Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 09/10] Documentation: Describe kconfig-checker overlays Ahmed S. Darwish
2026-11-07  9:20   ` sashiko-bot
2026-11-09 16:50     ` Ahmed S. Darwish
2026-11-06  9:19 ` [PATCH v1 10/10] kconfig: Introduce OVERLAY= for make checkconfig Ahmed S. Darwish
2026-11-08 18:59 ` [PATCH v1 00/10] tools: Introduce a kernel configuration checker Julian Braha
2026-11-09  0:37   ` Nathan Chancellor
2026-11-09 16:15     ` Ahmed S. Darwish
2026-11-09 16:52       ` Nathan Chancellor
2026-11-09 17:04         ` Ahmed S. Darwish
2026-11-09 15:49   ` Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avIPTjjZ1FZ9sZMg@lx-t490 \
    --to=darwi@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daan.j.demeyer@gmail.com \
    --cc=debarbos@redhat.com \
    --cc=debian-kernel@lists.debian.org \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=luca.boccassi@gmail.com \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zbyszek@amutable.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®