From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Archit Anant <architanant5@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org,
nuno.sa@analog.com, u.kleine-koenig@baylibre.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
joshua.crofts1@gmail.com
Subject: Re: [PATCH v6 11/11] iio: adc: ti-ads1015: Replace custom shift macros with FIELD_PREP/GET
Date: Mon, 9 Nov 2026 21:43:33 +0200 [thread overview]
Message-ID: <avIiZfJtj0DTArWR@ashevche-desk.local> (raw)
In-Reply-To: <20261109165805.31160-6-architanant5@gmail.com>
On Mon, Nov 09, 2026 at 10:28:05PM +0530, Archit Anant wrote:
> The driver currently uses custom _SHIFT macros and manual bitwise
> operations to read and write to the configuration register.
>
> Modernize the bitwise logic by replacing all manual shifts with the
> standard FIELD_PREP() and FIELD_GET() macros from <linux/bitfield.h>.
> This improves readability and prevents potential bitwise errors.
>
> Remove the now-unused _SHIFT macros from the top of the file.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> + mask = ADS1015_CFG_MUX_MASK | ADS1015_CFG_PGA_MASK |
> + ADS1015_CFG_DR_MASK;
Indentation is broken here.
> + cfg = FIELD_PREP(ADS1015_CFG_MUX_MASK, chan) |
> + FIELD_PREP(ADS1015_CFG_PGA_MASK, pga) |
> + FIELD_PREP(ADS1015_CFG_DR_MASK, dr);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-09 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 16:58 [PATCH v6 06/11] iio: adc: ti-ads1015: Remove ads1015_set_power_state() Archit Anant
2026-11-09 16:58 ` [PATCH v6 07/11] iio: adc: ti-ads1015: drop unneeded < 0 error checks Archit Anant
2026-11-09 18:49 ` Andy Shevchenko
2026-11-09 16:58 ` [PATCH v6 08/11] iio: adc: ti-ads1015: use devm_mutex_init() Archit Anant
2026-11-09 16:58 ` [PATCH v6 09/11] iio: adc: ti-ads1015: use managed runtime PM setup Archit Anant
2026-11-09 16:58 ` [PATCH v6 10/11] iio: adc: ti-ads1015: inline ads1015_set_conv_mode() Archit Anant
2026-11-09 16:58 ` [PATCH v6 11/11] iio: adc: ti-ads1015: Replace custom shift macros with FIELD_PREP/GET Archit Anant
2026-11-09 19:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avIiZfJtj0DTArWR@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®