From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dan Carpenter <dan@cryspen.com>
Cc: Dan Carpenter <error27@gmail.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] keys/trusted/tpm2: rename "bool" to "boolean"
Date: Mon, 9 Nov 2026 22:13:34 +0200 [thread overview]
Message-ID: <avIpbqYocfnGV5eb@kernel.org> (raw)
In-Reply-To: <avIoVVFxZ8PTniEz@kernel.org>
On Mon, Nov 09, 2026 at 10:08:58PM +0200, Jarkko Sakkinen wrote:
> On Mon, Nov 09, 2026 at 10:48:58PM +0300, Dan Carpenter wrote:
> > On Mon, Nov 09, 2026 at 04:54:13PM +0200, Jarkko Sakkinen wrote:
> > >
> > > Are we migrating to C23? I've not followed this too closely.
> >
> > Google AI says that we will adopt C23 next year or the year after.
> > I argued that it would be would be after 2030 but AI said, "No, there
> > is too much juicy stuff in C23 for kernel developers to wait so long."
> >
> > I don't have a pressing need for this patch to be merged. I was
> > just playing with some compiler related tools noticed this. It's
> > the only place in the kernel which uses "bool" as a variable name.
>
> I do think that bool is not great choice for a variable name; in fact
> it is quite horrible choice. But since there is no other force than being
> horrible name, I think I'll pass...
In order to put this in a proper context, I meant that bad variable
names are common. I'm not blaming patch author in particular,
especially since it is a local variable. It is just something that
happens all the time; occasionally.
We could merge a billion patches like this with no other effect than
causing extra merge conflicts in backports. So the net-effect is
more harm than good.
Br, Jarkko
prev parent reply other threads:[~2026-11-09 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 5:39 Dan Carpenter
2026-11-09 14:54 ` Jarkko Sakkinen
2026-11-09 19:48 ` Dan Carpenter
2026-11-09 20:08 ` Jarkko Sakkinen
2026-11-09 20:13 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avIpbqYocfnGV5eb@kernel.org \
--to=jarkko@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dan@cryspen.com \
--cc=dhowells@redhat.com \
--cc=error27@gmail.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®