From: Kuniyuki Iwashima <kuniyu@google.com>
To: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Cc: Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Jann Horn <jannh@google.com>, Kirill Tkhai <tkhai@ya.ru>,
apais@microsoft.com, rlmenge@gmail.com,
hargar@linux.microsoft.com, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/4] af_unix: Fix inq_len and scm_stat.nr_fds accounting leaks
Date: Tue, 10 Nov 2026 06:38:56 +0000 [thread overview]
Message-ID: <avK7nGo4aGxJ7QiU@google.com> (raw)
In-Reply-To: <20261106051905.218638-1-sidchintamaneni@gmail.com>
On Fri, 06 Nov 2026 05:19:01 +0000, Siddharth Chintamaneni wrote:
> This series fixes receive-queue accounting leaks of u->inq_len and
> u->scm_stat.nr_fds in AF_UNIX sockets, along with selftests:
>
> - Patch 1 fixes a u->inq_len leak in manage_oob() when an unconsumed
> out-of-band (MSG_OOB) skb is skipped and dropped during a normal read.
> - Patch 2 fixes u->scm_stat.nr_fds leaks when an OOB skb is skipped or
> freed in manage_oob(), unix_stream_recv_urg(), and
> unix_stream_read_skb().
> - Patch 3 fixes a u->scm_stat.nr_fds leak in unix_dgram_disconnected()
> when purging queued skbs from sk->sk_receive_queue on disconnect.
> - Patch 4 adds SIOCINQ and scm_fds (/proc/self/fdinfo/<fd>) checks to
> the msg_oob and scm_rights selftests.
I planed to drop MSG_OOB support in this cycle.
Could you repost without OOB changes ?
>
> Siddharth Chintamaneni (4):
> af_unix: Fix inq_len leak when skipping unread OOB skb.
> af_unix: Fix scm_stat.nr_fds leaks for OOB skb.
> af_unix: Fix scm_stat.nr_fds leak in unix_dgram_disconnected().
> selftest: af_unix: Test SIOCINQ and scm_fds with OOB and dgram
> disconnect.
>
> net/unix/af_unix.c | 69 ++++++-----
> tools/testing/selftests/net/af_unix/msg_oob.c | 12 +-
> .../selftests/net/af_unix/scm_rights.c | 108 ++++++++++++++++++
> 3 files changed, 161 insertions(+), 28 deletions(-)
>
> --
> 2.43.0
>
prev parent reply other threads:[~2026-11-10 6:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 5:19 Siddharth Chintamaneni
2026-11-06 5:19 ` [PATCH net 1/4] af_unix: Fix inq_len leak when skipping unread OOB skb Siddharth Chintamaneni
2026-11-06 5:19 ` [PATCH net 2/4] af_unix: Fix scm_stat.nr_fds leaks for " Siddharth Chintamaneni
2026-11-10 6:38 ` netdev-bot+sashiko
2026-11-06 5:19 ` [PATCH net 3/4] af_unix: Fix scm_stat.nr_fds leak in unix_dgram_disconnected() Siddharth Chintamaneni
2026-11-10 6:38 ` netdev-bot+sashiko
2026-11-06 5:19 ` [PATCH net 4/4] selftest: af_unix: Test SIOCINQ and scm_fds with OOB and dgram disconnect Siddharth Chintamaneni
2026-11-10 6:38 ` netdev-bot+sashiko
2026-11-06 5:21 ` [PATCH net 0/4] af_unix: Fix inq_len and scm_stat.nr_fds accounting leaks netdev-bot+sinfo
2026-11-10 6:38 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avK7nGo4aGxJ7QiU@google.com \
--to=kuniyu@google.com \
--cc=apais@microsoft.com \
--cc=edumazet@kernel.org \
--cc=hargar@linux.microsoft.com \
--cc=horms@kernel.org \
--cc=jannh@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rlmenge@gmail.com \
--cc=shuah@kernel.org \
--cc=sidchintamaneni@gmail.com \
--cc=tkhai@ya.ru \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®