From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.249 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794294348; b=bASC2S88E2OQfBj+sg539aGf7gDZyUUoSJOPP9yigH4nc2QL4dq3P8+r5Jm2NwpA2iVQ cxX/6X1LOaL+nN+oeia33I0bLs/xWCYShKk8IlXz49m9Kf5+rinqgzVgecKfRdhJts4z2 6NsBbXdv4rJSrgpCScKVJY1jHP3BzY+4K4wlkSSoT5JLTK1Qv/HBsvgK/9a5d6cCqL80r tCaZzriSJ2gnhPclxdzyEZ/3hTk/XF8syl+bkFvg0pJLAyvakhce6Y8814uCJ+cZpkYX9 PyKOSP+pOCTt1lcNikWSKGdgVOoFHE874D1+CJiZPY2UgF0jTNJPzIUiAjSbI7CcL1Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794294348; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=zZk3SsVUMy8xoTgawAV8jGI3OOcRbHbKMzszzz5dC0s=; b=z+Ncqy7ihwM5TSg5bEG+5I9VDdm2g0cBvLscADtINmP5qOkU4g+WZry6+1KNdPalP1eB wqDoiaiv87tFRqkxGhyklQueCZg1oYzl5CPKUgt73YFZHTVi+e9J4Cxq/KsViHa0HxiHf xnNOdNpFZEQs1TNbkAJr1j3pToL2n2gpT2LSS4Ose7iX3Aa3FRz1n3x9LP2TCxo/ewBDw +gheG0snnuRcmA3mUZCBUjZEy2tYXTGN/uI5GoVm5JFCMNBt9jtWp/eVqzOmz/hO0ojmQ lal7uapC+W1cd5T1r6Dap2MQShA+U0GRMg5NnUnC85wWPltcZXGcVihxXlOzeOc8ejQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b="uX/FQNF4"; arc=none smtp.remote-ip=91.218.175.249 Received: from mta0.migadu.com (out-249.mta0.migadu.com [91.218.175.249]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85504606A31C for ; Tue, 10 Nov 2026 07:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85504606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=uX/FQNF4 X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=PDz+qwYH/e/DPGEx5k9eJgKdIlMjdKtiXOXsonysk0k=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794294345; v=1; x=1794899145; b=uX/FQNF40xr/pIkkUgsE2UNKnZG75Tt6NWSf5BNLlae16iQAeBMtFrIU9GhpOqq/Euhb5aXY euuyrcGDewk+jI62Yq7+p2mLv6DqABEtEDLGNMGy3wNBO17j1cUZsBPTnCsrB6BUimiEtWjhrgZ mESlCW1ciTfPNgA3w+DJiY/8= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 6dea8860f641d184; Tue, 10 Nov 2026 07:05:27 +0000 X-Mizu-Trace-ID: 6dea8860f641d184 X-Migadu-Flow: FLOW_OUT Date: Tue, 10 Nov 2026 15:05:14 +0800 From: Hao Li To: Tiezhu Yang Cc: Alexei Starovoitov , Vlastimil Babka , Harry Yoo , Andrew Morton , Christoph Lameter , David Rientjes , Roman Gushchin , linux-mm@kvack.org, loongarch@lists.linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/slub: Genericize x86-specific cmpxchg16b comment Message-ID: References: <20261109035906.10857-1-yangtiezhu@loongson.cn> <145c23ea-bc4d-b235-c822-df94b00a647a@loongson.cn> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <145c23ea-bc4d-b235-c822-df94b00a647a@loongson.cn> On Tue, Nov 10, 2026 at 09:29:04AM +0800, Tiezhu Yang wrote: > On 11/10/26 2:25 AM, Alexei Starovoitov wrote: > > On Sun, Nov 08, 2026 at 07:59 PM Tiezhu Yang wrote: > > > atomic primitive is satisfied by different hardware implementations: > > > (1) arm64: satisfies it via LSE atomics ('casp' instruction) > > [...] > > > Update the comment to "double-width atomic cmpxchg", which provides the > > > following advantages: > > > (1) Accurately describes the cross-platform hardware invariant. > > > > You ignored Hao's point about shorter commit logs. > > If the following shorter commit message is preferred: > > mm/slub: Genericize x86-specific cmpxchg16b comment > > In __kmalloc_nolock_noprof(), update the comment from x86-specific > "cmpxchg16b" to generic "double-width atomic cmpxchg". Ok, LGTM. > > I will wait for a while for more feedback from mm maintainers and send > v3 if necessary. > > Thanks, > Tiezhu >