mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@oss.qualcomm.com>
To: Tapas Rana <tapas.rana@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Wesley Cheng <wesley.cheng@oss.qualcomm.com>,
	Esteban Urrutia <esteuwu@proton.me>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	Ronak Raheja <ronak.raheja@oss.qualcomm.com>,
	Faisal Hassan <faisal.hassan@oss.qualcomm.com>,
	Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
	prashanth.k@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] phy: qcom: carry live SS-link state without growing enum phy_mode
Date: Mon, 9 Nov 2026 23:53:53 -0800	[thread overview]
Message-ID: <avLNkT-UPTsFeqsb@hu-petche-lv.qualcomm.com> (raw)
In-Reply-To: <20261106082716.128968-1-tapas.rana@oss.qualcomm.com>

On 26-11-06 13:57:13, Tapas Rana wrote:
> QMP PHY drivers always enable receiver detection (ARCVR_DTCT_EN) in
> autonomous mode, and additionally enable LFPS detection (ALFPS_DTCT_EN)
> when a SuperSpeed link is present; otherwise they fall back to
> receiver-detect event selection (ARCVR_DTCT_EVENT_SEL). This choice is
> made by comparing phy_mode against
> PHY_MODE_USB_HOST_SS/PHY_MODE_USB_DEVICE_SS. However, dwc3 core only
> calls phy_set_mode()/phy_set_mode_ext() with the base
> PHY_MODE_USB_HOST or PHY_MODE_USB_DEVICE, never the _SS/_HS/_FS/_LS
> submodes. As a result, the comparison is always false and the PHY
> always falls back to ARCVR_DTCT_EVENT_SEL, the legacy USB2
> receiver-detect path, regardless of actual link state.
> 
> Add a dedicated qcom_usb_ss_state submode and carry it through the
> generic submode argument phy_set_mode_ext() already defines for this
> purpose, instead of adding more values to the already-overloaded
> phy_mode USB host/device submode list.
> 
> Patch 1 adds the shared enum qcom_usb_ss_state (UNKNOWN/PRESENT/
> ABSENT) as the submode contract. Patch 2 makes
> phy-qcom-qmp-combo.c switch on it instead of on phy_mode. Patch 3
> makes dwc3-qcom.c sample live SuperSpeed child-device presence at
> suspend entry and pass it down.
> 
> The contract is intentionally generic so phy-qcom-qmp-usb.c can adopt
> it the same way for the gadget-side case in a follow-up series,
> without a second mechanism.
> 
> Tested on an x1e80100 CRD. On a host port with a SuperSpeed hub
> attached, suspended the system and then connected a SuperSpeed USB
> pendrive to the hub; confirmed ALFPS_DTCT_EN is set instead of the
> legacy ARCVR_DTCT_EVENT_SEL mask. Repeated the same sequence on the
> USB-OTG capable port with the same result. As a cross-check, repeated
> both suspend scenarios with a High-Speed-only pendrive attached, and
> again with nothing attached, and confirmed the PHY falls back to
> ARCVR_DTCT_EVENT_SEL in both cases, as expected when no SuperSpeed
> device is present.
> 
> This series spans both the generic PHY framework tree and the USB/DWC3
> tree: patch 1 adds a new header, patch 2 depends on patch 1 and touches
> drivers/phy/qualcomm/, patch 3 depends on patches 1-2 and touches
> drivers/usb/dwc3/. All three should be merged in order and ideally
> through the same tree (or with an immutable branch) to avoid a window
> where dwc3-qcom.c references a submode phy-qcom-qmp-combo.c doesn't
> yet switch on. ARM/QUALCOMM MAILING LIST (linux-arm-msm@vger.kernel.org)
> is Cc'd on all three patches since it covers both directories.
> 

Is it really we need to do such complicated, why not just call phy_set_mode
before suspend according to existed downstream port speed under root hub,
it is normal requirement to finalize PHY setting according to connection speed.

Peter


> Tapas Rana (3):
>   phy: qcom-qmp-usb-ss: add shared SS-link-state submode contract
>   phy: qcom: qmp-combo: Select LFPS detect only when SS link is
>     confirmed present
>   usb: dwc3: qcom: pass live SS-link state into PHY at suspend entry
> 
>  drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 27 +++++++++++++++--
>  drivers/usb/dwc3/dwc3-qcom.c              | 36 ++++++++++++++++++++++-
>  include/linux/phy/phy-qcom-qmp-usb-ss.h   | 17 +++++++++++
>  3 files changed, 76 insertions(+), 4 deletions(-)
>  create mode 100644 include/linux/phy/phy-qcom-qmp-usb-ss.h
> 
> -- 
> 2.43.0
> 
> 

-- 

Thanks,
Peter Chen

      parent reply	other threads:[~2026-11-10  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  8:27 Tapas Rana
2026-11-06  8:27 ` [PATCH 1/3] phy: qcom-qmp-usb-ss: add shared SS-link-state submode contract Tapas Rana
2026-11-06  8:27 ` [PATCH 2/3] phy: qcom: qmp-combo: Select LFPS detect only when SS link is confirmed present Tapas Rana
2026-11-06  8:27 ` [PATCH 3/3] usb: dwc3: qcom: pass live SS-link state into PHY at suspend entry Tapas Rana
2026-11-06 15:06 ` [PATCH 0/3] phy: qcom: carry live SS-link state without growing enum phy_mode Konrad Dybcio
2026-11-10  7:53 ` Peter Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avLNkT-UPTsFeqsb@hu-petche-lv.qualcomm.com \
    --to=peter.chen@oss.qualcomm.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=abelvesa@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=esteuwu@proton.me \
    --cc=faisal.hassan@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=prashanth.k@oss.qualcomm.com \
    --cc=ronak.raheja@oss.qualcomm.com \
    --cc=tapas.rana@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    --cc=wesley.cheng@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®