Re: [PATCH v2] media: mali-c55: Require an enabled link to start a video node

[Jacopo Mondi <jacopo.mondi@ideasonboard.com>]

On Mon, Nov 09, 2026 at 10:26:01AM +0100, Linus Walleij wrote:
> On Fri, Nov 6, 2026 at 12:16 AM David Carlier <devnexen@gmail.com> wrote:
>
> > mali_c55_pipeline_ready() skips queues whose link is disabled, but such
> > a queue can still start streaming on its own, as the video node pads
> > lack MEDIA_PAD_FL_MUST_CONNECT. Stopping it later sees a ready pipeline
> > and disables the ISP under the connected queues still capturing.
> >
> > Mark the video node pads MUST_CONNECT so that starting a disconnected
> > node fails with -ENOLINK.
> >
> > Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver")
> > Signed-off-by: David Carlier <devnexen@gmail.com>
>
> It checks out:
> Reviewed-by: Linus Walleij <linusw@kernel.org>
>
> > Changes in v2:
> > - Add missing Signed-off-by.
> > - Cc stable, as d5f281f3dd29 is in the stable tree.
>
> No Cc: stable@vger.kernel.org actually added?
>
> But Jacopo can certainly add that when applying the patch.

I don't have any C55 with the DS pipe fitted to test with, so I'll
just
Acked-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

and I can Cc stable indeed

>
> Yours,
> Linus Walleij

Thanks
   j